Re: [PATCH v3 03/21] qemucapabilitiesdata: Document '+inteltdx' variant

2025-07-03 Thread Peter Krempa via Devel
On Mon, Jun 30, 2025 at 14:17:14 +0800, Zhenzhong Duan wrote: > Upcoming patch will introduce test data from an TDX-enabled host. > Document the new variant. > > Signed-off-by: Zhenzhong Duan > --- > tests/qemucapabilitiesdata/README.rst | 5 + > 1 file changed, 5 insertions(+) Reviewed-by:

Re: [PATCH 1/1] docs : add doc on cpu model and features

2025-07-03 Thread Peter Krempa via Devel
On Thu, Jul 03, 2025 at 17:24:54 +0200, Hector CAO wrote: > From: Hector Cao > > Add documentation on the way libvirt displays the Host CPU > model and capabilities (features). There is an implicit > expection from users to get the CPU model name matching the > CPU model they are running on, howe

RE: [PATCH v3 20/21] qemuxmlconftest: Add latest version of 'launch-security-tdx*' test data

2025-07-03 Thread Duan, Zhenzhong
>-Original Message- >From: Daniel P. Berrangé >Subject: Re: [PATCH v3 20/21] qemuxmlconftest: Add latest version of >'launch-security-tdx*' test data > >On Mon, Jun 30, 2025 at 02:17:31PM +0800, Zhenzhong Duan wrote: >> We now have the '+inteltdx' variant dumped from a modern qemu with t

[PATCH 1/1] docs : add doc on cpu model and features

2025-07-03 Thread Hector CAO
From: Hector Cao Add documentation on the way libvirt displays the Host CPU model and capabilities (features). There is an implicit expection from users to get the CPU model name matching the CPU model they are running on, however, this does not happen most of the time. As a consequence, having a

[PATCH 0/1] docs : add doc on cpu model and features

2025-07-03 Thread Hector CAO
From: Hector Cao Hello, This is a follow-up of the submission: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/EZBLO5CIGC3FTI5J72WNVAKWPSNQFLCY/ Based on Jiri's feedback, it is better to tackle this situation by documentation. You can find here a proposal for the document

Re: [PATCH 04/10] hypervisor: domain: Extract logic for auto shutdown to virDomainDriverAutoShutdownActive

2025-07-03 Thread Pavel Hrdina via Devel
On Thu, Jul 03, 2025 at 02:50:27PM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > Extract the checker that determines whether the daemon auto shutdown > functionality is active to a separate helper > 'virDomainDriverAutoShutdownActive'. > > Signed-off-by: Peter Krempa > --- > sr

Re: [PATCH 03/10] qemu: conf: Store 'autoShutdown' config in virDomainDriverAutoShutdownConfig

2025-07-03 Thread Pavel Hrdina via Devel
On Thu, Jul 03, 2025 at 02:50:26PM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > Rather than having a bunch of extra variables save the configuration of > the daemon auto shutdown in virDomainDriverAutoShutdownConfig which is > also used when initiating the shutdown. > > Signed-o

Re: [PATCH 01/10] virSystemdCreateMachine: Document @maxthreds

2025-07-03 Thread Pavel Hrdina via Devel
On Thu, Jul 03, 2025 at 02:50:24PM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > The parameter overrides the maximum number of threads for the machine. > > Fixes: d5572f62e32 > Signed-off-by: Peter Krempa > --- > src/util/virsystemd.c | 1 + > 1 file changed, 1 insertion(+) Re

Re: [PATCH 02/10] cgroup: Unexport 'virDomainCgroupInitCgroup'

2025-07-03 Thread Pavel Hrdina via Devel
On Thu, Jul 03, 2025 at 02:50:25PM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > The function is called just from one place within the module where it's > defined. > > Signed-off-by: Peter Krempa > --- > src/hypervisor/domain_cgroup.c | 2 +- > src/hypervisor/domain_cgroup.h |

[PATCH 10/10] virDomainDriverAutoShutdown: Refactor selection logic for VMs

2025-07-03 Thread Peter Krempa via Devel
From: Peter Krempa Decide separately and record what shutdown modes are to be applied on given VM object rather than spreading out the logic through the code. This centralization simplifies the conditions in the worker functions and also: - provides easy way to check if the auto-shutdown code w

[PATCH 09/10] virDomainDriverAutoShutdownDoSave: Don't attempt to save transient VMs

2025-07-03 Thread Peter Krempa via Devel
From: Peter Krempa Commit 84bb136c31e added code that intended to skip the save of transient domains but did so only in the setup part where we pause the VMS. The second loop that actually attempts to save the VM was not modified so we'd still try saving them: Jul 03 14:15:13 andariel virtqemud

[PATCH 08/10] hypervisor: Split out individual steps out of virDomainDriverAutoShutdown

2025-07-03 Thread Peter Krempa via Devel
From: Peter Krempa 'virDomainDriverAutoShutdown' grew into an unwieldy function. Extract the code for each of the save/shutdown/poweroff steps into helpers and call them. Signed-off-by: Peter Krempa --- src/hypervisor/domain_driver.c | 285 +++-- 1 file changed, 161

[PATCH 07/10] qemu: Fix auto-shutdown of qemu VMs by the qemu driver

2025-07-03 Thread Peter Krempa via Devel
From: Peter Krempa When auto-shutdown via the qemu driver is requested (rather than via libvirt guests) we need to start the VMs in a way that they will be kept around for libvirt to terminate them. This involves inverting the dependancy relationship for the machined unit file. Since the setup i

[PATCH 06/10] cgroup: Plumb the 'daemonDomainShutdown' parameter of 'virSystemdCreateMachine' to drivers

2025-07-03 Thread Peter Krempa via Devel
From: Peter Krempa Plumb the new argument across the cgroup helpers up to the domain driver code. Signed-off-by: Peter Krempa --- src/ch/ch_process.c| 2 ++ src/hypervisor/domain_cgroup.c | 4 src/hypervisor/domain_cgroup.h | 1 + src/lxc/lxc_cgroup.c | 1 + src/qemu

[PATCH 05/10] virSystemdCreateMachine: Add flag to invert machined unit dependencies

2025-07-03 Thread Peter Krempa via Devel
From: Peter Krempa The existing dependency order of the 'machined' unit file for the domain we're starting ("After libvirtd/virtqemud"->thus shuts down *before* the daemon) is intended to work with 'libvirt-guests.service' which requires the daemon to be around to shut down the VMs. If we want t

[PATCH 04/10] hypervisor: domain: Extract logic for auto shutdown to virDomainDriverAutoShutdownActive

2025-07-03 Thread Peter Krempa via Devel
From: Peter Krempa Extract the checker that determines whether the daemon auto shutdown functionality is active to a separate helper 'virDomainDriverAutoShutdownActive'. Signed-off-by: Peter Krempa --- src/hypervisor/domain_driver.c | 13 ++--- src/hypervisor/domain_driver.h | 1 + sr

[PATCH 03/10] qemu: conf: Store 'autoShutdown' config in virDomainDriverAutoShutdownConfig

2025-07-03 Thread Peter Krempa via Devel
From: Peter Krempa Rather than having a bunch of extra variables save the configuration of the daemon auto shutdown in virDomainDriverAutoShutdownConfig which is also used when initiating the shutdown. Signed-off-by: Peter Krempa --- src/qemu/qemu_conf.c | 30 +++---

[PATCH 02/10] cgroup: Unexport 'virDomainCgroupInitCgroup'

2025-07-03 Thread Peter Krempa via Devel
From: Peter Krempa The function is called just from one place within the module where it's defined. Signed-off-by: Peter Krempa --- src/hypervisor/domain_cgroup.c | 2 +- src/hypervisor/domain_cgroup.h | 10 -- src/libvirt_private.syms | 1 - 3 files changed, 1 insertion(+), 12

[PATCH 01/10] virSystemdCreateMachine: Document @maxthreds

2025-07-03 Thread Peter Krempa via Devel
From: Peter Krempa The parameter overrides the maximum number of threads for the machine. Fixes: d5572f62e32 Signed-off-by: Peter Krempa --- src/util/virsystemd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c index 92d2890360..4f8424ae32 1006

[PATCH 00/10] virDomainDriverAutoShutdown: Fix 3 bugs related to auto shutdown of VMs

2025-07-03 Thread Peter Krempa via Devel
Following bugs are addressed: - ordering of systemd units, which cause the VMs to be killed prior to auto-shutdown finishing - transient VMs are attempted to be managesaved - restore of state is applied to VMs which the auto shutdown code didn't act on otherwise Peter Krempa (10): vir

[PATCH 0/1] qemu qapi: SIGSEGV small fix

2025-07-03 Thread Nikolai Barybin via Devel
Hello everyone! When implementing some custom qemu capability I cought this bug when some string with '*' pattern is not contained in schema, and virQEMUQAPISchemaTraverseObject passes NULL ptr to virJSONValueObjectHasKey. Nikolai Barybin (1): qemu: qapi: fix potential SIGSEGV in virQEMUQAPISc

[PATCH 1/1] qemu: qapi: fix potential SIGSEGV in virQEMUQAPISchemaTraverseObject()

2025-07-03 Thread Nikolai Barybin via Devel
We need to check obj ptr before passing it to virJSONValueObjectHasKey(). If it's NULL it will fail with SIGSEGV. Signed-off-by: Nikolai Barybin --- src/qemu/qemu_qapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_qapi.c b/src/qemu/qemu_qapi.c index 184c0a96

Re: [PATCH] qemu: Switch to virtio-scsi on ARM

2025-07-03 Thread Daniel P . Berrangé via Devel
On Thu, Jul 03, 2025 at 06:02:38AM -0400, Andrea Bolognani via Devel wrote: > On Wed, Jul 02, 2025 at 02:01:07PM -0600, Jim Fehlig wrote: > > On 7/2/25 10:11, Andrea Bolognani wrote: > > > On Thu, Jun 26, 2025 at 03:29:58PM -0600, Jim Fehlig via Devel wrote: > > > > However, I do understand this >

Re: [PATCH v3 20/21] qemuxmlconftest: Add latest version of 'launch-security-tdx*' test data

2025-07-03 Thread Daniel P . Berrangé via Devel
On Mon, Jun 30, 2025 at 02:17:31PM +0800, Zhenzhong Duan wrote: > We now have the '+inteltdx' variant dumped from a modern qemu with tdx > support, > add qemuxmlconftest data for that variant. > > Signed-off-by: Zhenzhong Duan > --- > ...h-security-tdx.x86_64-latest+inteltdx.args | 44 +

Re: [PATCH] qemu: Switch to virtio-scsi on ARM

2025-07-03 Thread Andrea Bolognani via Devel
On Wed, Jul 02, 2025 at 02:01:07PM -0600, Jim Fehlig wrote: > On 7/2/25 10:11, Andrea Bolognani wrote: > > On Thu, Jun 26, 2025 at 03:29:58PM -0600, Jim Fehlig via Devel wrote: > > > However, I do understand this > > > change could break existing ARM VM configurations containing a SCSI > > > contro

Re: [PATCH v1] aspeed: Deprecate the ast2700a0-evb machine

2025-07-03 Thread Cédric Le Goater via Devel
On 7/3/25 07:24, Jamin Lin via Devel wrote: The ast2700a0-evb machine represents the first revision of the AST2700 and serves as the initial engineering sample rather than a production version. A newer revision, A1, is now supported, and the ast2700a1-evb should replace the older A0 version. Sig

[PATCH v1] aspeed: Deprecate the ast2700a0-evb machine

2025-07-03 Thread Jamin Lin via Devel
The ast2700a0-evb machine represents the first revision of the AST2700 and serves as the initial engineering sample rather than a production version. A newer revision, A1, is now supported, and the ast2700a1-evb should replace the older A0 version. Signed-off-by: Jamin Lin --- docs/about/depreca