Re: [PATCH V2 1/5] qom: qom-tree-get

2025-07-07 Thread Markus Armbruster via Devel
Markus Armbruster writes: > Steven Sistare writes: > >> On 7/4/2025 8:22 AM, Markus Armbruster wrote: >>> Steve Sistare writes: >>> Define the qom-tree-get QAPI command, which fetches an entire tree of properties and values with a single QAPI call. This is much faster than usin

Re: [PATCH V2 1/5] qom: qom-tree-get

2025-07-07 Thread Markus Armbruster via Devel
Steven Sistare writes: > On 7/4/2025 8:22 AM, Markus Armbruster wrote: >> Steve Sistare writes: >> >>> Define the qom-tree-get QAPI command, which fetches an entire tree of >>> properties and values with a single QAPI call. This is much faster >>> than using qom-list plus qom-get for every nod

Re: [PATCH V2 4/5] qom: qom-list-getv

2025-07-07 Thread Markus Armbruster via Devel
Steven Sistare writes: > On 7/4/2025 8:22 AM, Markus Armbruster wrote: >> Steve Sistare writes: >> >>> Define the qom-list-getv command, which fetches all the properties and >>> values for a list of paths. This is faster than qom-tree-get when >>> fetching a subset of the QOM tree. See qom.js

[PATCH] NEWS: Mention switch to virtio-scsi on ARM

2025-07-07 Thread Jim Fehlig via Devel
From: Jim Fehlig Signed-off-by: Jim Fehlig --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index d8bd2559f4..59494cb380 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -19,6 +19,12 @@ v11.6.0 (unreleased) * **Improvements** + * qemu: Change default SCSI

Re: [PATCH] qemu: Switch to virtio-scsi on ARM

2025-07-07 Thread Jim Fehlig via Devel
On 7/3/25 04:35, Daniel P. Berrangé wrote: On Thu, Jul 03, 2025 at 06:02:38AM -0400, Andrea Bolognani via Devel wrote: On Wed, Jul 02, 2025 at 02:01:07PM -0600, Jim Fehlig wrote: On 7/2/25 10:11, Andrea Bolognani wrote: On Thu, Jun 26, 2025 at 03:29:58PM -0600, Jim Fehlig via Devel wrote: How

Re: [PATCH V2 4/5] qom: qom-list-getv

2025-07-07 Thread Steven Sistare via Devel
On 7/4/2025 8:22 AM, Markus Armbruster wrote: Steve Sistare writes: Define the qom-list-getv command, which fetches all the properties and values for a list of paths. This is faster than qom-tree-get when fetching a subset of the QOM tree. See qom.json for details. Signed-off-by: Steve Sist

[PATCH 4/5] conf: virDomainChrDefParseTargetXML refactor

2025-07-07 Thread Kirill Shchetiniuk via Devel
From: Kirill Shchetiniuk Refactored the default case port option parsing logic to use the appropriate virXMLPropInt function. Signed-off-by: Kirill Shchetiniuk --- src/conf/domain_conf.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/src/conf/domain_conf.c

[PATCH 5/5] qemu: qemuDomainObjPrivateXMLParseVcpu refactor

2025-07-07 Thread Kirill Shchetiniuk via Devel
From: Kirill Shchetiniuk Refactored the qemuDomainObjPrivateXMLParseVcpu function to use the appropriate virXMLPropUInt function to parse unsigned integers, avoiding unccessery string parsing operations. Signed-off-by: Kirill Shchetiniuk --- src/qemu/qemu_domain.c | 16 +++- 1 file

[PATCH 3/5] util: virSecretLookupParseSecret refactor

2025-07-07 Thread Kirill Shchetiniuk via Devel
From: Kirill Shchetiniuk Refactored the virSecretLookupParseSecret fucntion to use the virXMLPropUUID fucntion, avoid getting the string and parsing it later. Previously two separate error states merged into one by using boolean NXOR operation. Signed-off-by: Kirill Shchetiniuk --- src/util/vi

[PATCH 2/5] conf: virDomainHostdevSubsysMediatedDevDefParseXML refactor

2025-07-07 Thread Kirill Shchetiniuk via Devel
From: Kirill Shchetiniuk Refactored the virDomainHostdevSubsysMediatedDevDefParseXML function to use virXMLPropUUID fuction instead of getting a string and parsing it later. Due to parsing function change the missing uuid error reporter and message were changed and changed error message was also

[PATCH 1/5] conf: virNetDevVPortProfileParse refactor

2025-07-07 Thread Kirill Shchetiniuk via Devel
From: Kirill Shchetiniuk Refactored the virNetDevVPortProfileParse function to use the appropriate virXMLProp* functions to parse input configuration XML. Signed-off-by: Kirill Shchetiniuk --- src/conf/netdev_vport_profile_conf.c | 120 +++ 1 file changed, 48 insertions

[PATCH 0/5] Some parsing functions refactor

2025-07-07 Thread Kirill Shchetiniuk via Devel
This patch series is supposed to refactor the existing logic of some parsing functions, changing the previous approach of getting the string fisrt and then parsing the string itself. Now the parsing logic is implemented by using the appropriate virXMLProp* functions. In some places the error repor

Re: [PATCH V2 0/5] fast qom tree get

2025-07-07 Thread Steven Sistare via Devel
On 7/4/2025 8:26 AM, Markus Armbruster wrote: Steve Sistare writes: Using qom-list and qom-get to get all the nodes and property values in a QOM tree can take multiple seconds because it requires 1000's of individual QOM requests. Some managers fetch the entire tree or a large subset of it wh

Re: [PATCH v2] qemu: passt: add support for custom command line arguments

2025-07-07 Thread Peter Krempa via Devel
On Mon, Jul 07, 2025 at 15:51:51 +0200, Peter Krempa via Devel wrote: > On Mon, Jul 07, 2025 at 14:52:09 +0200, Enrique Llorente via Devel wrote: One additional thing ... > > @@ -24926,6 +24992,7 @@ virDomainNetBackendFormat(virBuffer *buf, > >virDomainNetBackend *back

Re: [PATCH V2 1/5] qom: qom-tree-get

2025-07-07 Thread Steven Sistare via Devel
On 7/4/2025 8:22 AM, Markus Armbruster wrote: Steve Sistare writes: Define the qom-tree-get QAPI command, which fetches an entire tree of properties and values with a single QAPI call. This is much faster than using qom-list plus qom-get for every node and property of the tree. See qom.json

Re: [PATCH 10/10] virDomainDriverAutoShutdown: Refactor selection logic for VMs

2025-07-07 Thread Peter Krempa via Devel
On Thu, Jul 03, 2025 at 14:50:33 +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > Decide separately and record what shutdown modes are to be applied on > given VM object rather than spreading out the logic through the code. > > This centralization simplifies the conditions in the wo

Re: [PATCH v2] qemu: passt: add support for custom command line arguments

2025-07-07 Thread Peter Krempa via Devel
On Mon, Jul 07, 2025 at 14:52:09 +0200, Enrique Llorente via Devel wrote: > This adds support for custom command line arguments for the passt > backend, similar to qemu:commandline. The feature allows passing > additional arguments to the passt process for development and testing > purposes. > > T

Support cloning of VMs - part 2

2025-07-07 Thread Mark Cave-Ayland
Hi all, I'm currently looking at how libvirt can be used to clone a saved VM, and have been focusing on the previous thread on this topic at https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/YXN2L2PYL4V4576ON5OKQKCV7RCWPSCT/#PJWWXVWIXB3L6DYUZDFW5DWIBFBBW3WS. My understand

Re: [PATCH 0/7] qemu-10.1 test data and dropped machine type cleanups

2025-07-07 Thread Pavel Hrdina via Devel
On Fri, Jul 04, 2025 at 10:51:34AM +0200, Peter Krempa via Devel wrote: > Peter Krempa (7): > qemuxmlconftest: x86_64: Drop explicit use of '2.10' machine type > qemuxmlconftest: x86_64: Drop explicit use of '2.12' machine type > qemuxmlconftest: x86_64: Drop explicit use of '2.5' machine typ

[PATCH v2] qemu: passt: add support for custom command line arguments

2025-07-07 Thread Enrique Llorente via Devel
This adds support for custom command line arguments for the passt backend, similar to qemu:commandline. The feature allows passing additional arguments to the passt process for development and testing purposes. The implementation: - Adds a passt XML namespace for custom arguments - Properly taints

Re: [PATCH v2] nwfilter: Remove 'qemu-announce-self' example

2025-07-07 Thread Daniel P . Berrangé via Devel
On Mon, Jul 07, 2025 at 12:50:53PM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > The example allows packets sent by qemu after migration with broken > protocol ID. The proper self announce is handled via > 'qemu-announce-self-rarp'. > > The qemu bug was addressed by f8778a7785d53

[PATCH v2] nwfilter: Remove 'qemu-announce-self' example

2025-07-07 Thread Peter Krempa via Devel
From: Peter Krempa The example allows packets sent by qemu after migration with broken protocol ID. The proper self announce is handled via 'qemu-announce-self-rarp'. The qemu bug was addressed by f8778a7785d530515b0db39 (released as v0.13.0). As we no longer support such old qemus, and allowing

Re: [PATCH] nwfilter: Remove 'qemu-announce-self' example

2025-07-07 Thread Daniel P . Berrangé via Devel
On Mon, Jul 07, 2025 at 12:16:07PM +0200, Peter Krempa wrote: > On Mon, Jul 07, 2025 at 09:19:56 +0100, Daniel P. Berrangé wrote: > > On Mon, Jul 07, 2025 at 09:03:06AM +0200, Peter Krempa via Devel wrote: > > > From: Peter Krempa > > > > > > The example allows packets sent by qemu after migratio

Re: [PATCH] nwfilter: Remove 'qemu-announce-self' example

2025-07-07 Thread Peter Krempa via Devel
On Mon, Jul 07, 2025 at 09:19:56 +0100, Daniel P. Berrangé wrote: > On Mon, Jul 07, 2025 at 09:03:06AM +0200, Peter Krempa via Devel wrote: > > From: Peter Krempa > > > > The example allows packets sent by qemu after migration with broken > > protocol ID. The proper self announce is handled via >

Re: [PATCH] nwfilter: Remove 'qemu-announce-self' example

2025-07-07 Thread Daniel P . Berrangé via Devel
On Mon, Jul 07, 2025 at 09:03:06AM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > The example allows packets sent by qemu after migration with broken > protocol ID. The proper self announce is handled via > 'qemu-announce-self-rarp'. > > The qemu bug was addressed by f8778a7785d53

Re: [libvirt PATCH] qemu: prefer memfd if we have to format system memory

2025-07-07 Thread Daniel P . Berrangé via Devel
On Fri, Jul 04, 2025 at 07:07:53PM +0200, Ján Tomko via Devel wrote: > From: Ján Tomko > > For any vhost-user device to work, the memory needs to be marked as > shared. > > What we recommend to users (e.g. in the virtiofs quide [0]) is: > > > > > > Technically, only the access m

Re: [PATCH] nwfilter: Remove 'qemu-announce-self' example

2025-07-07 Thread Pavel Hrdina via Devel
On Mon, Jul 07, 2025 at 09:03:06AM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > The example allows packets sent by qemu after migration with broken > protocol ID. The proper self announce is handled via > 'qemu-announce-self-rarp'. > > The qemu bug was addressed by f8778a7785d53

[PATCH] nwfilter: Remove 'qemu-announce-self' example

2025-07-07 Thread Peter Krempa via Devel
From: Peter Krempa The example allows packets sent by qemu after migration with broken protocol ID. The proper self announce is handled via 'qemu-announce-self-rarp'. The qemu bug was addressed by f8778a7785d530515b0db39 (released as v0.13.0). As we no longer support such old qemus, and allowing