Re: [PATCH 2/5] tests: Add firmware-auto-efi-sev-snp

2025-08-12 Thread Jim Fehlig via Devel
On 7/31/25 09:45, Andrea Bolognani via Devel wrote: This test case demonstrates how firmware autoselection doesn't currently work correctly for domains using SEV-SNP: the descriptor for a suitable firmware exists, and yet it doesn't get picked up. On my test system, autoselection for SEV-SNP gu

[PATCH] docs: storage: fix the "since" tag

2025-08-12 Thread Roman Bogorodskiy
Trivial :since: tag fix in the ZFS section. Signed-off-by: Roman Bogorodskiy --- docs/storage.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/storage.rst b/docs/storage.rst index 344d3a32f8..b77e7ef144 100644 --- a/docs/storage.rst +++ b/docs/storage.rst @@ -719,7 +7

Re: [PATCH v2 0/4] bhyve: implement domain{Block,Interface,Memory}Stats

2025-08-12 Thread Roman Bogorodskiy
Roman Bogorodskiy wrote: > Changes since v1: > > - Added "bhyve: implement domainInterfaceStats" patch > > PS It was temping to factor out obtaining struct kinfo_proc using > sysctlnametomib() + sysctl(), but I have to make it visible to use > outside of virprocess, e.g. in bhyve_driver.c, so

Re: [PATCH] docs: kbase/tlscerts: mention dropped 'encryption_key'

2025-08-12 Thread Daniel P . Berrangé via Devel
On Mon, Aug 04, 2025 at 06:31:14PM +0200, Sebastian Mitterle via Devel wrote: > Older libvirt versions still only work if 'encryption_key' is enabled > in the server and client certificates. Add a note. > > While at it, also add a note that after setting the certificates up, > the TLS ports need t

[PATCH v3 2/2] tests/qemuxmlconfdata: add tests for video model 'edid' attribute

2025-08-12 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Krempa --- .../video-bochs-edid-none.x86_64-latest.args | 34 +++ .../video-bochs-edid-none.x86_64-latest.xml | 41 +++ .../qemuxmlconfdata/video-bochs-edid-none.xml | 30 ++ .../video-bochs-edid-off.x8

Re: [RFC] x86 Host CPU features detection by MSRs

2025-08-12 Thread Hector Cao
Hello Andrea, Daniel, I would like to understand how we can give some momentum to this topic, @Daniel P. Berrangé : Are you still convinced that libvirt should only deploy the modules-load.d file as part of the installation ? If we take this route, one solution to work-around the reboot need is

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-12 Thread Andrea Bolognani via Devel
On Tue, Aug 05, 2025 at 12:56:56PM +0200, Gerd Hoffmann wrote: > > Assuming that > > > > * the need to use -bios for SEV-SNP is intended; > > Yes. SEV-SNP (and TDX too) are by design incompatible with pflash > emulation. Both do not allow the host change guest memory layout > after launch, and

Re: [PATCHv2] passt: Define backend hostname and fqdn

2025-08-12 Thread Laine Stump via Devel
Sorry again for taking so long to respond to this - it's turned into a ridiculous mental block for me for really unexplainable reasons... On 5/30/25 8:21 AM, Enrique Llorente via Devel wrote: This commit introduces a feature enhancement for configuring hostnames in virtual machines (VMs) using

Re: [PATCH] docs: kbase/tlscerts: mention dropped 'encryption_key'

2025-08-12 Thread Daniel P . Berrangé via Devel
On Wed, Aug 06, 2025 at 12:39:34PM +0200, Sebastian Mitterle wrote: > On Tue, Aug 5, 2025 at 1:54 PM Daniel P. Berrangé wrote: > > > > On Mon, Aug 04, 2025 at 06:31:14PM +0200, Sebastian Mitterle via Devel > > wrote: > > > Older libvirt versions still only work if 'encryption_key' is enabled > >

[PATCH 1/4] qemu: introduce mshv capabilities

2025-08-12 Thread Praveen K Paladugu
From: Praveen K Paladugu Qemu with mshv capabilities can launch domains of type hyperv. Signed-off-by: Praveen K Paladugu Signed-off-by: Praveen K Paladugu --- src/qemu/qemu_capabilities.c | 40 +--- src/qemu/qemu_capabilities.h | 1 + 2 files changed, 38 inse

[PATCH v3 1/2] conf: add support for 'edid' attribute to video model

2025-08-12 Thread Mark Cave-Ayland
Add the ability to enable/disable exposing the EDID information to the guest. The edid attribute can specified in the domain XML as below: If the edid attribute is unspecified, it is not generated so that the virtualisation platform will continue to use its default. The edid a

Re: [PATCH] docs: kbase/tlscerts: mention dropped 'encryption_key'

2025-08-12 Thread Sebastian Mitterle via Devel
On Tue, Aug 5, 2025 at 1:54 PM Daniel P. Berrangé wrote: > > On Mon, Aug 04, 2025 at 06:31:14PM +0200, Sebastian Mitterle via Devel wrote: > > Older libvirt versions still only work if 'encryption_key' is enabled > > in the server and client certificates. Add a note. > > > > While at it, also add

Re: [PATCH v2 1/2] conf: add support for 'edid' attribute to video model

2025-08-12 Thread Peter Krempa via Devel
On Mon, Aug 04, 2025 at 15:07:19 +0100, Mark Cave-Ayland wrote: > Add the ability to enable/disable exposing the EDID information to the guest. > The edid attribute can specified in the domain XML as below: > > > > > > If the edid attribute is unspecified, it is not generated s

[PATCH v5 0/6] qemu: acpi-generic-initiator support

2025-08-12 Thread Andrea Righi via Devel
= Overview = This patch set introduces support for acpi-generic-initiator devices, supported by QEMU [1]. The acpi-generic-initiator object is required to support Multi-Instance GPU (MIG) configurations on NVIDIA GPUs [2]. MIG enables partitioning of GPU resources into multiple isolated instances

Re: [PATCH v2 2/2] tests/qemuxmlconfdata: add tests for video model 'edid' attribute

2025-08-12 Thread Peter Krempa via Devel
On Mon, Aug 04, 2025 at 15:07:20 +0100, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland > --- [...] > diff --git a/tests/qemuxmlconfdata/video-virtio-edid-on.xml > b/tests/qemuxmlconfdata/video-virtio-edid-on.xml > new file mode 100644 > index 00..adf8580b17 > --- /dev/null >

[PATCH 5/6] qemu: Support acpi-generic-initiator

2025-08-12 Thread Andrea Righi via Devel
Add support to the qemu driver to generate the proper command line for the acpi-generic-initiator definitions. Signed-off-by: Andrea Righi --- src/qemu/qemu_command.c | 30 +++ .../acpi-generic-initiator.x86_64-latest.args | 8 + 2 files changed, 38 ins

[PATCH v1 1/2] docs/tlscerts: document need for socket activation

2025-08-12 Thread Sebastian Mitterle via Devel
Mention that the tls socket needs to be started and the libvirtd or virtproxyd service might have to be started. If this is not done the user might run into connection issues and it seems this is not mentioned elsewhere in the docs. Suggested-by: Daniel P. Berrangé Signed-off-by: Sebastian Mitte

[PATCH 4/6] qemu_validate: Validate acpi-generic-initiator

2025-08-12 Thread Andrea Righi via Devel
From: Michal Privoznik Signed-off-by: Michal Privoznik --- src/qemu/qemu_validate.c | 17 + 1 file changed, 17 insertions(+) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 5ead231dd0..0aaf40f971 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_v

Re: [PATCH] qemu: don't warn about missing SMM for CVM firmware

2025-08-12 Thread Ján Tomko via Devel
On a Thursday in 2025, Daniel P. Berrangé via Devel wrote: From: Daniel P. Berrangé Neither Intel TDX / AMD SEV(SNP) allow use of SMM, but the EDK2 firmware none the less supports secureboot. Libvirt currently issues bogus warnings about Fedora firmware warning : qemuFirmwareSanityCheck:1575

[PATCH 3/6] qemu: capabilies: Introduce QEMU_CAPS_ACPI_GENERIC_INITIATOR

2025-08-12 Thread Andrea Righi via Devel
This capability tracks whether QEMU supports the acpi-generic-initiator object type. This object has been introduced in QEMU with the commit: b64b7ed8bb ("qom: new object to associate device to NUMA node"). Signed-off-by: Andrea Righi --- src/qemu/qemu_capabilities.c

Re: [PATCH] qemu: don't warn about missing SMM for CVM firmware

2025-08-12 Thread Daniel P . Berrangé via Devel
On Tue, Aug 05, 2025 at 08:54:02AM -0500, Andrea Bolognani wrote: > On Thu, Jul 31, 2025 at 07:33:21PM +0100, Daniel P. Berrangé via Devel wrote: > > +++ b/src/qemu/qemu_firmware.c > > @@ -1540,6 +1540,7 @@ qemuFirmwareSanityCheck(const qemuFirmware *fw, > > bool requiresSMM = false; > >

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-12 Thread Gerd Hoffmann via Devel
> [adding Daniel to CC] > > Daniel suggested that elsewhere in the thread and of course it's an > > appealing proposition, as it would keep complexity down and unify > > handling across CVM use cases. > > > > However I wonder if changing things would break migration for > > existing SEV(-ES) guest

[PATCH 3/4] qemu: use mshv accel for hyperv domains

2025-08-12 Thread Praveen K Paladugu
From: Praveen K Paladugu Add mshv acceleration (-accel mshv) flag to hyperv domains Signed-off-by: Praveen K Paladugu Signed-off-by: Praveen K Paladugu --- src/qemu/qemu_command.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_co

[PATCH 6/6] NEWS: Mention new acpi-generic-initiator device

2025-08-12 Thread Andrea Righi via Devel
Signed-off-by: Andrea Righi --- NEWS.rst | 8 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 435760e797..36388a736b 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,14 @@ v11.7.0 (unreleased) * **New features** + * qemu: Introduce acpi-generic-initiator de

Re: [PATCH] Storage: ZFS: implement `resizeVol` method to support native resize

2025-08-12 Thread Daniel P . Berrangé via Devel
On Thu, Jul 24, 2025 at 05:34:03PM +0300, George Melikov wrote: > From: George Melikov > > ZFS doesn't have thick allocations, every allocation is > thin-provisioned, so resize operation is essentially > a zvol size limit change > (`zfs set volsize=X pool/zvol_name`). > > Shrink is allowed too (

Re: [PATCH 0/5] Cleanup of callers of virDomainDefGetVcpu

2025-08-12 Thread Ján Tomko via Devel
On a Thursday in 2025, Peter Krempa via Devel wrote: Fix few issues with how virDomainDefGetVcpu is called and in related code. Peter Krempa (5): Unexport virCHProcessSetupVcpu virDomainVcpuDefPostParse: Remove impossible check qemu: domain: Remove unused qemuDomainGetVcpuHalted virCHDomainR

Re: [PATCH v2 2/2] tests/qemuxmlconfdata: add tests for video model 'edid' attribute

2025-08-12 Thread Mark Cave-Ayland
On 06/08/2025 15:21, Peter Krempa wrote: On Mon, Aug 04, 2025 at 15:07:20 +0100, Mark Cave-Ayland wrote: Signed-off-by: Mark Cave-Ayland --- [...] diff --git a/tests/qemuxmlconfdata/video-virtio-edid-on.xml b/tests/qemuxmlconfdata/video-virtio-edid-on.xml new file mode 100644 index 00

Re: [PATCH 1/5] tests: Tweak descriptor for combined firmware

2025-08-12 Thread Jim Fehlig via Devel
On 7/31/25 09:45, Andrea Bolognani via Devel wrote: This kind of firmware build is not shipped in Fedora, where most descriptors in our test suite come from, so we had to make it up. It was based off the Secure Boot-enabled edk2 build, and the filename it points to is the same. That has been fin

[PATCH 2/4] qemu: probe mshv capabilities

2025-08-12 Thread Praveen K Paladugu
From: Praveen K Paladugu Probe mshv capabilities from qemu with QMP commands. Signed-off-by: Praveen K Paladugu Signed-off-by: Praveen K Paladugu --- src/qemu/qemu_capabilities.c | 31 --- src/qemu/qemu_monitor.c | 9 + src/qemu/qemu_monitor.h |

[PATCH 1/6] conf: Introduce acpi-generic-initiator device

2025-08-12 Thread Andrea Righi via Devel
Introduce apci-generic-initiator device to the domain XML. Example definition: dev0 1 This enables partitioning of PCI resources into multiple isolated instances, each requiring a dedicated NUMA node definition, that can be represented by the acpi-generic-initiator object. Link: h

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-12 Thread Daniel P . Berrangé via Devel
On Mon, Aug 04, 2025 at 02:15:01PM -0600, Jim Fehlig wrote: > On 8/4/25 05:31, Andrea Bolognani wrote: > > On Fri, Aug 01, 2025 at 11:39:45AM -0600, Jim Fehlig via Devel wrote: > > > With this addition, the correct firmware is detected, but it's not > > > properly > > > provided to qemu > > > > >

Re: [PATCH v2 1/2] conf: add support for 'edid' attribute to video model

2025-08-12 Thread Mark Cave-Ayland
On 06/08/2025 15:10, Peter Krempa wrote: On Mon, Aug 04, 2025 at 15:07:19 +0100, Mark Cave-Ayland wrote: Add the ability to enable/disable exposing the EDID information to the guest. The edid attribute can specified in the domain XML as below: If the edid attribute is un

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-12 Thread Jim Fehlig via Devel
On 8/5/25 07:02, Gerd Hoffmann wrote: [adding Daniel to CC] Daniel suggested that elsewhere in the thread and of course it's an appealing proposition, as it would keep complexity down and unify handling across CVM use cases. However I wonder if changing things would break migration for existi

Re: [PATCH] qemu: don't warn about missing SMM for CVM firmware

2025-08-12 Thread Andrea Bolognani via Devel
On Tue, Aug 05, 2025 at 04:28:18PM +0100, Daniel P. Berrangé wrote: > On Tue, Aug 05, 2025 at 08:54:02AM -0500, Andrea Bolognani wrote: > > On Thu, Jul 31, 2025 at 07:33:21PM +0100, Daniel P. Berrangé via Devel > > wrote: > > > +++ b/src/qemu/qemu_firmware.c > > > @@ -1540,6 +1540,7 @@ qemuFirmwar

[PATCH v1 0/2] docs/tlscerts: minor improvements for TLS setup

2025-08-12 Thread Sebastian Mitterle via Devel
Two minor improvements for the TLS setup documentation. Sebastian Mitterle (2): docs/tlscerts: document need for socket activation docs/tlscerts: mention dropped 'encryption_key' docs/kbase/tlscerts.rst | 42 + 1 file changed, 38 insertions(+), 4 delet

[PATCH v1 2/2] docs/tlscerts: mention dropped 'encryption_key'

2025-08-12 Thread Sebastian Mitterle via Devel
Older libvirt versions still only work if 'encryption_key' is enabled in the server and client certificates. Add a note. Suggested-by: Daniel P. Berrangé Signed-off-by: Sebastian Mitterle --- docs/kbase/tlscerts.rst | 12 1 file changed, 12 insertions(+) diff --git a/docs/kbase/tl

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-12 Thread Gerd Hoffmann via Devel
Hi, > Assuming that > > * the need to use -bios for SEV-SNP is intended; Yes. SEV-SNP (and TDX too) are by design incompatible with pflash emulation. Both do not allow the host change guest memory layout after launch, and pflash needs to do that to switch between reading mode and programmi

[PATCH v3 0/2] conf: add support for 'edid' attribute to video model

2025-08-12 Thread Mark Cave-Ayland
This series adds support for a new 'edid' attribute to the video model to control whether the EDID is visible to the guest. If the 'edid' attribute is unspecified then it is not generated in the domain XML, so the underlying virtualisation platform will continue to use its default. The 'edid' att

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-12 Thread Daniel P . Berrangé via Devel
On Tue, Aug 05, 2025 at 01:18:12AM -0700, Andrea Bolognani wrote: > On Tue, Aug 05, 2025 at 08:08:14AM +0100, Daniel P. Berrangé wrote: > > On Mon, Aug 04, 2025 at 02:15:01PM -0600, Jim Fehlig wrote: > > > On 8/4/25 05:31, Andrea Bolognani wrote: > > > > On Fri, Aug 01, 2025 at 11:39:45AM -0600, Ji

[PATCH 0/4] Enable mshv support for Qemu domains

2025-08-12 Thread Praveen K Paladugu
"[PATCH v3 00/26] Implementing a MSHV (Microsoft Hypervisor) accelerator" patchset in qemu-devel mailing list introduces MSHV support within Qemu. With above patchset, Qemu guests can be started with `-accel mshv` option to use Microsoft Hypervisor (/dev/mshv) as the hypervisor. Retaining Libvirt'

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-12 Thread Andrea Bolognani via Devel
On Tue, Aug 05, 2025 at 08:08:14AM +0100, Daniel P. Berrangé wrote: > On Mon, Aug 04, 2025 at 02:15:01PM -0600, Jim Fehlig wrote: > > On 8/4/25 05:31, Andrea Bolognani wrote: > > > On Fri, Aug 01, 2025 at 11:39:45AM -0600, Jim Fehlig via Devel wrote: > > > > With this addition, the correct firmware

Re: [PATCH 0/2] qemu: Match firmware with fully resolved and canonicalized paths

2025-08-12 Thread Ján Tomko via Devel
On a Friday in 2025, Michal Privoznik via Devel wrote: As promised, this is a resend of previous patches: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/XVHIWFXSF5NOPUL4LTU7IGXZWTH43BBC/ Diff to v1: - new patch 1/2 which fixes the mocking. James Le Cuirot (1): qemu: Ma

Re: [PATCH] qemu: don't warn about missing SMM for CVM firmware

2025-08-12 Thread Andrea Bolognani via Devel
On Thu, Jul 31, 2025 at 07:33:21PM +0100, Daniel P. Berrangé via Devel wrote: > +++ b/src/qemu/qemu_firmware.c > @@ -1540,6 +1540,7 @@ qemuFirmwareSanityCheck(const qemuFirmware *fw, > bool requiresSMM = false; > bool supportsSecureBoot = false; > bool hasEnrolledKeys = false; > +

Re: [PATCH 3/5] qemu: domain: Remove unused qemuDomainGetVcpuHalted

2025-08-12 Thread Ján Tomko via Devel
On a Thursday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 15 --- src/qemu/qemu_domain.h | 1 - 2 files changed, 16 deletions(-) Unused since: commit 548b1e55257dc8806abdbefa71a87b22dea1 diff --git a/src

[PATCH 4/4] qemu_cgroup: add /dev/mshv to default devices

2025-08-12 Thread Praveen K Paladugu
From: Praveen K Paladugu Add /dev/mshv to default set of devices to pass to domain cgroup. Signed-off-by: Praveen K Paladugu Signed-off-by: Praveen K Paladugu --- src/qemu/qemu_cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-12 Thread Andrea Bolognani via Devel
[adding Daniel to CC] On Tue, Aug 05, 2025 at 05:17:14AM -0700, Andrea Bolognani wrote: > On Tue, Aug 05, 2025 at 12:56:56PM +0200, Gerd Hoffmann wrote: > > > Assuming that > > > > > > * the need to use -bios for SEV-SNP is intended; > > > > Yes. SEV-SNP (and TDX too) are by design incompatible

[PATCH 2/6] qemu: Allow to define NUMA nodes without memory or CPUs assigned

2025-08-12 Thread Andrea Righi via Devel
Allow to define NUMA nodes without memory or CPUs assigned to properly support the new acpi-generic-initiator device. This is required because the NUMA nodes passed to the acpi-generic-initiator object must be independent and not be shared with other resources, such as CPU or memory. Signed-off-b