Re: [PATCH v4 07/10] qmp: add chardev-resize command

2025-09-17 Thread Markus Armbruster via Devel
Cc: libvirt Filip Hejsek writes: > From: Szymon Lukasz > > The managment software can use this command to notify QEMU about the > size of the terminal connected to a chardev, QEMU can then forward this > information to the guest if the chardev is connected to a virtio console > device. > > Sign

Re: [PATCH v3 0/7] USB hostdev: allow addressing by port

2025-09-17 Thread Maximilian Martin via Devel
Ping :) Let me know if there is anything I can do to make this feature finally come to life. Am 04.09.2025 um 22:11 schrieb Maximilian Martin: Ping Am 18.08.25, 16:40 schrieb Maximilian Martin via Devel http://lists.libvirt.org>>: Currently, only vendor/product and bus/device matchin

Re: [PATCH 7/8] docs: Document acpi nodeset in hostdev

2025-09-17 Thread Daniel P . Berrangé via Devel
On Sat, Sep 06, 2025 at 03:09:02PM +0200, Andrea Righi wrote: > Add documentation for the new element in hostdev, > which allows associating devices with ACPI Generic Initiator objects in > QEMU. > > A typical use case is NVIDIA Multi-Instance GPU (MIG), where a physical > GPU is partitioned into

Re: [PATCH 08/31] tests: Fix some usb-controller-*-unavailable cases

2025-09-17 Thread Peter Krempa via Devel
On Tue, Aug 19, 2025 at 18:22:12 +0200, Andrea Bolognani via Devel wrote: > These tests are intended to show what happens when the device > that libvirt would use by default is not available in QEMU by > dropping the corresponding capabilities, but we're not doing > that correctly at the moment and

Re: [PATCH] esx: Satisfy curl type checks

2025-09-17 Thread Ján Tomko via Devel
On a Monday in 2025, Michal Privoznik via Devel wrote: From: Michal Privoznik Since its commit [1] curl now performs type checks on curl_easy_setopt(). Some options expect long but we're passing an int. The fix consists mostly of specifying type of numbers passed to the function. Except for two

[PATCH v2 1/1] x86: install modules-load.d file to load msr module

2025-09-17 Thread Hector Cao
On recent Intel CPUs, some of the CPU features (e.g. vmx-* sub-features) are listed and controlled via the MSRs (Model Specific Registers) instead of the traditional CPUID instruction method. To be able to read the MSR's values, the kernel module msr has to be loaded and the values can be read via

[PATCH v2 0/1] x86: install modules-load.d file to load msr module

2025-09-17 Thread Hector Cao
This submission is a follow-up (v2) of the discussion (RFC) that was happening at: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/ADJ4A... On x86, libvirt makes use of the API exposed by the msr kernel module to read the MSR (Model Specific Registers) values. On some Linu

Re: [PATCH v3 09/13] ch: assign aliases in ProcessPrepareDomain

2025-09-17 Thread Michal Prívozník via Devel
On 9/4/25 14:10, Stefan Kober wrote: > This is required to have unique device aliases for devices throughout > the domain lifecycle. > > On-behalf-of: SAP stefan.ko...@sap.com > Signed-off-by: Stefan Kober > --- > src/ch/ch_process.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/

[PATCH 4/6] qemuMigrationSrcIsSafeDisk: Check also data file propertiues for migrability

2025-09-17 Thread Peter Krempa via Devel
From: Peter Krempa If the qcow2 data file feature (which separates the data into a separate file from the metadata) is in use the migration safety check ought co consider both the metadata and the data file for safe migration. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 6 +

[PATCH v3 9/9] DONOTMERGE don't explicitly request stateless firmware for SEV

2025-09-17 Thread Andrea Bolognani via Devel
Thanks to the recent changes in the firmware autoselection algorithm as well as the descriptors being tweaked, the correct firmware gets picked up automatically without having to provide this hint. --- ...-security-sev-missing-platform-info.x86_64-latest+amdsev.xml | 2 +- .../launch-security-sev-

Re: [PATCH 5/8] qemu: Generate acpi-generic-initiator command from acpi nodeset

2025-09-17 Thread Daniel P . Berrangé via Devel
On Sat, Sep 06, 2025 at 03:09:00PM +0200, Andrea Righi wrote: > Signed-off-by: Andrea Righi > --- > src/qemu/qemu_command.c | 45 + > 1 file changed, 45 insertions(+) Reviewed-by: Daniel P. Berrangé > > diff --git a/src/qemu/qemu_command.c b/src/qemu/qe

Re: [PATCH 00/14] qemu: Optimize guest CPU probing

2025-09-17 Thread Ján Tomko via Devel
On a Thursday in 2025, Jiri Denemark via Devel wrote: When a domain starts we need to check what CPU features were enabled and if any of the features we asked for were disabled. Currently this requires more than 470 QMP commands (and the number is growing everytime QEMU adds a new feature or othe

[PATCH 6/6] qemuMigrationSrcIsSafeDisk: Allow non-shared qcow2's with raw data file

2025-09-17 Thread Peter Krempa via Devel
From: Peter Krempa A qcow2 image which uses a data file and the 'data_file_raw' flag is effectively a raw image with the qcow2 wrapper used only to store metadata (block dirty bitmaps). Since the dirty bitmaps are always migrated using the migration stream it's technically not required that the

Re: [PATCH v3 4/9] tests: Add tests for SEV firmware selection

2025-09-17 Thread Jim Fehlig via Devel
On 9/12/25 00:58, Andrea Bolognani wrote: On Thu, Sep 11, 2025 at 12:54:25PM -0600, Jim Fehlig wrote: On 9/11/25 01:38, Andrea Bolognani wrote: If you want, I can add a comment along the lines of /* This succeeds, but the selected firmware is not the one * we want */ to qemuxmlconfte

[PATCH v3 0/2] Introduce virDomainBlockRebaseParams API

2025-09-17 Thread Nikolai Barybin via Devel
Changes since last revision: - Renamed API function name Nikolai Barybin (2): api: remote: introduce virDomainBlockRebaseParams API qemu: implement driver support for domainBlockRebaseParams API include/libvirt/libvirt-domain.h | 43 + src/driver-hypervisor.h |

Re: [PATCH 02/14] tests: Add a test for qemuMonitorJSONGetGuestCPU

2025-09-17 Thread Peter Krempa via Devel
On Thu, Sep 04, 2025 at 16:46:50 +0200, Jiri Denemark via Devel wrote: > From: Jiri Denemark > > The SierraForest CPU was just randomly chosen and it doesn't mean we > should have test cases for all CPU models. > > Signed-off-by: Jiri Denemark > --- > .../get-guest-cpu-SierraForest-disabled.xm

[PATCH] libvirt-host: VIR_NODE_CPU_STATS: clarify Linux, BSD differences

2025-09-17 Thread Claudio Fontana
the accounting choices are not necessarily intuitive, especially comparing Linux with BSD, so clarify the current state of things. Mark which counters are actually used on Linux and BSD, and how they are accumulated into the libvirt statistics. Signed-off-by: Claudio Fontana --- include/libvirt

Re: [PATCH v4 07/10] qmp: add chardev-resize command

2025-09-17 Thread Markus Armbruster via Devel
Filip Hejsek writes: > On Tue, 2025-09-16 at 15:07 +0200, Markus Armbruster wrote: >> Filip Hejsek writes: >> >> > On Mon, 2025-09-15 at 08:35 +0200, Markus Armbruster wrote: >> > > Filip Hejsek writes: >> > > >> > > > On Fri, 2025-09-12 at 16:01 +0200, Markus Armbruster wrote: >> > > > > Cc: