On Thu, Sep 18, 2025 at 02:53:00PM +0200, Peter Krempa wrote:
> On Tue, Aug 19, 2025 at 18:22:19 +0200, Andrea Bolognani via Devel wrote:
> > @@ -2843,10 +2844,17 @@ qemuDomainAssignPCIAddresses(virDomainDef *def,
> > g_clear_pointer(&addrs, virDomainPCIAddressSetFree);
> > }
> >
> >
On Thu, Sep 18, 2025 at 03:15:25PM +0200, Peter Krempa wrote:
> On Tue, Aug 19, 2025 at 18:22:24 +0200, Andrea Bolognani via Devel wrote:
> > +++ b/tests/qemuhotplugtestdomains/qemuhotplug-base-ccw-live+ccw-virtio.xml
> > @@ -29,11 +29,8 @@
> >
> >
> >
> > -
> > +
> >
This change fixes an issue with virtio console port assignment on virtio-serial
buses.
Currently, when trying to autoassign a virtio console device, the device cannot
be
assigned to a port greater than 0 on virtio-serial buses.
You will receive the following error:
`virtio-serial-bus: A port alr
Add test coverage for multiple virtio consoles on a virtio-serial controller.
This test makes sure that multiple virtconsoles get auto-assigned appropriate
port numbers on a virtio-serial-bus.
Reviewed-by: Peter Krempa
Signed-off-by: Aaron M. Brown
---
...rial-autoassign-address.x86_64-latest.a
Rename variable "allowZero" to "allowPortZero" for clarity and update the
virtconsole port reservation comment,
as port 0 is reserved for the first virtconsole unless specified.
Signed-off-by: Aaron M. Brown
---
src/conf/domain_addr.c | 26 +-
1 file changed, 13 insertio
Changelog:
---
v7:
- Removed some unnecessary definitions from test xml
- Moved edge case reservation logic to virDomainVirtioSerialAddrAssign
---
v6:
- Fixed issue with console auto port index starting from 1 instead of 0
---
v5:
- Added xml tests to tests/qemuxmlconfdata
- Fixed virito -> v
On Fri, Sep 19, 2025 at 08:21:50 -0500, Andrea Bolognani wrote:
> On Thu, Sep 18, 2025 at 02:53:00PM +0200, Peter Krempa wrote:
> > On Tue, Aug 19, 2025 at 18:22:19 +0200, Andrea Bolognani via Devel wrote:
> > > @@ -2843,10 +2844,17 @@ qemuDomainAssignPCIAddresses(virDomainDef *def,
> > >
On Fri, Sep 19, 2025 at 08:28:38 -0500, Andrea Bolognani wrote:
> On Thu, Sep 18, 2025 at 03:04:28PM +0200, Peter Krempa wrote:
> > On Tue, Aug 19, 2025 at 18:22:22 +0200, Andrea Bolognani via Devel wrote:
> > > +/* Sanity check. If the machine type supports PCI, we need to reflect
> > > +
On Fri, Sep 19, 2025 at 04:31:07PM +0200, Peter Krempa wrote:
> On Fri, Sep 19, 2025 at 07:26:21 -0700, Andrea Bolognani wrote:
> > Yes, this commit is intended to merely factor out the existing code
> > into a dedicated helper, without altering the behavior. Then later
> > commits perform the modi
On Fri, Sep 19, 2025 at 08:10:41 -0700, Andrea Bolognani wrote:
> On Fri, Sep 19, 2025 at 11:23:14AM +0200, Peter Krempa wrote:
> > On Tue, Aug 19, 2025 at 18:22:31 +0200, Andrea Bolognani via Devel wrote:
> > > +if (ARCH_IS_LOONGARCH(def->os.arch) ||
> > > +qemuDomainIsRISCVVirt(def))
On Fri, Sep 19, 2025 at 07:00:17PM +0200, Peter Krempa wrote:
> On Fri, Sep 19, 2025 at 10:34:39 -0500, Andrea Bolognani wrote:
> > On Fri, Sep 19, 2025 at 11:39:05AM +0200, Peter Krempa wrote:
> > > On Tue, Aug 19, 2025 at 18:22:34 +0200, Andrea Bolognani via Devel wrote:
> > > > +++
> > > > b/te
On Fri, Sep 19, 2025 at 10:34:39 -0500, Andrea Bolognani wrote:
> On Fri, Sep 19, 2025 at 11:39:05AM +0200, Peter Krempa wrote:
> > On Tue, Aug 19, 2025 at 18:22:34 +0200, Andrea Bolognani via Devel wrote:
> > > +++ b/tests/qemuxmlconfdata/armv7l-versatilepb-minimal.armv7l-latest.args
> > > @@ -26,
On Fri, Sep 19, 2025 at 04:28:03PM +0200, Peter Krempa wrote:
> On Fri, Sep 19, 2025 at 08:28:38 -0500, Andrea Bolognani wrote:
> > On Thu, Sep 18, 2025 at 03:04:28PM +0200, Peter Krempa wrote:
> > > On Tue, Aug 19, 2025 at 18:22:22 +0200, Andrea Bolognani via Devel wrote:
> > > > +/* Sanity ch
On Fri, Sep 19, 2025 at 11:39:05AM +0200, Peter Krempa wrote:
> On Tue, Aug 19, 2025 at 18:22:34 +0200, Andrea Bolognani via Devel wrote:
> > +++ b/tests/qemuxmlconfdata/armv7l-versatilepb-minimal.armv7l-latest.args
> > @@ -26,7 +26,7 @@
> > XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-armv7lte
On Fri, Sep 19, 2025 at 11:27:06AM +0200, Peter Krempa wrote:
> On Tue, Aug 19, 2025 at 18:22:33 +0200, Andrea Bolognani via Devel wrote:
> > if (ARCH_IS_LOONGARCH(def->os.arch) ||
> > +qemuDomainIsARMVirt(def) ||
> > qemuDomainIsRISCVVirt(def)) {
> > /* Use USB3 for
On Fri, Sep 19, 2025 at 11:23:14AM +0200, Peter Krempa wrote:
> On Tue, Aug 19, 2025 at 18:22:31 +0200, Andrea Bolognani via Devel wrote:
> > +if (ARCH_IS_LOONGARCH(def->os.arch) ||
> > +qemuDomainIsRISCVVirt(def)) {
> > /* Use qemu-xhci (USB3) for modern architectures */
> >
We are getting close to 11.8.0 release of libvirt. To aim for the
release on Wednesday 01 Oct I suggest entering the freeze on Thursday 25
Sep and tagging RC2 on Monday 29 Sep.
I hope this works for everyone.
Jirka
On Thu, Sep 18, 2025 at 03:04:28PM +0200, Peter Krempa wrote:
> On Tue, Aug 19, 2025 at 18:22:22 +0200, Andrea Bolognani via Devel wrote:
> > +/* Sanity check. If the machine type supports PCI, we need to reflect
> > + * that fact in the XML or other parts of the machine handling code
> > +
On Fri, Sep 19, 2025 at 17:09:07 +0800, yong.hu...@smartx.com wrote:
> From: Hyman Huang
>
> When saving the domain status in the path of the virDomainObjSave
> function, Libvirtd will omit the private data if the format
> interface is not provided.
>
> When the Libvirtd service is starting up a
On Thu, Sep 04, 2025 at 16:46:51 +0200, Jiri Denemark via Devel wrote:
> From: Jiri Denemark
>
> The key point here is that the unavailable-features property reports an
> empty array.
>
> Signed-off-by: Jiri Denemark
> ---
> .../get-guest-cpu-SkylakeClient-disabled.xml |2 +
> .../get-gue
On 9/9/25 09:25, stefan.ko...@cyberus-technology.de wrote:
> Thanks for merging and taking care of the finishing touches!
Glad to help. We have some specifics when it comes to structuring
patches and code style. Nobody gets it right the first time :-D
> And thanks for still leaving comments abou
On Fri, Sep 19, 2025 at 17:09:08 +0800, yong.hu...@smartx.com wrote:
> From: Hyman Huang
>
> Add a thorough check in the virDomainObjSave path to make sure that
> private data in the status XML file always exists for the running VM
> so that we won't lose them after restart the service.
> ---
>
From: Hyman Huang
Add a thorough check in the virDomainObjSave path to make sure that
private data in the status XML file always exists for the running VM
so that we won't lose them after restart the service.
---
src/conf/domain_conf.c | 21 ++---
1 file changed, 18 insertions(+)
On Tue, Aug 19, 2025 at 18:22:31 +0200, Andrea Bolognani via Devel wrote:
> Currently we fall back to the x86-derived default of piix3-uhci,
> which is a USB1 controller that's not virtualization-friendly
> and overall a terrible choice for a modern architecture. The
> fact that we didn't choose a
On Tue, Aug 19, 2025 at 18:22:34 +0200, Andrea Bolognani via Devel wrote:
> At this point the USB controller model selection logic is
> mostly sane, but there are still a few remaining oddities.
>
> First of all, piix3-uhci (USB1) is used in way too many
> contexts, either as default or fallback c
From: Hyman Huang
When saving the domain status in the path of the virDomainObjSave
function, Libvirtd will omit the private data if the format
interface is not provided.
When the Libvirtd service is starting up and the driver has not
yet been initialized, this behavior is justified.
However, w
On Tue, Aug 19, 2025 at 18:22:33 +0200, Andrea Bolognani via Devel wrote:
> This is another case where the current behavior can be traced
> back to the fact that x86 was the only architecture to really
> be taken into account for a long time: in reality, using an
> Intel-specific USB1 controller fo
On Tue, Aug 19, 2025 at 18:22:32 +0200, Andrea Bolognani via Devel wrote:
> Since these architectures were introduced when qemu-xhci was
> already a thing, we never considered allowing the older
> nec-xhci model as a fallback.
>
> That said, every other architecture that defaults to USB3
> allows
On 9/10/25 07:57, Andrea Bolognani via Devel wrote:
Signed-off-by: Andrea Bolognani
---
NEWS.rst | 5 +
1 file changed, 5 insertions(+)
Reviewed-by: Jim Fehlig
Regards,
Jim
On Thu, Sep 04, 2025 at 16:47:02 +0200, Jiri Denemark via Devel wrote:
> From: Jiri Denemark
>
> With qom-list-get we already have the value of unavailable-features
> property in the returned object (just like we have all values of all
> bool properties). Let's use the value from there instead of
On Tue, Aug 19, 2025 at 18:22:30 +0200, Andrea Bolognani via Devel wrote:
> As well as qemuDomainDefaultUSBControllerModelAutoAdded().
Either split the patch or mention both in the summary.
>
> Switch from the current approach, in which an initial (poor)
> default is picked and then a better one
31 matches
Mail list logo
