[PATCH v2] virsh: Provide completer for some pool-X-as commands

Provides completers for auth-type and source-format commands for virsh pool-create-as and pool-define-as commands. Use Empty completers for options where completions are not required. Related Issue: https://gitlab.com/libvirt/libvirt/-/issues/9 Signed-off-by: Abhiram Tilak --- Changes in v2

[PATCH] virsh: Provide completer for some pool-X-as commands

/-/issues/9 Signed-off-by: Abhiram Tilak --- src/libvirt_private.syms | 2 ++ tools/virsh-completer-pool.c | 48 +++- tools/virsh-completer-pool.h | 10 tools/virsh-pool.c | 8 ++ 4 files changed, 67 insertions(+), 1 deletion(-) diff

[PATCH v4] network: add modify-or-add feature to net-update

state. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/363 Signed-off-by: Abhiram Tilak --- Changes in v4: - Fix the variable name mistake `foundEntry` to `foundMatchedEntry` - Fix the `ip`, not being declared or assigned in required location. Changes in v3: - Changed the indexes used

[PATCH v3] network: add modify-or-add feature to net-update

state. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/363 Signed-off-by: Abhiram Tilak --- Changes in v3: - Changed the indexes used to delete or modify instead of `i`. Changes in v2: - Removed the modify-or-add functionality for sections where modify is not applicable. - Changed

[PATCH v2] network: add modify-or-add feature to net-update

state. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/363 Signed-off-by: Abhiram Tilak --- Changes in v2: - Removed the modify-or-add functionality for sections where modify is not applicable. - Changed the existing implementation of `UpdateIPDHCPHost`, to avoid code duplication

[PATCH v2] network: add modify-or-add feature to net-update

state. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/363 Signed-off-by: Abhiram Tilak --- Changes in v2: - Removed the modify-or-add functionality for sections where modify is not applicable. - Changed the existing implementation of `UpdateIPDHCPHost`, to avoid code duplication

[PATCH v2] docs: formatsnapshot: add docs for snapshotDeleteInProgress

. The commit was merged but the related documentation was missing. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/609 Signed-off-by: Abhiram Tilak --- Changes in v2: - Insert a note to advise users against adding or removing the internal tag "snapshotDeleteInProgress" manual

[PATCH] docs: mention migrate-setmaxdowntime's impact on snapshot-create

The migrate-setmaxdowntime command sets the max allowed downtime during live-migration, but since `snapshot-create` performs qmp migration, it also affects the downtime during internal/external snapshot creation. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/593 Signed-off-by: Abhiram

[PATCH] "docs: formatsnapshot: add docs for snapshotDeleteInProgress"

. The commit was merged but the related documentation was missing. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/609 Signed-off-by: Abhiram Tilak --- docs/formatsnapshot.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/docs/formatsnapshot.rst b/docs/formatsnapshot.rst index

[PATCH] network: add modify-or-add feature to net-update

state. Fixes: https://gitlab.com/libvirt/libvirt/-/issues/363 Signed-off-by: Abhiram Tilak --- docs/manpages/virsh.rst | 5 +- include/libvirt/libvirt-network.h | 2 + src/conf/network_conf.c | 148 -- tools/virsh-network.c | 4 +- 4

[PATCH v2] storage: Upgrade default qcow2 verion to 1.1

anymore, but this patch doesn't affect them. Signed-off-by: Abhiram Tilak Reviewed-by: Peter Krempa --- src/storage/storage_util.c | 2 +- .../storagevolxml2argvdata/luks-convert-encrypt2fileqcow2.argv | 2 +- tests/storagevolxml2argvdata/qcow2-compat.argv

[PATCH v2] storage: Upgrade default qcow2 version

, but this patch doesn't affect them. Signed-off-by: Abhiram Tilak Reviewed-by: Peter Krempa --- src/storage/storage_util.c | 2 +- .../storagevolxml2argvdata/luks-convert-encrypt2fileqcow2.argv | 2 +- tests/storagevolxml2argvdata/qcow2-compat.argv

[PATCH v2] storage: Upgrade default qcow2 version

, but this patch doesn't affect them. Signed-off-by: Abhiram Tilak Reviewed-by: Peter Krempa --- src/storage/storage_util.c | 2 +- .../storagevolxml2argvdata/luks-convert-encrypt2fileqcow2.argv | 2 +- tests/storagevolxml2argvdata/qcow2-compat.argv

[PATCH 2/2] storage: fix testcases on changing the default qcow2 compat to 1.1

so didn't include in the patch. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/602 Signed-off-by: Abhiram Tilak --- .../storagevolxml2argvdata/luks-convert-encrypt2fileqcow2.argv | 2 +- tests/storagevolxml2argvdata/qcow2-compat.argv | 2 +- tests/storagevolxml2argvdata

[PATCH 1/2] storage: change assigning qcow2 compat to 1.1 from 0.10 automatically

-by: Abhiram Tilak --- src/storage/storage_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index 7bf815d978..28d5fce4f0 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -765,7 +765,7

[PATCH 0/2] storage: Upgrade default qcow2 verion to 1.1

. This also requires correcting multiple testcases related to this compat version. If any other locations require changing, they will be added as a part of this series. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/602 Abhiram Tilak (2): storage: change assigning qcow2 compat to 1.1 from 0.10