Re: [PATCH RFC v3 03/16] config: Introduce ThrottleGroup and corresponding XML parsing

2024-08-23 Thread Chun Feng Wu
On 2024/8/23 15:10, Peter Krempa wrote: On Fri, Aug 23, 2024 at 14:00:25 +0800, Chun Feng Wu wrote: On 2024/7/26 21:03, Peter Krempa wrote: +static virDomainThrottleGroupDef * +virDomainThrottleGroupDefParseXML(xmlNodePtr node, + xmlXPathContextPtr ctxt

Re: [PATCH RFC v3 03/16] config: Introduce ThrottleGroup and corresponding XML parsing

2024-08-22 Thread Chun Feng Wu
On 2024/7/26 21:03, Peter Krempa wrote: +static virDomainThrottleGroupDef * +virDomainThrottleGroupDefParseXML(xmlNodePtr node, + xmlXPathContextPtr ctxt) +{ +g_autoptr(virDomainThrottleGroupDef) group = g_new0(virDomainThrottleGroupDef, 1); + +VIR_XPATH

Re: [PATCH RFC v3 09/16] qemu: hotplug: Support hot attach and detach block disk along with throttle filters

2024-08-20 Thread Chun Feng Wu
On 2024/8/20 23:08, Peter Krempa wrote: On Tue, Aug 20, 2024 at 22:48:53 +0800, Chun Feng Wu wrote: On 2024/8/19 18:59, Peter Krempa wrote: On Mon, Aug 19, 2024 at 18:27:46 +0800, Chun Feng Wu wrote: On 2024/8/16 23:14, Peter Krempa wrote: On Thu, Aug 15, 2024 at 13:04:47 +0800, Chun Feng

Re: [PATCH RFC v3 09/16] qemu: hotplug: Support hot attach and detach block disk along with throttle filters

2024-08-20 Thread Chun Feng Wu
On 2024/8/19 18:59, Peter Krempa wrote: On Mon, Aug 19, 2024 at 18:27:46 +0800, Chun Feng Wu wrote: On 2024/8/16 23:14, Peter Krempa wrote: On Thu, Aug 15, 2024 at 13:04:47 +0800, Chun Feng Wu wrote: (I'd suggest you trim irrelevant stuff when responding. It's hard to find w

Re: [PATCH RFC v3 09/16] qemu: hotplug: Support hot attach and detach block disk along with throttle filters

2024-08-19 Thread Chun Feng Wu
On 2024/8/16 23:14, Peter Krempa wrote: On Thu, Aug 15, 2024 at 13:04:47 +0800, Chun Feng Wu wrote: (I'd suggest you trim irrelevant stuff when responding. It's hard to find what you've responded to in this massive message . On 2024/8/9 22:04, Peter Krempa wrote: On Wed, Jun

Re: [PATCH RFC v3 09/16] qemu: hotplug: Support hot attach and detach block disk along with throttle filters

2024-08-15 Thread Chun Feng Wu
On 2024/8/15 13:04, Chun Feng Wu wrote: On 2024/8/9 22:04, Peter Krempa wrote: On Wed, Jun 12, 2024 at 03:02:17 -0700,w...@linux.ibm.com  wrote: From: Chun Feng Wu When attaching disk along with specified throttle groups, those groups will be chained up by parent node name, this change

Re: [PATCH RFC v3 09/16] qemu: hotplug: Support hot attach and detach block disk along with throttle filters

2024-08-14 Thread Chun Feng Wu
On 2024/8/9 22:04, Peter Krempa wrote: On Wed, Jun 12, 2024 at 03:02:17 -0700,w...@linux.ibm.com wrote: From: Chun Feng Wu When attaching disk along with specified throttle groups, those groups will be chained up by parent node name, this change includes service side codes: * Each filter

Re: [PATCH RFC v3 08/16] qemu: Implement qemu driver for throttle API

2024-08-09 Thread Chun Feng Wu
On 2024/7/26 23:06, Peter Krempa wrote: On Wed, Jun 12, 2024 at 03:02:16 -0700, w...@linux.ibm.com wrote: From: Chun Feng Wu Implement the following methods in qemu driver: * Extract common methods for "qemuDomainSetBlockIoTune" and "qemuDomainS

Re: [PATCH RFC v3 05/16] qemu: monitor: Add support for ThrottleGroup operations

2024-08-06 Thread Chun Feng Wu
let me confirm my understanding, do you mean there should be group name mapping between DOM($group_name_in_DOM) and QOM(throttle-$group_name_in_DOM) for both throttle group and throttle filter? if so, there seems two ways to achieve that: - mapping group_name in callers like qemu_driver.c, qem

Re: [PATCH RFC v3 02/16] schema: Add new domain elements to support multiple throttle filters

2024-08-06 Thread Chun Feng Wu
nt: 400 iops in total, around 200(400/2) for each disk - individual disk test: 200 for vdb, 400 for vdc                         function='0x0'/>     let me know if I understand your case correctly, thanks! On 2024/8/6 15:36, Peter Krempa wrote: On Tue, Aug 06, 2024 at 00:27:58 -

Re: [PATCH RFC v3 02/16] schema: Add new domain elements to support multiple throttle filters

2024-08-05 Thread Chun Feng Wu
The order of such ``throttlefilter`` doesn't matter within ``throttlefilters``. I will put above statement into doc

Re: [PATCH RFC v3 03/16] config: Introduce ThrottleGroup and corresponding XML parsing

2024-07-27 Thread Chun Feng Wu
Thanks Peter for your review! I am on vacation, and will start to address comments Aug. 5

Re: [PATCH RFC v3 05/16] qemu: monitor: Add support for ThrottleGroup operations

2024-07-02 Thread Chun Feng Wu
Sure, enjoy your holidays!

Re: [PATCH RFC v2 00/12] Support throttle block filters

2024-06-12 Thread Chun Feng Wu
I just pushed v3 at https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/HIIXCOZG2AVNJJAO5KTPJHXRU4GPO2HI/

Re: [PATCH RFC v2 07/12] schema: Add new domain elements to support multiple throttle filters

2024-06-12 Thread Chun Feng Wu
I checked "QEMU_CAPS_OBJECT_JSON" in v3 https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/HIIXCOZG2AVNJJAO5KTPJHXRU4GPO2HI/

Re: [PATCH RFC v2 07/12] schema: Add new domain elements to support multiple throttle filters

2024-06-12 Thread Chun Feng Wu
fixed in v3 https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/HIIXCOZG2AVNJJAO5KTPJHXRU4GPO2HI/

Re: [PATCH RFC v2 07/12] schema: Add new domain elements to support multiple throttle filters

2024-06-06 Thread Chun Feng Wu
for comment "Preferrably all these definitions should be shared with as any change would now need to change two places." do you mean we use domain xml like the following one(which reuse definition): ... limit0 1000 40 10

Re: [PATCH RFC v2 07/12] schema: Add new domain elements to support multiple throttle filters

2024-06-06 Thread Chun Feng Wu
Thanks Peter for above comments! My original design goal is exact the same as what QEMU doc says at https://github.com/qemu/qemu/blob/master/docs/throttle.txt: "In this example the individual drives have IOPS limits of 2000, 2500 and 3000 respectively but the total combined I/O can never exceed

Re: [PATCH RFC v2 00/12] Support throttle block filters

2024-05-10 Thread Chun Feng Wu
Sure On 2024/5/9 16:39, Peter Krempa wrote: On Thu, May 09, 2024 at 16:33:17 +0800, Chun Feng Wu wrote: Thanks Peter for above detailed review comments! just let you know, I am addressing those comments, I will push v3 to include fixings in coming weeks. You can fix stuff I've pointed ou

Re: [PATCH RFC v2 00/12] Support throttle block filters

2024-05-09 Thread Chun Feng Wu
Thanks Peter for above detailed review comments! just let you know, I am addressing those comments, I will push v3 to include fixings in coming weeks. On 2024/4/25 17:23, Peter Krempa wrote: On Mon, Apr 22, 2024 at 17:28:11 +0800, Chun Feng Wu wrote: Hi, May I know if this new version code

Re: [PATCH RFC v2 00/12] Support throttle block filters

2024-04-22 Thread Chun Feng Wu
Hi, May I know if this new version code is under review? On 2024/4/12 10:01, w...@linux.ibm.com wrote: From: Chun Feng Wu Hi, I am thinking to leverage "throttle block filter" in QEMU to support more flexible I/O limits(e.g. tiered I/O groups), one sample provided by QEMU doc

Re: [PATCH RFC 00/12] Support throttle block filters

2024-04-11 Thread Chun Feng Wu
I addressed those comments in v2 https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/5Z3J4SSEFWPZGN436HUGP2M6G4NPCWNW/ On 2024/4/10 16:08, Peter Krempa wrote: On Tue, Apr 09, 2024 at 20:13:08 -0700, w...@linux.ibm.com wrote: From: Chun Feng Wu Hi, I am thinking to

Re: [PATCH RFC 00/12] Support throttle block filters

2024-04-10 Thread Chun Feng Wu
Thanks Peter for your quick response! I will fix the issues you listed On 2024/4/10 16:08, Peter Krempa wrote: On Tue, Apr 09, 2024 at 20:13:08 -0700, w...@linux.ibm.com wrote: From: Chun Feng Wu Hi, I am thinking to leverage "throttle block filter" in QEMU to support more fl