test_libvirt_sanlock.aug is dependent on WITH_QEMU in meson config
Signed-off-by: Cole Robinson
---
libvirt.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index aff2707705..7cb558770f 100644
--- a/libvirt.spec.in
+++ b
This matches the cpu_family() check in `meson.build`
Signed-off-by: Cole Robinson
---
note: something probably needs to be fixed on meson.build side too,
since an explicit `driver_ch=enabled` doesn't generate a build
error.
libvirt.spec.in | 4
1 file changed, 4 insertions(+)
diff
openssh 8.4p1 released in Sep 2020 added a feature to force use
of SSH_ASKPASS
https://man.openbsd.org/ssh.1#SSH_ASKPASS_REQUIRE
Don't strip it from the environment
Signed-off-by: Cole Robinson
---
src/rpc/virnetsocket.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sr
/usr/bin/dtrace has been split from `systemtap-sdt-devel` into
`systemtap-sdt-dtrace`
It's forward and backward compatible to require the dtrace binary
directly.
We still need the latter dep though, for sdt.h in generated
libvirt_probes.h
Signed-off-by: Cole Robinson
---
libvirt.spec.i
.0023/8e37ee90-2b51-45e3-9b25-bf8283c03110
css_0_0_0023
```
There's already code that does what we want in the test suite.
Move it to a shared function, and call it in test driver when
creating a nodedev from driver startup XML.
Signed-off-by: Cole Robinson
---
See last patch for explanation. First two patches are related
bugfixes/improvements
v5:
- Changed impl to match Boris' suggestion
Cole Robinson (3):
test: make parsed nodedevs active and persistent
test: Sync GetXML INACTIVE behavior with live driver
test: nodedev: fill active_conf
- Error if INACTIVE requested for transient object
- Force dumping INACTIVE XML when object is inactive
Signed-off-by: Cole Robinson
---
src/test/test_driver.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
This was the implied default before nodedevs gained a notion of
being inactive and transient. It also matches the implied default
when parsing other object types
Signed-off-by: Cole Robinson
---
src/test/test_driver.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/test/test_driver.c
On 4/19/24 8:38 AM, Boris Fiuczynski wrote:
> On 4/17/24 17:17, Cole Robinson wrote:
>> Commit v10.0.0-265-ge67bca23e4 added a `active_config` and
>> `defined_config` to nodedev mdev internal XML handling.
>> `defined_config` can be filled at XML parse time, but `active_conf
On 4/18/24 5:11 AM, Boris Fiuczynski wrote:
> On 4/17/24 15:58, Cole Robinson wrote:
>>>> Simplest solution is to fill in `active_config` at XML define time
>>>> as well. The real node_device driver already takes care to free any
>>>> `active_config` when it
On 4/17/24 10:12 AM, Daniel P. Berrangé wrote:
> On Wed, Apr 17, 2024 at 09:58:10AM -0400, Cole Robinson wrote:
>> On 4/9/24 11:20 AM, Boris Fiuczynski wrote:
>>> On 4/9/24 16:56, Cole Robinson wrote:
>>>> Commit v10.0.0-265-ge67bca23e4 added a `active_config` and
&g
p the test suite logic to duplicate this data.
Signed-off-by: Cole Robinson
---
src/conf/node_device_conf.c | 5 -
tests/nodedevxml2xmltest.c | 15 ---
2 files changed, 4 insertions(+), 16 deletions(-)
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
This was the implied default before nodedevs gained a notion of
being inactive and transient. It also matches the implied default
when parsing other object types
Signed-off-by: Cole Robinson
---
src/test/test_driver.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/test/test_driver.c
- Error if INACTIVE requested for transient object
- Force dumping INACTIVE XML when object is inactive
Signed-off-by: Cole Robinson
---
src/test/test_driver.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
See last patch for explanation. First two patches are related
bugfixes/improvements
v4 changes:
- 3 patches pushed
- mark parsed devices as persistent too
- add GetXML fix patch
Cole Robinson (3):
test: make parsed nodedevs active and persistent
test: Sync GetXML INACTIVE behavior with
On 4/17/24 10:04 AM, Cole Robinson wrote:
> On 4/9/24 11:19 AM, Boris Fiuczynski wrote:
>> On 4/9/24 16:56, Cole Robinson wrote:
>>> This was the implied default before nodedevs gained a notion of
>>> being inactive, and matches how we handle parsing other objects
On 4/9/24 11:19 AM, Boris Fiuczynski wrote:
> On 4/9/24 16:56, Cole Robinson wrote:
>> This was the implied default before nodedevs gained a notion of
>> being inactive, and matches how we handle parsing other objects
>>
>> Signed-off-by: Cole Robinson
>> --
On 4/9/24 11:20 AM, Boris Fiuczynski wrote:
> On 4/9/24 16:56, Cole Robinson wrote:
>> Commit v10.0.0-265-ge67bca23e4 added a `active_config` and
>> `defined_config` to nodedev mdev internal XML handling.
>> `defined_config` can be filled at XML parse time, but `active_config`
p the test suite logic to duplicate this data.
Signed-off-by: Cole Robinson
---
src/conf/node_device_conf.c | 5 -
tests/nodedevxml2xmltest.c | 15 ---
2 files changed, 4 insertions(+), 16 deletions(-)
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
Signed-off-by: Cole Robinson
---
src/test/test_driver.c | 16
1 file changed, 16 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index f9bd6f4e67..41828f86b6 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -7794,6 +7794,21
$ virsh --connect test:///default nodedev-list
error: Failed to list node devices
error: unsupported flags (0x8000) in function testConnectListAllNodeDevices
The test driver handles the nodedev state flags, we just need to
allow them
Signed-off-by: Cole Robinson
---
src/test/test_driver.c
This was the implied default before nodedevs gained a notion of
being inactive, and matches how we handle parsing other objects
Signed-off-by: Cole Robinson
---
src/test/test_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index
Signed-off-by: Cole Robinson
---
src/test/test_driver.c | 16
1 file changed, 16 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 852a084bce..f9bd6f4e67 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -7779,6 +7779,21
nodedev
test driver improvements I hit when debugging this
v3:
really truly send to the correct list
v2:
Send to the correct mailing list
Fix version strings in test driver table
Cole Robinson (5):
test: Fix `virsh nodedev-list`
test: Implement virNodeDeviceIsActive
test: Implement
On 11/1/23 11:02 AM, Daniel P. Berrangé wrote:
> On Wed, Nov 01, 2023 at 10:54:25AM -0400, Cole Robinson wrote:
>> On 11/1/23 5:44 AM, Jiri Denemark wrote:
>>> The 9.9.0 release of both libvirt and libvirt-python is tagged and
>>> signed tarballs and source RPMs are ava
On 11/1/23 5:44 AM, Jiri Denemark wrote:
> The 9.9.0 release of both libvirt and libvirt-python is tagged and
> signed tarballs and source RPMs are available at
>
> https://download.libvirt.org/
> https://download.libvirt.org/python/
>
> Thanks everybody who helped with this release by se
On 10/28/23 10:49 AM, Jonathon Jongsma wrote:
>
> I'm currently looking at getting libvirt working with AMD's SEV-SNP
> encrypted virtualization technology. I have access to a test machine
> with an AMD EPYC 7713 processor which I can use to launch SNP guests
> with qemu, but only when I specify o
27 matches
Mail list logo
