Re: [PATCH 0/2] docs: Fix docs for VIR_MIGRATE_PARAM_MIGRATE_DISKS_DETECT_ZEROES_ZEROES

--- > 2 files changed, 8 insertions(+), 11 deletions(-) Series: Acked-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: [PATCH 4/4] docs/about/removed-features: Move removal notes to tidy up order

moved-features.rst | 60 - > 1 file changed, 30 insertions(+), 30 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: [PATCH 3/4] docs/about/deprecated: Move deprecation notes to tidy up order

out/deprecated.rst | 32 > 1 file changed, 16 insertions(+), 16 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: [PATCH 1/4] docs/about: Belatedly document tightening of QMP device_add checking

to update > documentation. Do that now. > > Cc: Stefan Hajnoczi > Signed-off-by: Markus Armbruster -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: [PATCH v2 1/2] qapi: synchronize jobs and block-jobs documentation

est)), > +# where it also switches the device to write to the target path only. The doubly-nested parenthetical feels long. Is there a more concise way of expressing the list of three commands, where one of the commands only supports it in the special case of "active commit"?

Re: [PATCH v2 2/2] qapi/block-core: derpecate some block-job- APIs

x27;'''' > + > +Use ``job-pause`` instead. The only difference is that ``job-pause`` > +always reports GenericError on failure when ``block-job-pause`` reports > +DeviceNotActive when block-job is not found. Typo fixes are minor, so: Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: [PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

ck their slightly different forms and pass them as parameters to nbd_server_start() that is then agnostic to whether the older QMP command or newer q-s-d CLI option was specified. It looks like libvirt is still using QMP nbd-server-start. If we were to start the deprecation process for qemu 10.0, what

Re: [PATCH] chardev: allow specifying finer-grained reconnect timeouts

es in QAPI where we want mutual exclusion (we mark both fields optional, but expect the user to provide exactly one or get an error), that I wonder if it is worth making it a first-class construct in QAPI (maybe I'm spoiled by the OneOf designation[1] in protobuf[2] used by gRPC[3] in kubernet

Re: [PATCH 4/4] qapi/char: Deprecate backend type "memory"

erdue. > > Signed-off-by: Markus Armbruster > --- > docs/about/deprecated.rst | 8 > qapi/char.json| 8 +--- > 2 files changed, 13 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Eng

Re: [PATCH 3/4] qapi/char: Make backend types properly conditional

tionals to the QAPI schema. > > Signed-off-by: Markus Armbruster > --- > qapi/char.json | 20 ++++---- > 1 file changed, 12 insertions(+), 8 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs

Re: [PATCH 2/4] tests/unit/test-char: Fix qemu_socket(), make_udp_socket() check

-char.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake Might be worth amending the commit message of 1/4 where you called out this bug to mention it will be fixed in the next patch. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: q

Re: [PATCH 1/4] chardev/parallel: Don't close stdin on inappropriate device

RDEV_PARALLEL 1 #else # if defined(__linux__) ... defined(__APPLE__) # define HAVE_CHARDEV_SERIAL 1 # endif # if defined(__linux__) ... defined(__DragonFly__) # define HAVE_CHARDEV_PARALLEL 1 # endif #endif > +++ b/chardev/meson.build > @@ -21,11 +21,9 @@ if host_os == 'windows&#x