Re: [PATCH 1/2] hw/acpi: Remove the deprecated QAPI MEM_UNPLUG_ERROR event

2024-05-31 Thread Harsh Prateek Bora
--- docs/about/removed-features.rst | 9 + qapi/machine.json | 28 hw/acpi/memory_hotplug.c| 8 hw/ppc/spapr.c | 11 +-- 5 files changed, 10 insertions(+), 51 deletions(-) For spapr: Reviewed-by: Har

Re: [PATCH v2 2/2] docs/about: Deprecate the old "power5+" and "power7+" CPU names

2024-01-23 Thread Harsh Prateek Bora
On 1/17/24 19:40, Thomas Huth wrote: For consistency we should drop the names with a "+" in it in the long run. Signed-off-by: Thomas Huth Reviewed-by: Harsh Prateek Bora --- docs/about/deprecated.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/

Re: [PATCH v2 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules

2024-01-23 Thread Harsh Prateek Bora
a hack in type_name_is_valid() to still allow them for compatibility reasons. However, there is a much nicer solution for this: Simply use aliases! This way we can still support the old names without the need for the ugly hack in type_name_is_valid(). Signed-off-by: Thomas Huth Reviewe

Re: [PATCH 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules

2024-01-12 Thread Harsh Prateek Bora
On 1/12/24 10:42, Thomas Huth wrote: On 12/01/2024 05.57, Harsh Prateek Bora wrote: On 1/11/24 22:16, Thomas Huth wrote: The character "+" is now forbidden in QOM device names (see commit b447378e1217 - "Limit type names to alphanumerical and some few special characters&quo

Re: [PATCH 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules

2024-01-12 Thread Harsh Prateek Bora
TYPE("power5+_v2.1"), +DEFINE_SPAPR_CPU_CORE_TYPE("power5plus_v2.1"), DEFINE_SPAPR_CPU_CORE_TYPE("power7_v2.3"), -DEFINE_SPAPR_CPU_CORE_TYPE("power7+_v2.1"), +DEFINE_SPAPR_CPU_CORE_TYPE("power7plus_v2.1"), Will using Power5x, Power7x be a