Re: [PATCH] virt-aa-helper: Drop needless comments

2024-07-09 Thread Jim Fehlig via Devel
On 7/9/24 04:04, Michal Privoznik wrote: When generating paths for a domain specific AppArmor profile each path undergoes a validation where it's matched against an array of well known prefixes (among other things). Now, for OVMF/AAVMF/... images we have a list and some entries have comments to

[PATCH RFC 9/9] qemu: Support O_DIRECT with mapped-ram on restore

2024-06-13 Thread Jim Fehlig via Devel
Signed-off-by: Jim Fehlig --- src/qemu/qemu_driver.c| 22 +- src/qemu/qemu_migration.c | 2 +- src/qemu/qemu_process.c | 20 src/qemu/qemu_process.h | 3 +++ src/qemu/qemu_saveimage.c | 29 + src/qemu/qemu_saveimage.h

[PATCH RFC 8/9] qemu: Support O_DIRECT with mapped-ram on save

2024-06-13 Thread Jim Fehlig via Devel
Signed-off-by: Jim Fehlig --- I'm not happy with this and the subsequent patch, which pass another FD around for QEMU to use for reading/writing unaligned state when BYPASS_CACHE has been specified. One idea is to pass the qemuFdPass object around the various functions, but qemu_fd.h already

[PATCH RFC 7/9] qemu: Enable mapped-ram on restore

2024-06-13 Thread Jim Fehlig via Devel
Signed-off-by: Jim Fehlig --- src/qemu/qemu_migration.c | 19 +++ src/qemu/qemu_migration.h | 3 ++- src/qemu/qemu_process.c | 49 --- src/qemu/qemu_process.h | 13 +++ src/qemu/qemu_saveimage.c | 26 ++--- 5 files

[PATCH RFC 6/9] qemu: Add support for mapped-ram on save

2024-06-13 Thread Jim Fehlig via Devel
Signed-off-by: Jim Fehlig --- src/qemu/qemu_driver.c| 2 +- src/qemu/qemu_migration.c | 79 src/qemu/qemu_migration.h | 7 +++ src/qemu/qemu_monitor.c | 32 src/qemu/qemu_monitor.h | 4 ++ src/qemu/qemu_saveimage.c | 105

[PATCH RFC 5/9] qemu: conf: Add setting for save image version

2024-06-13 Thread Jim Fehlig via Devel
Add a 'save_image_version' setting to qemu.conf to control the image version when saving a VM with 'virsh save' or 'virsh managedsave'. Default to the new version 3. Signed-off-by: Jim Fehlig --- src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf.in | 6 ++

[PATCH RFC 4/9] qemu: Add a 'features' element to save image header and bump version

2024-06-13 Thread Jim Fehlig via Devel
QEMU's new mapped-ram stream format [1] is incompatible with the existing sequential format. In order to support the new format in libvirt, a new 'features' element is added to the saved image header. This element can be used now indicate the use of mapped-ram feature, and provides a mechanism to

[PATCH RFC 3/9] qemu: Add function to get migration params for save

2024-06-13 Thread Jim Fehlig via Devel
Introduce qemuMigrationParamsForMappedSave() to create a qemuMigrationParams object initialized with appropriate migration capabilities and parameters for a save operation using mapped-ram. Note that mapped-ram also requires the multifd capability. For now, the number of multifd channels is set

[PATCH RFC 2/9] qemu_fd: Add function to retrieve fdset ID

2024-06-13 Thread Jim Fehlig via Devel
Add new function qemuFDPassGetId(), to be used when adding support for mapped-ram save format. Signed-off-by: Jim Fehlig --- src/qemu/qemu_fd.c | 18 ++ src/qemu/qemu_fd.h | 3 +++ 2 files changed, 21 insertions(+) diff --git a/src/qemu/qemu_fd.c b/src/qemu/qemu_fd.c index

[PATCH RFC 1/9] qemu: Enable mapped-ram migration capability

2024-06-13 Thread Jim Fehlig via Devel
Signed-off-by: Jim Fehlig --- src/qemu/qemu_migration_params.c | 1 + src/qemu/qemu_migration_params.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c index 48f8657f71..201286e58c 100644 ---

[PATCH RFC 0/9] qemu: Support mapped-ram migration capability

2024-06-13 Thread Jim Fehlig via Devel
This series is a RFC for support of QEMU's mapped-ram migration capability [1] for saving and restoring VMs. It implements the first part of the design approach we discussed for supporting parallel save/restore [2]. In summary, the approach is 1. Add mapped-ram migration capability 2. Steal an

Re: Add iommu device when VM configured with > 255 vcpus

2024-05-30 Thread Jim Fehlig via Devel
On 5/30/24 6:45 AM, Igor Mammedov wrote: On Wed, 29 May 2024 14:44:52 -0400 Sergio Durigan Junior wrote: On Tuesday, May 28 2024, Jim Fehlig via Devel wrote: Hi All, I vaguely recall a discussion about $subject, but can't find it now. Perhaps buried in another thread. The topic has been

Re: Add iommu device when VM configured with > 255 vcpus

2024-05-29 Thread Jim Fehlig via Devel
On 5/29/24 1:41 AM, Peter Krempa wrote: On Tue, May 28, 2024 at 16:26:18 -0600, Jim Fehlig via Devel wrote: Hi All, I vaguely recall a discussion about $subject, but can't find it now. Perhaps buried in another thread. The topic has been raised internally again, and I'd like to gauge

Add iommu device when VM configured with > 255 vcpus

2024-05-28 Thread Jim Fehlig via Devel
Hi All, I vaguely recall a discussion about $subject, but can't find it now. Perhaps buried in another thread. The topic has been raised internally again, and I'd like to gauge the community's interest in automatically adding the necessary devices/config when user has specified vcpus > 255.

Re: [PATCH] libxl: Fix domxml-to-native conversion

2024-05-02 Thread Jim Fehlig via Devel
On 5/2/24 5:24 AM, Ján Tomko wrote: On a Monday in 2024, Jim Fehlig via Devel wrote: Similar to commit 57d084febe, another case of the libxl driver not adapting to modular daemons. When converting configuration that contains a type='network' interface, the converter calls virNetworkLookupByName

Re: Revisiting parallel save/restore

2024-05-01 Thread Jim Fehlig via Devel
On 4/26/24 4:04 AM, Daniel P. Berrangé wrote: On Wed, Apr 17, 2024 at 05:12:27PM -0600, Jim Fehlig via Devel wrote: A good starting point on this journey is supporting the new mapped-ram capability in qemu 9.0 [2]. Since mapped-ram is a new on-disk format, I assume we'll need a new

[PATCH] libxl: Fix domxml-to-native conversion

2024-04-29 Thread Jim Fehlig via Devel
Similar to commit 57d084febe, another case of the libxl driver not adapting to modular daemons. When converting configuration that contains a type='network' interface, the converter calls virNetworkLookupByName, passing the hypervisor connection object instead of a connection to virtnetworkd. E.g.

Re: Revisiting parallel save/restore

2024-04-26 Thread Jim Fehlig via Devel
On 4/26/24 4:07 AM, Daniel P. Berrangé wrote: On Thu, Apr 25, 2024 at 04:41:02PM -0600, Jim Fehlig via Devel wrote: On 4/17/24 5:12 PM, Jim Fehlig wrote: Hi All, While Fabiano has been working on improving save/restore performance in qemu, I've been tinkering with the same in libvirt. The end

Re: Revisiting parallel save/restore

2024-04-26 Thread Jim Fehlig via Devel
On 4/26/24 4:04 AM, Daniel P. Berrangé wrote: On Wed, Apr 17, 2024 at 05:12:27PM -0600, Jim Fehlig via Devel wrote: A good starting point on this journey is supporting the new mapped-ram capability in qemu 9.0 [2]. Since mapped-ram is a new on-disk format, I assume we'll need a new

Re: [PATCH v1 15/20] node_device_udev: Pass the driver state as parameter in preparation for the next commit

2024-04-25 Thread Jim Fehlig via Devel
On 4/23/24 3:41 AM, Marc Hartmayer wrote: On Tue, Apr 23, 2024 at 10:06 AM +0100, Daniel P. Berrangé wrote: On Tue, Apr 23, 2024 at 10:46:14AM +0200, Marc Hartmayer wrote: On Tue, Apr 23, 2024 at 09:10 AM +0100, Daniel P. Berrangé wrote: On Tue, Apr 23, 2024 at 10:03:35AM +0200, Marc

Re: Revisiting parallel save/restore

2024-04-25 Thread Jim Fehlig via Devel
On 4/17/24 5:12 PM, Jim Fehlig wrote: Hi All, While Fabiano has been working on improving save/restore performance in qemu, I've been tinkering with the same in libvirt. The end goal is to introduce a new VIR_DOMAIN_SAVE_PARALLEL flag for save/restore, along with a

Revisiting parallel save/restore

2024-04-17 Thread Jim Fehlig via Devel
Hi All, While Fabiano has been working on improving save/restore performance in qemu, I've been tinkering with the same in libvirt. The end goal is to introduce a new VIR_DOMAIN_SAVE_PARALLEL flag for save/restore, along with a VIR_DOMAIN_SAVE_PARAM_PARALLEL_CONNECTIONS parameter to specify