Re: [PATCH RESEND 0/5] Introduce pstore device

ed, 532 insertions(+) > create mode 100644 > tests/qemuxmlconfdata/pstore-acpi-erst.x86_64-latest.args > create mode 12 > tests/qemuxmlconfdata/pstore-acpi-erst.x86_64-latest.xml > create mode 100644 tests/qemuxmlconfdata/pstore-acpi-erst.xml > > -- > 2.44.2 > > Reviewed-by: Kristina Hanicova Kristina

Re: [PATCH 5/5] NEWS: Document pstore device addition

ust before the it crashes. Typical > usage > *before it crashes +includes usage in combination with a watchdog so that the logs can be > +inspected after the watchdog rebooted the machine. > + > * **Improvements** > > * **Bug fixes** > -- > 2.44.2 > > Reviewed-by: Kristina Hanicova Kristina

Re: [PATCH 2/5] conf: Introduce pstore device

_driver.c > +++ b/src/test/test_driver.c > @@ -10294,6 +10294,7 @@ testDomainUpdateDevice(virDomainDef *vmdef, > case VIR_DOMAIN_DEVICE_VSOCK: > case VIR_DOMAIN_DEVICE_AUDIO: > case VIR_DOMAIN_DEVICE_CRYPTO: > +case VIR_DOMAIN_DEVICE_PSTORE: > case VIR_DOMAIN_DEVICE_LAST: > virReportError(VIR_ERR_OPERATION_UNSUPPORTED, > _("persistent update of device '%1$s' is not > supported"), > diff --git a/tests/qemuxmlconfdata/pstore-acpi-erst.x86_64-latest.args > b/tests/qemuxmlconfdata/pstore-acpi-erst.x86_64-latest.args > new file mode 100644 > index 00..d7c4708acb > --- /dev/null > +++ b/tests/qemuxmlconfdata/pstore-acpi-erst.x86_64-latest.args > @@ -0,0 +1,36 @@ > +LC_ALL=C \ > +PATH=/bin \ > +HOME=/var/lib/libvirt/qemu/domain--1-guest \ > +USER=test \ > +LOGNAME=test \ > +XDG_DATA_HOME=/var/lib/libvirt/qemu/domain--1-guest/.local/share \ > +XDG_CACHE_HOME=/var/lib/libvirt/qemu/domain--1-guest/.cache \ > +XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-guest/.config \ > +/usr/bin/qemu-system-x86_64 \ > +-name guest=guest,debug-threads=on \ > +-S \ > +-object > '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-guest/master-key.aes"}' > \ > +-machine > pc-q35-9.0,usb=off,dump-guest-core=off,memory-backend=pc.ram,acpi=on \ > +-accel kvm \ > +-cpu qemu64 \ > +-m size=1048576k \ > +-object > '{"qom-type":"memory-backend-ram","id":"pc.ram","size":1073741824}' \ > +-overcommit mem-lock=off \ > +-smp 1,sockets=1,cores=1,threads=1 \ > +-uuid 63840878-0deb-4095-97e6-fc444d9bc9fa \ > +-display none \ > +-no-user-config \ > +-nodefaults \ > +-chardev socket,id=charmonitor,fd=1729,server=on,wait=off \ > +-mon chardev=charmonitor,id=monitor,mode=control \ > +-rtc base=utc \ > +-no-shutdown \ > +-boot strict=on \ > +-device > '{"driver":"pcie-root-port","port":8,"chassis":1,"id":"pci.1","bus":"pcie.0","multifunction":true,"addr":"0x1"}' > \ > +-device > '{"driver":"pcie-pci-bridge","id":"pci.2","bus":"pci.1","addr":"0x0"}' \ > +-device > '{"driver":"pcie-root-port","port":9,"chassis":3,"id":"pci.3","bus":"pcie.0","addr":"0x1.0x1"}' > \ > +-audiodev '{"id":"audio1","driver":"none"}' \ > +-global ICH9-LPC.noreboot=off \ > +-watchdog-action reset \ > +-sandbox > on,obsolete=deny,elevateprivileges=deny,spawn=deny,resourcecontrol=deny \ > +-msg timestamp=on > diff --git a/tests/qemuxmlconfdata/pstore-acpi-erst.x86_64-latest.xml > b/tests/qemuxmlconfdata/pstore-acpi-erst.x86_64-latest.xml > new file mode 12 > index 00..11ade68605 > --- /dev/null > +++ b/tests/qemuxmlconfdata/pstore-acpi-erst.x86_64-latest.xml > @@ -0,0 +1 @@ > +pstore-acpi-erst.xml > \ No newline at end of file > diff --git a/tests/qemuxmlconfdata/pstore-acpi-erst.xml > b/tests/qemuxmlconfdata/pstore-acpi-erst.xml > new file mode 100644 > index 00..9b9ba266b2 > --- /dev/null > +++ b/tests/qemuxmlconfdata/pstore-acpi-erst.xml > @@ -0,0 +1,53 @@ > + > + guest > + 63840878-0deb-4095-97e6-fc444d9bc9fa > + 1048576 > + 1048576 > + 1 > + > +hvm > + > + > + > + > + > + > +qemu64 > + > + > + destroy > + restart > + destroy > + > +/usr/bin/qemu-system-x86_64 > + > + > + function='0x2'/> > + > + > + > + > + > + function='0x0' multifunction='on'/> > + > + > + > + function='0x0'/> > + > + > + > + > + function='0x1'/> > + > + > + > + > + > + > + > + /tmp/guest_acpi_esrt > + 8 > + function='0x0'/> > + > + > + > diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c > index cc984440ea..68d1127cf4 100644 > --- a/tests/qemuxmlconftest.c > +++ b/tests/qemuxmlconftest.c > @@ -2949,6 +2949,7 @@ mymain(void) > DO_TEST_CAPS_LATEST("mtp-usb-device") > DO_TEST_CAPS_LATEST("net-usb") > DO_TEST_CAPS_LATEST("sound-device-virtio") > +DO_TEST_CAPS_LATEST("pstore-acpi-erst") > > DO_TEST_CAPS_LATEST_FAILURE("disk-network-iscsi-zero-hosts-invalid") > DO_TEST_CAPS_LATEST_PARSE_ERROR("hostdev-scsi-vhost-rawio-invalid") > -- > 2.44.2 > Reviewed-by: Kristina Hanicova Kristina

[PATCH] qemu_hotplug: Do not allow absent values in rom settings

should not accept an interface without elements that cannot be changed. Therefore, we should not allow absent values for already existing rom setting during hotplug. Resolves: https://issues.redhat.com/browse/RHEL-7109 Signed-off-by: Kristina Hanicova --- src/qemu/qemu_hotplug.c | 6 -- 1

Re: [PATCH] hyperv: prevent potential NULL dereference

On Fri, May 3, 2024 at 11:43 AM Oleg Sviridov wrote: > Return value of a function 'virDomainChrDefNew' is dereferenced > at hyperv_driver.c without checking for NULL, which can lead to > NULL dereference immediatly after. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > S

[PATCH] NEWS: document qemu: ras as a new feature

Signed-off-by: Kristina Hanicova --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 5a771b4b2f..d72c15bf10 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,11 @@ v10.4.0 (unreleased) * **New features** + * qemu: Support for ras feature for virt

[PATCH v2 4/4] qemu: format machine virt ras feature and test it

Resolves: https://issues.redhat.com/browse/RHEL-7489 Signed-off-by: Kristina Hanicova --- src/qemu/qemu_command.c | 5 +++ .../aarch64-features-ras.aarch64-latest.args | 31 +++ .../aarch64-features-ras.aarch64-latest.xml | 1 + .../qemuxmlconfdata

[PATCH v2 3/4] qemu: validate machine virt ras feature

Signed-off-by: Kristina Hanicova --- src/qemu/qemu_validate.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index b33618b494..d4ac721c06 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -69,6 +69,7

[PATCH v2 1/4] qemu: introduce QEMU_CAPS_MACHINE_VIRT_RAS capability

The capability can be used to detect if the qemu binary already supports 'ras' feature for 'virt' machine type. Signed-off-by: Kristina Hanicova --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h

[PATCH v2 2/4] conf: parse and format machine virt ras feature

Signed-off-by: Kristina Hanicova --- docs/formatdomain.rst | 6 ++ src/conf/domain_conf.c| 6 +- src/conf/domain_conf.h| 1 + src/conf/schemas/domaincommon.rng | 5 + src/qemu/qemu_validate.c | 1 + 5 files changed, 18 insertions(+), 1

[PATCH v2 0/4] implement 'ras' feature support

) Kristina Hanicova (4): qemu: introduce QEMU_CAPS_MACHINE_VIRT_RAS capability conf: parse and format machine virt ras feature qemu: validate machine virt ras feature qemu: format machine virt ras feature and test it docs/formatdomain.rst | 6 src/conf

[PATCH 3/4] qemu: validate machine virt ras feature

Signed-off-by: Kristina Hanicova --- src/qemu/qemu_validate.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index b33618b494..c8bee6f23d 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -69,6 +69,7

[PATCH 4/4] qemu: format machine virt ras feature and test it

Resolves: https://issues.redhat.com/browse/RHEL-7489 Signed-off-by: Kristina Hanicova --- src/qemu/qemu_command.c | 5 +++ .../aarch64-features-ras.aarch64-latest.args | 31 +++ .../aarch64-features-ras.aarch64-latest.xml | 1 + .../qemuxmlconfdata

[PATCH 0/4] implement 'ras' feature support

*** BLURB HERE *** Kristina Hanicova (4): Introduce QEMU_CAPS_MACHINE_VIRT_RAS capability conf: parse and format machine virt ras feature qemu: validate machine virt ras feature qemu: format machine virt ras feature and test it docs/formatdomain.rst | 5 +++ src

[PATCH 1/4] Introduce QEMU_CAPS_MACHINE_VIRT_RAS capability

The capability can be used to detect if the qemu binary already supports 'ras' feature for 'virt' machine type. Signed-off-by: Kristina Hanicova --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h

[PATCH 2/4] conf: parse and format machine virt ras feature

Signed-off-by: Kristina Hanicova --- docs/formatdomain.rst | 5 + src/conf/domain_conf.c| 6 +- src/conf/domain_conf.h| 1 + src/conf/schemas/domaincommon.rng | 5 + src/qemu/qemu_validate.c | 1 + 5 files changed, 17 insertions(+), 1

Re: [PATCH] virsysinfo: Try reading DMI table

Loongson-3 processors also have SMBIOS. > > [1] > https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.7.0.pdf > > Signed-off-by: Brett Holman > --- > src/util/virsysinfo.c | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Kristina Hanicova _

Re: [PATCH] virsysinfo: Try reading DMI table

Hello, On Mon, Mar 18, 2024 at 11:30 PM wrote: > From: Brett Holman > > The SMBIOS specification[1] includes RISC-V and mips, and some systems have > SMBIOS info. Attempt to read dmidecode and fall back to old behavior if > that > fails. > > [1] > https://www.dmtf.org/sites/default/files/standa