Re: [PATCH v3 3/5] schema: add TPM emulator

2024-10-11 Thread Marc-André Lureau
Hi On Fri, Oct 11, 2024 at 6:17 PM Stefan Berger wrote: > > > > On 10/11/24 10:10 AM, Marc-André Lureau wrote: > > Hi > > > > On Fri, Oct 11, 2024 at 5:49 PM Stefan Berger wrote: > >> > >> > >> > >> On 10/4/24 9:32 AM

Re: [PATCH v3 3/5] schema: add TPM emulator

2024-10-11 Thread Marc-André Lureau
Hi On Fri, Oct 11, 2024 at 5:49 PM Stefan Berger wrote: > > > > On 10/4/24 9:32 AM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Learn to parse a file path for the TPM state. > > > > Signed-off-by: Marc-André L

Re: [PATCH v2] chardev: introduce 'reconnect-ms' and deprecate 'reconnect'

2024-10-10 Thread Marc-André Lureau
e thing. > > > > Reviewed-by: Vladimir Sementsov-Ogievskiy > > Acked-by: Peter Krempa > > Signed-off-by: Daniil Tatianin > > -- > Best regards, > Vladimir > > > -- Marc-André Lureau

Re: [PATCH v2 3/4] schema: add TPM emulator

2024-10-03 Thread Marc-André Lureau
Hi Martin, Daniel On Wed, Oct 2, 2024 at 6:01 PM Martin Kletzander wrote: > > On Wed, Oct 02, 2024 at 03:43:22PM +0400, Marc-André Lureau wrote: > >Hi > > > >On Wed, Oct 2, 2024 at 11:34 AM Martin Kletzander > >wrote: > >> > >> On Wed, Oct 02, 2

Re: [PATCH v2 3/4] schema: add TPM emulator

2024-10-02 Thread Marc-André Lureau
Hi On Wed, Oct 2, 2024 at 11:34 AM Martin Kletzander wrote: > > On Wed, Oct 02, 2024 at 11:30:39AM +0400, Marc-André Lureau wrote: > >Hi > > > >On Wed, Oct 2, 2024 at 11:19 AM Martin Kletzander > >wrote: > >> > >> On Tue, Sep 10, 2024

Re: [PATCH v2 3/4] schema: add TPM emulator

2024-10-02 Thread Marc-André Lureau
Hi On Wed, Oct 2, 2024 at 11:19 AM Martin Kletzander wrote: > > On Tue, Sep 10, 2024 at 11:05:59AM +0400, marcandre.lur...@redhat.com wrote: > >From: Marc-André Lureau > > > >Learn to parse a directory for the TPM state. > > > >Signed-off-by: Marc-André Lure

Re: [PATCH v2 2/4] schema: add TPM emulator

2024-10-02 Thread Marc-André Lureau
On Wed, Oct 2, 2024 at 11:18 AM Martin Kletzander wrote: > > On Tue, Sep 10, 2024 at 11:05:58AM +0400, marcandre.lur...@redhat.com wrote: > >From: Marc-André Lureau > > > >Learn to parse a file path for the TPM state. > > > >Signed-off-by: Marc-André Lure

Re: [PATCH v2 1/4] util: check swtpm nvram-backend-dir capability

2024-10-02 Thread Marc-André Lureau
Hi On Wed, Oct 2, 2024 at 11:01 AM Martin Kletzander wrote: > > On Tue, Sep 10, 2024 at 11:05:57AM +0400, marcandre.lur...@redhat.com wrote: > >From: Marc-André Lureau > > > >Signed-off-by: Marc-André Lureau > >--- > > src/util/virtpm.c | 1 + > > src/

Re: [RFC PATCH v2 8/8] qemu: Extend swtpm_setup command line to set a profile by its name

2024-09-30 Thread Marc-André Lureau
Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau > --- > src/qemu/qemu_tpm.c | 36 > 1 file changed, 36 insertions(+) > > diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c > index e8e7e8b5c1..48446cd631 100644 > --- a/src

Re: [RFC PATCH v2 0/8] swtpm: Add support for profiles

2024-09-30 Thread Marc-André Lureau
Hi On Thu, Sep 26, 2024 at 11:32 PM Stefan Berger wrote: > > Upcoming libtpms v0.10 and swtpm v0.10 will have TPM profile support that > allows to restrict a TPM's provided set of crypto algorithms and commands > and through which backwards compatibility and migration from newer versions > of lib

Re: [RFC PATCH v2 3/8] util: Add parsing support for swtpm_setup's cmdarg-profile capability

2024-09-30 Thread Marc-André Lureau
On Thu, Sep 26, 2024 at 11:32 PM Stefan Berger wrote: > > Add support for parsing swtpm_setup 'cmdarg-profile' capability > (since v0.10). > > Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau > --- > src/util/virtpm.c | 1 + > sr

Re: [RFC PATCH v2 1/8] conf: Move TPM emulator parameters into own struct

2024-09-30 Thread Marc-André Lureau
On Thu, Sep 26, 2024 at 11:38 PM Stefan Berger wrote: > > To avoid passing TPM emulator parameters around individually, move them > into a structure and pass around the structure. > > Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau > --- > src/con

Re: [RFC PATCH v2 4/8] conf: Define enum virDomainTPMProfileRemoveDisabled

2024-09-30 Thread Marc-André Lureau
On Thu, Sep 26, 2024 at 11:32 PM Stefan Berger wrote: > > Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau > --- > src/conf/domain_conf.c | 7 +++ > src/conf/domain_conf.h | 9 + > 2 files changed, 16 insertions(+) > > diff --git a/src/conf/

Re: [RFC PATCH v2 2/8] qemu: Pass virQEMUDriverConfig rather than some of its fields

2024-09-30 Thread Marc-André Lureau
On Thu, Sep 26, 2024 at 11:32 PM Stefan Berger wrote: > > Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau > --- > src/qemu/qemu_tpm.c | 47 + > 1 file changed, 18 insertions(+), 29 deletions(-) > > diff --git a/src/

Re: [PATCH v2 4/4] qemu_tpm: handle file/block storage source

2024-09-22 Thread Marc-André Lureau
Hi On Fri, Sep 13, 2024 at 5:14 PM Stefan Berger wrote: > > > > On 9/10/24 3:06 AM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > When swtpm reports "nvram-backend-dir", it can accepts a single file or > > s/accepts/acc

Re: [RFC PATCH v1 5/6] docs: Add documentation for the TPM backend profile node

2024-09-20 Thread Marc-André Lureau
Hi Stefan On Thu, Sep 19, 2024 at 9:00 PM Stefan Berger wrote: > > Add documentation for the TPM backend profile node and point the reader to > further documentation about TPM profiles available in the swtpm and > TPMLIB_SetProfile man pages. > > Signed-off-by: Stefan Berger > --- > docs/format

Re: [RFC PATCH v1 1/6] util: Add parsing support for swtpm_setup's cmdarg-profile capability

2024-09-20 Thread Marc-André Lureau
On Thu, Sep 19, 2024 at 9:00 PM Stefan Berger wrote: > > Add support for parsing swtpm_setup 'cmdarg-profile' capability > (since v0.10). > > Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau > --- > src/util/virtpm.c | 1 + > sr

Re: [RFC PATCH v1 3/6] schema: Extend schema for TPM emulator profile node

2024-09-20 Thread Marc-André Lureau
Hi On Thu, Sep 19, 2024 at 10:05 PM Stefan Berger wrote: > > Extend the schema for the TPM emulator profile node. Require that > the profile the user provides looks like a JSON map that at least > starts with '{' and ends with '}'. > > Signed-off-by: Stefan Berger > --- > src/conf/schemas/basic

Re: [RFC PATCH v1 2/6] conf: Define enum virDomainTPMProfileRemoveDisabled

2024-09-20 Thread Marc-André Lureau
On Thu, Sep 19, 2024 at 9:01 PM Stefan Berger wrote: > > Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau > --- > src/conf/domain_conf.c | 7 +++ > src/conf/domain_conf.h | 9 + > 2 files changed, 16 insertions(+) > > diff --git a/src/conf/

Re: [PATCH 1/4] chardev/parallel: Don't close stdin on inappropriate device

2024-02-13 Thread Marc-André Lureau
Hi On Tue, Feb 13, 2024 at 5:58 PM Markus Armbruster wrote: > > Markus Armbruster writes: > > > The __linux__ version of qemu_chr_open_pp_fd() tries to claim the > > parport device with a PPCLAIM ioctl(). On success, it stores the file > > descriptor in the chardev object, and returns success.

Re: [PATCH 0/4] char: Minor fixes, and a tighter QAPI schema

2024-02-03 Thread Marc-André Lureau
tional > qapi/char: Deprecate backend type "memory" Reviewed-by: Marc-André Lureau > > docs/about/deprecated.rst | 8 > qapi/char.json| 28 +--- > include/qemu/osdep.h | 9 - > chardev/char-parallel.c