Re: [PATCH 20/31] qemu: Always default to no USB controller on s390x

2025-08-20 Thread Thomas Huth via Devel
-address.s390x-latest.xml | 6 +- 9 files changed, 18 insertions(+), 38 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 21/31] qemu: Drop skip for USB controllers on s390x

2025-08-20 Thread Thomas Huth via Devel
ONTROLLER_MODEL_USB_DEFAULT) -continue; } if (qemuBuildControllerDevProps(def, cont, qemuCaps, &props) < 0) Reviewed-by: Thomas Huth

Re: [PATCH v5 0/5] Disable Deprecated Features by Default on s390 CPU Models

2025-07-24 Thread Thomas Huth via Devel
es sounds reasonable to me, so FWIW: Series Acked-by: Thomas Huth Peter, Michal, could we still get this merged for libvirt 11.6 ? Thomas

Re: [RFC PATCH 6/6] docs/about: deprecate add sparc/sparc32plus-*-user

2025-07-16 Thread Thomas Huth via Devel
te binaries that can currently be run. I think it's fair to deprecate it in this case. If someone wants to maintain it, they can come up with patches and we can revert this patch. Otherwise it's only dead code anyway. Reviewed-by: Thomas Huth

Re: [PATCH v3 2/5] include/hw/boards: cope with dev/rc versions in deprecation checks

2025-05-08 Thread Thomas Huth via Devel
On 06/05/2025 18.00, Daniel P. Berrangé wrote: When VERSION is set to a development snapshot (micro >= 50), or a release candidate (micro >= 90) we have an off-by-1 in determining deprecation and deletion thresholds for versioned machine types. In such cases we need to use the next major/minor ve

Re: [PATCH v3 0/5] docs: automated info about machine deprecation/removal info

2025-05-06 Thread Thomas Huth via Devel
nd removal thresholds - they must predict the next formal release version number. The following three patches deal with the docs stuff. Series Reviewed-by: Thomas Huth

Re: [PATCH v2 4/5] docs/about/removed-features: auto-generate a note for versioned machine types

2025-04-30 Thread Thomas Huth via Devel
On 29/04/2025 15.15, Daniel P. Berrangé wrote: We remove versioned machine types on a fixed schedule. This allows us to auto-generate a paragraph in the removed-features.rst document that always has accurate version info. Signed-off-by: Daniel P. Berrangé --- docs/about/removed-features.rst |

Re: [RFC PATCH 0/3] single-binary: make QAPI generated files common

2025-04-29 Thread Thomas Huth via Devel
On 29/04/2025 21.48, Pierrick Bouvier wrote: ... I'm not keen to have a default target set, but it's a personal opinion based on fear of "implicit smart choice hurts", so I'll be happy to change my mind with a good argument for it. No default target, please! We've seen this with the default ma

Re: [PATCH v2 3/5] docs/about/deprecated: auto-generate a note for versioned machine types

2025-04-29 Thread Thomas Huth via Devel
+++ docs/conf.py | 33 - 2 files changed, 39 insertions(+), 1 deletion(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 2/5] include/hw/boards: cope with dev/rc versions in deprecation checks

2025-04-29 Thread Thomas Huth via Devel
ding our current release policy of 3 releases per year, with a major bump at the start of each year, and that dev/rc versions have micro >= 50. Signed-off-by: Daniel P. Berrangé --- include/hw/boards.h | 33 - 1 file changed, 32 insertions(+), 1 deletion(-)

Re: [PATCH v2 1/5] Revert "include/hw: temporarily disable deletion of versioned machine types"

2025-04-29 Thread Thomas Huth via Devel
ould re-activate the dead machines in case a certain environment variable (QEMU_ZOMBI_MACHINES) is set? Anyway, just an idea, not sure whether it's a good one. So for this patch: Reviewed-by: Thomas Huth } \ } while (0)

Re: [RFC PATCH 0/3] single-binary: make QAPI generated files common

2025-04-29 Thread Thomas Huth via Devel
On 29/04/2025 10.23, Markus Armbruster wrote: ... I don't wish to derail this thread, but we've been dancing around the question of how to best fix the target for some time. I think we should talk about it for real. Mind, this is not an objection to your larger "single binary" idea. It could b

Re: [PATCH] docs: Fix some types

2025-03-17 Thread Thomas Huth via Devel
On 17/03/2025 12.29, Martin Kletzander wrote: On Mon, Mar 17, 2025 at 11:41:20AM +0100, Thomas Huth via Devel wrote: From: Thomas Huth Found with the codespell utility. If you did that typo in the subject on purpose, then hat's off to you. Anyway, before pushing it, s/types/typos/ p

[PATCH] docs: Fix some types

2025-03-17 Thread Thomas Huth via Devel
From: Thomas Huth Found with the codespell utility. Signed-off-by: Thomas Huth --- docs/formatcaps.rst| 2 +- docs/formatdomain.rst | 4 ++-- docs/glib-adoption.rst | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/formatcaps.rst b/docs/formatcaps.rst index

Re: [PATCH 0/4] hw/s390x: Alias @dump-skeys -> @dump-s390-skey and deprecate

2025-03-10 Thread Thomas Huth
On 09/03/2025 19.55, Pierrick Bouvier wrote: On 6/3/24 05:18, Daniel P. Berrangé wrote: On Fri, May 31, 2024 at 06:47:45AM +0200, Thomas Huth wrote: On 30/05/2024 09.45, Philippe Mathieu-Daudé wrote: We are trying to unify all qemu-system-FOO to a single binary. In order to do that we need to

Re: [PATCH 0/3] Remove deprecated machines pc-i440fx-2.4 up to pc-i440fx-2.12

2025-01-17 Thread Thomas Huth
On 17/01/2025 12.07, Daniel P. Berrangé wrote: On Fri, Jan 17, 2025 at 11:27:35AM +0100, Thomas Huth wrote: While our new auto-disablement of old machine types will only kick in with the next (v10.1) release, the pc-i440fx-2.* machine types have been explicitly marked as deprecated via our old

[PATCH 2/3] hw/i386/pc_piix: Remove pc-i440fx-2.4 up to pc-i440fx-2.12

2025-01-17 Thread Thomas Huth
These machines have explicitly been marked as deprecated in QEMU 9.1, so it should be fine to remove these antique versioned machine types two releases later in 10.0. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 7 --- docs/about/removed-features.rst | 4 +- docs/interop

[PATCH 3/3] tests/qtest/test-x86-cpuid-compat: Replaced the removed pc-i440fx-2.* machines

2025-01-17 Thread Thomas Huth
Since the pc-i440fx-2.* machine types have been removed, let's run the tests with the corresponding q35 machine types instead (until those get removed, too, then we have to remove the tests completely). Signed-off-by: Thomas Huth --- tests/qtest/test-x86-cpuid-compat.c

[PATCH 1/3] tests/qtest/test-x86-cpuid-compat: Remove tests related to pc-i440fx-2.3

2025-01-17 Thread Thomas Huth
The pc-i440fx-2.3 machine type has been removed in commit 46a2bd5257 ("hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine") already, so these tests are just dead code by now. Signed-off-by: Thomas Huth --- tests/qtest/test-x86-cpuid-compat.c | 18 -- 1 file c

[PATCH 0/3] Remove deprecated machines pc-i440fx-2.4 up to pc-i440fx-2.12

2025-01-17 Thread Thomas Huth
will still have at least a small benefit of accelerating our CI a little bit (since we don't have to run tests for these old machine types anymore). Thomas Huth (3): tests/qtest/test-x86-cpuid-compat: Remove tests related to pc-i440fx-2.3 hw/i386/pc_piix: Remove pc-i440fx-2.4 up

Re: [PATCH v2 1/2] qemuxmlconftest: Drop s390-default-cpu-...ccw-virtio-2.7 test cases

2025-01-16 Thread Thomas Huth
On 16/01/2025 12.25, Michal Privoznik wrote: In its upstream commit [1], qemu dropped s390-2.7 machine type, then in commit [2] the s390-2.8 machine type was dropped. But as Thomas Huth pointed out, any machine type that's older than 6 years is subject to removal [3]. This means, any ma

Re: [PATCH 0/4] Implement virsh hypervisor-cpu-models

2025-01-15 Thread Thomas Huth
On 15/01/2025 11.43, Daniel P. Berrangé wrote: On Wed, Jan 15, 2025 at 11:34:05AM +0100, Boris Fiuczynski wrote: Allows for the query of hypervisor-known CPU models via the simple command: virsh hypervisor-cpu-models. For the QEMU driver, the models are queried via the capabilities file. Each mo

Re: [PATCH 1/2] qemuxmlconftest: Switch s390-default-cpu-...-virtio-2.7 to virtio-2.9

2025-01-15 Thread Thomas Huth
On 14/01/2025 14.07, Michal Privoznik wrote: In its upstream commit [1], qemu dropped s390-2.7 machine type, then in commit [2] the s390-2.8 machine type was dropped. Therefore, switch both tests to s390-2.9 which is still available (though deprecated). I already posted some patches to remove 2

[PATCH] Remove the deprecated "-runas" command line option

2025-01-03 Thread Thomas Huth
It has been marked as deprecated two releases ago, so it should be fine now to remove this command line option. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 6 -- docs/about/removed-features.rst | 6 ++ system/vl.c | 9 - qemu

Re: [PATCH v3 15/17] hw/microblaze: Support various endianness for s3adsp1800 machines

2024-11-11 Thread Thomas Huth
On 11/11/2024 12.59, Philippe Mathieu-Daudé wrote: On 11/11/24 07:56, Thomas Huth wrote: On 08/11/2024 16.43, Philippe Mathieu-Daudé wrote: Introduce an abstract machine parent class which defines the 'little_endian' property. Duplicate the current machine, which endian is tied to

Re: [PATCH v3 17/17] tests/functional: Add microblaze cross-endianness tests

2024-11-10 Thread Thomas Huth
On 08/11/2024 16.43, Philippe Mathieu-Daudé wrote: Copy/paste the current tests, but call the opposite endianness machines, testing: - petalogix-s3adsp1800-le machine (little-endian CPU) on the qemu-system-microblaze binary (big-endian) - petalogix-s3adsp1800-be machine (big-endian CPU) on the

Re: [PATCH v3 15/17] hw/microblaze: Support various endianness for s3adsp1800 machines

2024-11-10 Thread Thomas Huth
On 08/11/2024 16.43, Philippe Mathieu-Daudé wrote: Introduce an abstract machine parent class which defines the 'little_endian' property. Duplicate the current machine, which endian is tied to the binary endianness, to one big endian and a little endian machine; updating the machine description.

Re: [PATCH v3 16/17] tests/functional: Explicit endianness of microblaze assets

2024-11-10 Thread Thomas Huth
+++--- 2 files changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 11/20] MAINTAINERS: mention my gdbstub/next tree

2024-10-22 Thread Thomas Huth
On 22/10/2024 12.56, Alex Bennée wrote: Make it easy for people to see what is already queued. Signed-off-by: Alex Bennée --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Thomas Huth

Re: [PATCH v2 03/20] MAINTAINERS: mention my testing/next tree

2024-10-22 Thread Thomas Huth
On 22/10/2024 12.55, Alex Bennée wrote: I put it under my name as there may be other maintainer testing trees as well. Signed-off-by: Alex Bennée --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Thomas Huth

Re: [PATCH v2 10/20] gitlab: make check-[dco|patch] a little more verbose

2024-10-22 Thread Thomas Huth
+ 2 files changed, 10 insertions(+), 8 deletions(-) Reviewed-by: Thomas Huth

[PATCH v3] docs: Mark "gluster" support in QEMU as deprecated

2024-10-02 Thread Thomas Huth
gned-off-by: Thomas Huth --- v3: Some rewordings according to Markus' and Daniel's suggestions docs/about/deprecated.rst | 9 + qapi/block-core.json | 8 +++- block/gluster.c | 2 ++ 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/docs/about/de

[PATCH v2] docs: Mark "gluster" support in QEMU as deprecated

2024-09-25 Thread Thomas Huth
According to https://marc.info/?l=fedora-devel-list&m=171934833215726 the GlusterFS development effectively ended. Thus mark it as deprecated in QEMU, so we can remove it in a future release if the project does not gain momentum again. Acked-by: Niels de Vos Signed-off-by: Thomas Huth ---

Re: [PATCH] docs: Mark "gluster" support in QEMU as deprecated

2024-09-24 Thread Thomas Huth
On 24/09/2024 16.12, Peter Krempa wrote: On Tue, Sep 24, 2024 at 15:24:51 +0200, Thomas Huth wrote: According to https://marc.info/?l=fedora-devel-list&m=171934833215726 the GlusterFS development effectively ended. Thus mark it as deprecated in QEMU, so we can remove it in a future releas

[PATCH] docs: Mark "gluster" support in QEMU as deprecated

2024-09-24 Thread Thomas Huth
According to https://marc.info/?l=fedora-devel-list&m=171934833215726 the GlusterFS development effectively ended. Thus mark it as deprecated in QEMU, so we can remove it in a future release if the project does not gain momentum again. Signed-off-by: Thomas Huth --- docs/about/deprecated

Re: [PATCH v2 12/18] tests/tcg: ensure s390x-softmmu output redirected

2024-09-17 Thread Thomas Huth
On 16/09/2024 10.53, Alex Bennée wrote: The multiarch system tests output serial data which should be redirected to the "output" chardev rather than echoed to the console. Comment the use of EXTFLAGS variable while we are at it. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth

Re: [PATCH 12/17] tests/tcg: ensure s390x-softmmu output redirected

2024-09-15 Thread Thomas Huth
On 13/09/2024 19.26, Alex Bennée wrote: The multiarch system tests output serial data which should be redirected to the "output" chardev rather than echoed to the console. Remove the unused EXTFLAGS variable while we are at it. Signed-off-by: Alex Bennée --- tests/tcg/s390x/Makefile.softmmu-

Re: [PATCH v2 15/15] seccomp: Remove check for CRIS host

2024-09-04 Thread Thomas Huth
#define CLONE_FLAGS_ARG 1 #else #define CLONE_FLAGS_ARG 0 Reviewed-by: Thomas Huth

Re: [PATCH v2 14/15] disas: Remove CRIS disassembler

2024-09-04 Thread Thomas Huth
|1 - disas/cris.c| 2863 --- disas/meson.build |1 - 6 files changed, 2877 deletions(-) delete mode 100644 disas/cris.c Reviewed-by: Thomas Huth

Re: [PATCH v2 13/15] target/cris: Remove the deprecated CRIS target

2024-09-04 Thread Thomas Huth
arget/cris/meson.build | 17 - target/meson.build |1 - tests/data/qobject/qdict.txt|6 - 29 files changed, 9 insertions(+), 7306 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 12/15] system: Remove support for CRIS target

2024-09-04 Thread Thomas Huth
is-softmmu/default.mak delete mode 100644 configs/targets/cris-softmmu.mak Reviewed-by: Thomas Huth

Re: [PATCH v2 11/15] hw/timer: Remove TYPE_ETRAX_FS_TIMER device

2024-09-04 Thread Thomas Huth
Reviewed-by: Thomas Huth

Re: [PATCH v2 10/15] hw/dma: Remove ETRAX_FS DMA device

2024-09-04 Thread Thomas Huth
Reviewed-by: Thomas Huth

Re: [PATCH v2 09/15] hw/net: Remove TYPE_ETRAX_FS_ETH device

2024-09-04 Thread Thomas Huth
- hw/net/trace-events | 5 - 4 files changed, 730 deletions(-) delete mode 100644 include/hw/cris/etraxfs.h delete mode 100644 hw/net/etraxfs_eth.c Reviewed-by: Thomas Huth

Re: [PATCH v2 08/15] hw/char: Remove TYPE_ETRAX_FS_SERIAL device

2024-09-04 Thread Thomas Huth
| 1 - 3 files changed, 286 deletions(-) delete mode 100644 hw/char/etraxfs_ser.c Reviewed-by: Thomas Huth

Re: [PATCH v2 07/15] hw/intc: Remove TYPE_ETRAX_FS_PIC device

2024-09-04 Thread Thomas Huth
(-) delete mode 100644 hw/intc/etraxfs_pic.c Reviewed-by: Thomas Huth

Re: [PATCH v2 06/15] hw/cris: Remove image loader helper

2024-09-04 Thread Thomas Huth
/meson.build | 1 - 4 files changed, 123 deletions(-) delete mode 100644 hw/cris/boot.h delete mode 100644 hw/cris/boot.c delete mode 100644 hw/cris/meson.build Reviewed-by: Thomas Huth

Re: [PATCH v2 05/15] hw/cris: Remove the axis-dev88 machine

2024-09-04 Thread Thomas Huth
eviewed-by: Thomas Huth

Re: [PATCH v2 01/15] tests/tcg: Remove CRIS libc test files

2024-09-04 Thread Thomas Huth
On 04/09/2024 16.35, Philippe Mathieu-Daudé wrote: We never compiled / ran these tests. Signed-off-by: Philippe Mathieu-Daudé --- Reviewed-by: Thomas Huth

Re: [PATCH v2 04/15] linux-user: Remove support for CRIS target

2024-09-04 Thread Thomas Huth
testing situation there is a chance the code will bitrot without anyone noticing. Signed-off-by: Philippe Mathieu-Daudé --- Reviewed-by: Thomas Huth

Re: [PATCH v2 03/15] buildsys: Remove CRIS cross container

2024-09-04 Thread Thomas Huth
/docker/Makefile.include | 1 - tests/docker/dockerfiles/fedora-cris-cross.docker | 14 -- 4 files changed, 24 deletions(-) delete mode 100644 tests/docker/dockerfiles/fedora-cris-cross.docker Reviewed-by: Thomas Huth

Re: [PATCH v2 02/15] tests/tcg: Remove CRIS bare test files

2024-09-04 Thread Thomas Huth
-- tests/tcg/cris/bare/testutils.inc | 117 75 files changed, 5618 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-26 Thread Thomas Huth
On 26/07/2024 09.25, Michael S. Tsirkin wrote: On Fri, Jul 26, 2024 at 09:03:24AM +0200, Thomas Huth wrote: On 26/07/2024 08.08, Michael S. Tsirkin wrote: On Thu, Jul 25, 2024 at 06:18:20PM -0400, Peter Xu wrote: On Tue, Aug 01, 2023 at 01:31:48AM +0300, Yuri Benditovich wrote: USO features

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-26 Thread Thomas Huth
On 26/07/2024 08.08, Michael S. Tsirkin wrote: On Thu, Jul 25, 2024 at 06:18:20PM -0400, Peter Xu wrote: On Tue, Aug 01, 2023 at 01:31:48AM +0300, Yuri Benditovich wrote: USO features of virtio-net device depend on kernel ability to support them, for backward compatibility by default the featur

Re: [PATCH v2 07/14] hw/i386: convert 'q35' machine definitions to use new macros

2024-07-01 Thread Thomas Huth
- hw/i386/pc_q35.c | 215 --- 1 file changed, 90 insertions(+), 125 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 06/14] hw/i386: convert 'i440fx' machine definitions to use new macros

2024-07-01 Thread Thomas Huth
thrice in three different formats in the calls to DEFINE_I440FX_MACHINE. Signed-off-by: Daniel P. Berrangé --- hw/i386/pc_piix.c| 219 +++ include/hw/i386/pc.h | 26 + 2 files changed, 122 insertions(+), 123 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v3 15/17] tests/qtest: Disable npcm7xx_sdhci tests using hardcoded RCA

2024-06-27 Thread Thomas Huth
On 27/06/2024 18.22, Philippe Mathieu-Daudé wrote: Disable tests using 0x4567 hardcoded RCA otherwise when using random RCA we get: ERROR:../../tests/qtest/npcm7xx_sdhci-test.c:69:write_sdread: assertion failed: (ret == len) not ok /arm/npcm7xx_sdhci/read_sd - ERROR:../../tests/qtest/npc

Re: [PATCH v2 09/14] include/hw: temporarily disable deletion of versioned machine types

2024-06-20 Thread Thomas Huth
rn; \ +} \ } \ } while (0) Reviewed-by: Thomas Huth

Re: [PATCH 0/4] hw/s390x: Alias @dump-skeys -> @dump-s390-skey and deprecate

2024-05-31 Thread Thomas Huth
On 31/05/2024 16.02, Dr. David Alan Gilbert wrote: * Thomas Huth (th...@redhat.com) wrote: On 30/05/2024 09.45, Philippe Mathieu-Daudé wrote: We are trying to unify all qemu-system-FOO to a single binary. In order to do that we need to remove QAPI target specific code. @dump-skeys is only

Re: [PATCH 4/4] hw/s390x: Deprecate the QMP @dump-skeys command

2024-05-30 Thread Thomas Huth
On 30/05/2024 09.45, Philippe Mathieu-Daudé wrote: Prefer @dump-s390-skeys which is target agnostic. Signed-off-by: Philippe Mathieu-Daudé --- docs/about/deprecated.rst | 5 + qapi/misc-target.json | 5 + 2 files changed, 10 insertions(+) diff --git a/docs/about/deprecated.rst

Re: [PATCH 0/4] hw/s390x: Alias @dump-skeys -> @dump-s390-skey and deprecate

2024-05-30 Thread Thomas Huth
On 30/05/2024 09.45, Philippe Mathieu-Daudé wrote: We are trying to unify all qemu-system-FOO to a single binary. In order to do that we need to remove QAPI target specific code. @dump-skeys is only available on qemu-system-s390x. This series rename it as @dump-s390-skey, making it available on

Re: [PATCH v2] qemu-options: Deprecate "-runas" and introduce "-run-with user=..." instead

2024-05-08 Thread Thomas Huth
On 08/05/2024 15.20, Claudio Fontana wrote: On 5/6/24 13:20, Thomas Huth wrote: The old "-runas" option has the disadvantage that it is not visible in the QAPI schema, so it is not available via the normal introspection mechanisms. We've recently introduced the "-run-with

[PATCH v2] qemu-options: Deprecate "-runas" and introduce "-run-with user=..." instead

2024-05-06 Thread Thomas Huth
fect the runtime behavior. Thus let's introduce a "user=..." parameter here now and deprecate the old "-runas" option. Signed-off-by: Thomas Huth --- v2: Add missing part in qemu-options.hx as suggested by Philippe docs/about/deprecated.rst | 6 ++ system/vl.c

Re: [PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Thomas Huth
On 30/04/2024 11.55, Daniel P. Berrangé wrote: On Tue, Apr 30, 2024 at 08:45:29AM +0200, Thomas Huth wrote: Old machine types often have bugs or work-arounds that affect our possibilities to move forward with the QEMU code base (see for example https://gitlab.com/qemu-project/qemu/-/issues/2213

Re: [PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Thomas Huth
On 30/04/2024 11.40, Philippe Mathieu-Daudé wrote: Hi Thomas, On 30/4/24 08:45, Thomas Huth wrote: Old machine types often have bugs or work-arounds that affect our possibilities to move forward with the QEMU code base (see for example https://gitlab.com/qemu-project/qemu/-/issues/2213 for a

[PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-29 Thread Thomas Huth
ed as deprecated automatically. Six years should be sufficient to support the release cycles of most Linux distributions. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst

Re: [PATCH v3 01/22] hw/i386/pc: Deprecate 2.4 to 2.7 pc-i440fx machines

2024-04-16 Thread Thomas Huth
On 16/04/2024 16.49, Philippe Mathieu-Daudé wrote: On 16/4/24 16:23, Thomas Huth wrote: On 16/04/2024 15.52, Philippe Mathieu-Daudé wrote: Similarly to the commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated", deprecate the 2.4 to 2.

Re: [PATCH v3 01/22] hw/i386/pc: Deprecate 2.4 to 2.7 pc-i440fx machines

2024-04-16 Thread Thomas Huth
On 16/04/2024 15.52, Philippe Mathieu-Daudé wrote: Similarly to the commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated", deprecate the 2.4 to 2.7 machines. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- docs/about/depr

Re: [PATCH-for-9.1 v2 3/3] block/gluster: Remove RDMA protocol handling

2024-03-28 Thread Thomas Huth
docs/system/qemu-block-drivers.rst.inc | 1 - block/gluster.c| 39 -- 3 files changed, 2 insertions(+), 42 deletions(-) Reviewed-by: Thomas Huth ___ Devel mailing list -- devel@lists.libvirt.org To uns

Re: [PATCH-for-9.1 v2 1/3] hw/rdma: Remove pvrdma device and rdmacm-mux helper

2024-03-28 Thread Thomas Huth
m-mux tool from contrib/ Cc: Yuval Shaia Cc: Marcel Apfelbaum Signed-off-by: Philippe Mathieu-Daudé --- Reviewed-by: Thomas Huth ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

Re: [PATCH-for-9.0 v2] hw/i386/pc: Deprecate 64-bit CPUs on ISA-only PC machine

2024-03-28 Thread Thomas Huth
On 28/03/2024 16.12, Mark Cave-Ayland wrote: On 27/03/2024 16:54, Philippe Mathieu-Daudé wrote: Per Daniel suggestion [*]:   > isapc could arguably be restricted to just 32-bit CPU models,   > because we should not need it to support any feature that didn't   > exist prior to circa 1995. eg re

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-03-28 Thread Thomas Huth
On 28/03/2024 16.01, Peter Xu wrote: On Thu, Mar 28, 2024 at 11:18:04AM -0300, Fabiano Rosas wrote: Philippe Mathieu-Daudé writes: The whole RDMA subsystem was deprecated in commit e9a54265f5 ("hw/rdma: Deprecate the pvrdma device and the rdma subsystem") released in v8.2. Remove: - RDMA h

Re: [PATCH-for-9.1] rdma: Remove RDMA subsystem and pvrdma device

2024-03-27 Thread Thomas Huth
On 27/03/2024 11.55, Philippe Mathieu-Daudé wrote: The whole RDMA subsystem was deprecated in commit e9a54265f5 ("hw/rdma: Deprecate the pvrdma device and the rdma subsystem") released in v8.2. Time to remove it. Keep the RAM_SAVE_FLAG_HOOK definition since it might appears in old migration stre

Re: [PATCH-for-9.0? v2 1/3] fpu/softfloat: Remove mention of TILE-Gx target

2024-03-27 Thread Thomas Huth
have floating-point. */ if (snan_bit_is_one(status)) { /* set all bits other than msb */ Reviewed-by: Thomas Huth ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

Re: [PATCH-for-9.1] target/nios2: Remove machines and system emulation

2024-03-27 Thread Thomas Huth
On 27/03/2024 15.15, Philippe Mathieu-Daudé wrote: On 27/3/24 14:19, Thomas Huth wrote: On 27/03/2024 13.45, Philippe Mathieu-Daudé wrote: On 27/3/24 13:35, Philippe Mathieu-Daudé wrote: Remove the Nios II machines and the system emulation code (deprecated since v8.2 in commit 9997771bc1

Re: [PATCH-for-9.1] target/nios2: Remove machines and system emulation

2024-03-27 Thread Thomas Huth
On 27/03/2024 13.45, Philippe Mathieu-Daudé wrote: On 27/3/24 13:35, Philippe Mathieu-Daudé wrote: Remove the Nios II machines and the system emulation code (deprecated since v8.2 in commit 9997771bc1 "target/nios2: Deprecate the Nios II architecture"). Please remind me, why didn't we deprecat

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Thomas Huth
On 27/03/2024 14.09, Igor Mammedov wrote: On Wed, 27 Mar 2024 10:49:43 + Daniel P. Berrangé wrote: On Tue, Mar 26, 2024 at 05:16:32PM +0100, Igor Mammedov wrote: On Tue, 26 Mar 2024 14:29:58 +0100 Philippe Mathieu-Daudé wrote: Hi Igor, On 26/3/24 14:08, Thomas Huth wrote: s

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-26 Thread Thomas Huth
On 26/03/2024 14.29, Philippe Mathieu-Daudé wrote: Hi Igor, On 26/3/24 14:08, Thomas Huth wrote: s/iaspc/isapc/ in the subject On 26/03/2024 13.51, Igor Mammedov wrote: ISAPC machine was introduced 25 years ago and it's a lot of time since such machine was around with real ISA on

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-26 Thread Thomas Huth
s/iaspc/isapc/ in the subject On 26/03/2024 13.51, Igor Mammedov wrote: ISAPC machine was introduced 25 years ago and it's a lot of time since such machine was around with real ISA only PC hardware practically defunct. Also it's slowly bit-rots (for example: I was able to boot RHEL6 on RHEL9 ho

Re: [PATCH 02/14] hw/core/machine-smp: Deprecate unsupported "parameter=1" SMP configurations

2024-03-06 Thread Thomas Huth
On 06/03/2024 10.53, Zhao Liu wrote: From: Zhao Liu Currentlt, it was allowed for users to specify the unsupported s/Currentlt/Currently/ topology parameter as "1". For example, x86 PC machine doesn't support drawer/book/cluster topology levels, but user could specify "-smp drawers=1,books=

Re: [PATCH-for-9.1 18/18] hw/i386/pc: Replace PCMachineClass::acpi_data_size by PC_ACPI_DATA_SIZE

2024-03-06 Thread Thomas Huth
/pc.c | 19 --- 2 files changed, 12 insertions(+), 11 deletions(-) Reviewed-by: Thomas Huth ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

Re: [PATCH-for-9.1 17/18] target/i386: Remove X86CPU::kvm_no_smi_migration field

2024-03-06 Thread Thomas Huth
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote: X86CPU::kvm_no_smi_migration was only used by the pc-i440fx-2.3 machine, which got removed. Remove it and simplify kvm_put_vcpu_events(). Signed-off-by: Philippe Mathieu-Daudé --- target/i386/cpu.h | 3 --- target/i386/cpu.c | 2 --

Re: [PATCH-for-9.1 12/18] hw/i386/pc: Remove deprecated pc-i440fx-2.2 machine

2024-03-06 Thread Thomas Huth
eviewed-by: Thomas Huth ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

Re: [PATCH-for-9.1 15/18] hw/i386/acpi: Remove AcpiBuildState::rsdp field

2024-03-06 Thread Thomas Huth
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote: AcpiBuildState::rsdp is always NULL, remove it, simplifying acpi_build_update(). Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/acpi-build.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH-for-9.1 14/18] hw/i386/pc: Remove PCMachineClass::rsdp_in_ram

2024-03-06 Thread Thomas Huth
-build.c | 35 --- hw/i386/pc.c | 1 - 3 files changed, 4 insertions(+), 33 deletions(-) Reviewed-by: Thomas Huth ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le

Re: [PATCH-for-9.1 13/18] hw/i386/pc: Remove PCMachineClass::resizable_acpi_blob

2024-03-06 Thread Thomas Huth
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote: PCMachineClass::resizable_acpi_blob was only used by the pc-i440fx-2.2 machine, which got removed. It is now always true. Remove it, simplifying acpi_build(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 3 --- hw/i386/ac

Re: [PATCH-for-9.1 06/18] hw/i386/pc: Remove deprecated pc-i440fx-2.1 machine

2024-03-06 Thread Thomas Huth
docs/about/deprecated.rst | 2 +- docs/about/removed-features.rst | 2 +- include/hw/i386/pc.h| 3 --- hw/i386/pc.c| 7 --- hw/i386/pc_piix.c | 23 --- 5 files changed, 2 insertions(+), 35 deletions(-) Reviewed-by: T

Re: [PATCH-for-9.1 11/18] hw/mem/memory-device: Remove legacy_align from memory_device_pre_plug()

2024-03-06 Thread Thomas Huth
| 12 hw/mem/pc-dimm.c | 2 +- hw/virtio/virtio-md-pci.c | 2 +- 5 files changed, 8 insertions(+), 13 deletions(-) Reviewed-by: Thomas Huth ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe sen

Re: [PATCH-for-9.1 10/18] hw/mem/pc-dimm: Remove legacy_align argument from pc_dimm_pre_plug()

2024-03-06 Thread Thomas Huth
/pc-dimm.c | 6 ++ hw/ppc/spapr.c | 2 +- 6 files changed, 7 insertions(+), 10 deletions(-) Reviewed-by: Thomas Huth ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

Re: [PATCH-for-9.1 09/18] hw/i386/pc: Remove PCMachineClass::enforce_aligned_dimm

2024-03-06 Thread Thomas Huth
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote: PCMachineClass::enforce_aligned_dimm was only used by the pc-i440fx-2.1 machine, which got removed. It is now always true. Remove it, simplifying pc_get_device_memory_range(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h |

Re: [PATCH-for-9.1 08/18] hw/i386/pc: Remove PCMachineClass::smbios_uuid_encoded

2024-03-06 Thread Thomas Huth
/pc.c | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Thomas Huth ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

Re: [PATCH-for-9.1 07/18] target/i386/kvm: Remove x86_cpu_change_kvm_default() and 'kvm-cpu.h'

2024-03-06 Thread Thomas Huth
now empty, remove it too. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/kvm/kvm-cpu.h | 41 --- target/i386/kvm/kvm-cpu.c | 3 +-- 2 files changed, 1 insertion(+), 43 deletions(-) delete mode 100644 target/i386/kvm/kvm-cpu.h Reviewed-by: T

Re: [PATCH-for-9.1 01/18] hw/i386/pc: Remove deprecated pc-i440fx-2.0 machine

2024-03-06 Thread Thomas Huth
--- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -311,21 +311,6 @@ GlobalProperty pc_compat_2_1[] = { }; const size_t pc_compat_2_1_len = G_N_ELEMENTS(pc_compat_2_1); -GlobalProperty pc_compat_2_0[] = { -PC_CPU_MODEL_IDS("2.0.0") -{ "virtio-scsi-pci", &qu

Re: [PATCH-for-9.1 05/18] hw/i386/acpi: Remove PCMachineClass::legacy_acpi_table_size

2024-03-06 Thread Thomas Huth
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote: PCMachineClass::legacy_acpi_table_size was only used by the pc-i440fx-2.0 machine, which got removed. Remove it and simplify acpi_build(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 1 - hw/i386/acpi-build.c | 60 +

Re: [PATCH-for-9.1 04/18] hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST flag

2024-03-06 Thread Thomas Huth
-- hw/usb/hcd-xhci-pci.c | 1 - hw/usb/hcd-xhci.c | 42 -- 4 files changed, 8 insertions(+), 38 deletions(-) Reviewed-by: Thomas Huth ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an

Re: [PATCH-for-9.1 03/18] hw/usb/hcd-xhci: Remove XHCI_FLAG_FORCE_PCIE_ENDCAP flag

2024-03-06 Thread Thomas Huth
-- hw/usb/hcd-xhci-pci.c | 3 +-- 3 files changed, 1 insertion(+), 5 deletions(-) Reviewed-by: Thomas Huth ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

Re: [PATCH-for-9.1 16/18] hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine

2024-03-06 Thread Thomas Huth
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote: The pc-i440fx-2.3 machine was deprecated for the 8.2 release (see commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated"), time to remove it. Signed-off-by: Philippe Mathieu-Daudé --- docs/about/deprecate

Re: [PATCH] hw/core/machine-smp: Remove deprecated "parameter=0" SMP configurations

2024-03-03 Thread Thomas Huth
r with zero value, which is meaningless and could also possibly +cause unexpected results in the -smp parsing. So support for this kind of +configurations (e.g. -smp 8,sockets=0) is removed since 9.0, users have +to ensure that all the topology members described with -smp are greater +than zero.

Re: [PATCH v2 09/17] qemu: Always default to no USB controller on s390x

2024-02-16 Thread Thomas Huth
ts/qemuxmlconfdata/s390-usb-address.s390x-latest.xml @@ -17,11 +17,7 @@ destroy /usr/bin/qemu-system-s390x - - - - - + Reviewed-by: Thomas Huth ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

Re: [PATCH 2/5] docs: mark CRIS support as deprecated

2024-02-01 Thread Thomas Huth
;'''''''' + +The CRIS architecture was pulled from Linux in 4.17 and the compiler +is no longer packaged in any distro making it harder to run the +``check-tcg`` tests. Unless we can improve the testing situation there +is a chance the code will bitrot withou

  1   2   >