Re: [PATCH 0/1] Refine the domain status saving logic

2025-09-22 Thread Yong Huang
On Mon, Sep 22, 2025 at 4:28 PM Peter Krempa wrote: > On Mon, Sep 22, 2025 at 16:15:47 +0800, Yong Huang wrote: > > On Mon, Sep 22, 2025 at 2:59 PM Peter Krempa wrote: > > > > > On Mon, Sep 22, 2025 at 11:30:46 +0800, Yong Huang wrote: > > > > On Fri,

Re: [PATCH 0/1] Refine the domain status saving logic

2025-09-21 Thread Yong Huang
On Fri, Sep 19, 2025 at 8:23 PM Peter Krempa wrote: > On Fri, Sep 19, 2025 at 17:09:07 +0800, yong.hu...@smartx.com wrote: > > From: Hyman Huang > > > > When saving the domain status in the path of the virDomainObjSave > > function, Libvirtd will omit the private data if the format > > interface

Re: [PATCH 1/1] domain_conf: Do not omit private data when formatting the status XML

2025-09-21 Thread Yong Huang
On Fri, Sep 19, 2025 at 5:44 PM Peter Krempa wrote: > On Fri, Sep 19, 2025 at 17:09:08 +0800, yong.hu...@smartx.com wrote: > > From: Hyman Huang > > > > Add a thorough check in the virDomainObjSave path to make sure that > > private data in the status XML file always exists for the running VM >

[PATCH 1/1] domain_conf: Do not omit private data when formatting the status XML

2025-09-19 Thread yong . huang
From: Hyman Huang Add a thorough check in the virDomainObjSave path to make sure that private data in the status XML file always exists for the running VM so that we won't lose them after restart the service. --- src/conf/domain_conf.c | 21 ++--- 1 file changed, 18 insertions(+)

[PATCH 0/1] Refine the domain status saving logic

2025-09-19 Thread yong . huang
From: Hyman Huang When saving the domain status in the path of the virDomainObjSave function, Libvirtd will omit the private data if the format interface is not provided. When the Libvirtd service is starting up and the driver has not yet been initialized, this behavior is justified. However, w

Re: [RFC 0/4] Implement automatic attachment of the vhostuser port

2025-07-27 Thread Yong Huang
Ping On Fri, Jul 4, 2025 at 11:20 PM wrote: > From: Hyman Huang > > This series offer an automated method to configure a vhostuser interface > in server mode, simplifying integration with DPDK-enabled Open vSwitch > bridges. > > To ensure simplicity and forward compatibility, we introduce openv

Re: [RFC 0/4] Implement automatic attachment of the vhostuser port

2025-07-14 Thread Yong Huang
Ping On Fri, Jul 4, 2025 at 11:20 PM wrote: > From: Hyman Huang > > This series offer an automated method to configure a vhostuser interface > in server mode, simplifying integration with DPDK-enabled Open vSwitch > bridges. > > To ensure simplicity and forward compatibility, we introduce openv

[RFC 4/4] qemu: Implement automatic attachment of the vhostuser port

2025-07-04 Thread yong . huang
From: Hyman Huang Add logic for automatic attachment and detachment of the vhostuser port within the vhostuser interface lifecycle. --- src/qemu/qemu_command.c | 3 +++ src/qemu/qemu_hotplug.c | 4 src/qemu/qemu_interface.c | 46 +++ src/qemu/qemu_i

[RFC 3/4] util: Add iface argument to virNetDevOpenvswitchAddPort

2025-07-04 Thread yong . huang
From: Hyman Huang Introduce the virNetDevVhostUserIface struct to encapsulate the necessary configuration for attaching a vhostuser port to a bridge. Update the virNetDevOpenvswitchAddPort signature to accept an additional iface argument. Extend the implementation of virNetDevOpenvswitchAddPort

[RFC 2/4] conf: Introduce autoiface attribute for vhostuser interface

2025-07-04 Thread yong . huang
From: Hyman Huang This implements XML support for automatically attaching a vhostuser port to an Open vSwitch bridge. Here is an example of the config for a vhostuser interface that attached to bridge automatically:

[RFC 0/4] Implement automatic attachment of the vhostuser port

2025-07-04 Thread yong . huang
From: Hyman Huang This series offer an automated method to configure a vhostuser interface in server mode, simplifying integration with DPDK-enabled Open vSwitch bridges. To ensure simplicity and forward compatibility, we introduce openvswitch backend support for vhostuser interfaces in XML conf

[RFC 1/4] qemu_passt: Make logFile backend-specific

2025-07-04 Thread yong . huang
From: Hyman Huang The 'logFile' field within the virDomainNetBackend struct is backend-specific. Refactor the code by introducing a union struct to encapsulate backend-specific fields, rather than using a plain field. This refactoring is also a prerequisite for implementing the 'openvswitch' bac

[PATCH v3 1/1] rpc: Add the {repoll,retry} logic in virNetClientSetTLSSession

2025-05-14 Thread yong . huang
From: Hyman Huang As advised by the GNU TLS, the caller should attempt again if the gnutls_record_{recv,send} return EAGAIN or EINTR; check the following link to view the details: https://www.gnutls.org/manual/html_node/Data-transfer-and-termination.html virNetClientSetTLSSession failed to handl

[PATCH v3 0/1] rpc: Re-read the data if EAGAIN or EINTR were captured

2025-05-14 Thread yong . huang
From: Hyman Huang v3: Add the overlooked Signed-off-by v2: 1. Move the retry logic outside of virNetTLSSession{Read,Write} 2. Try re-polling when handing EAGAIN suggested by Daniel v1: 1. Encapsulate the retry logic inside virNetTLSSession{Read,Write} 2. Use VIR_DEBUG instead of VIR_WARN to log

[RESEND PATCH v2 1/1] rpc: Add the {repoll,retry} logic in virNetClientSetTLSSession

2025-05-13 Thread yong . huang
From: Hyman Huang As advised by the GNU TLS, the caller should attempt again if the gnutls_record_{recv,send} return EAGAIN or EINTR; check the following link to view the details: https://www.gnutls.org/manual/html_node/Data-transfer-and-termination.html virNetClientSetTLSSession failed to handl

[RESEND PATCH v2 0/1] rpc: Re-read the data if EAGAIN or EINTR were captured

2025-05-13 Thread yong . huang
From: Hyman Huang v2: 1. Move the retry logic outside of virNetTLSSession{Read,Write} 2. Try re-polling when handing EAGAIN suggested by Daniel v1: 1. Encapsulate the retry logic inside virNetTLSSession{Read,Write} 2. Use VIR_DEBUG instead of VIR_WARN to log the retry operation rfc: https://pat

[PATCH v2 1/1] rpc: Add the {repoll,retry} logic in virNetClientSetTLSSession

2025-05-13 Thread yong . huang
From: Hyman Huang As advised by the GNU TLS, the caller should attempt again if the gnutls_record_{recv,send} return EAGAIN or EINTR; check the following link to view the details: https://www.gnutls.org/manual/html_node/Data-transfer-and-termination.html virNetClientSetTLSSession failed to handl

[PATCH v2 0/1] rpc: Re-read the data if EAGAIN or EINTR were captured

2025-05-13 Thread yong . huang
From: Hyman Huang v2: 1. Move the retry logic outside of virNetTLSSession{Read,Write} 2. Try re-polling when handing EAGAIN suggested by Daniel v1: 1. Encapsulate the retry logic inside virNetTLSSession{Read,Write} 2. Use VIR_DEBUG instead of VIR_WARN to log the retry operation rfc: https://pat

Re: [PATCH v1 1/1] rpc: Add the retry argument for virNetTLSSession{Read,Write}

2025-04-13 Thread Yong Huang
On Fri, Apr 11, 2025 at 5:47 PM Daniel P. Berrangé wrote: > On Tue, Apr 08, 2025 at 10:27:51AM +0800, yong.hu...@smartx.com wrote: > > From: Hyman Huang > > > > As advised by the GNU TLS, the caller should attempt again > > if the gnutls_record_{recv,send} return EAGAIN or EINTR; > > check the f

[PATCH] rpc: Re-read the data if EAGAIN or EINTR were captured

2025-04-10 Thread yong . huang
From: Hyman Huang If EAGAIN or EINTR are returned from the gnutls_record_recv, GNU TLS suggests calling the gnutls_record_recv once again to get the data. Refer to the following link to see details: https://www.gnutls.org/manual/html_node/Data-transfer-and-termination.html To follow this guidanc

[PATCH v1 1/1] rpc: Add the retry argument for virNetTLSSession{Read,Write}

2025-04-07 Thread yong . huang
From: Hyman Huang As advised by the GNU TLS, the caller should attempt again if the gnutls_record_{recv,send} return EAGAIN or EINTR; check the following link to view the details: https://www.gnutls.org/manual/html_node/Data-transfer-and-termination.html Add the retry parameter for virNetTLSSess

[PATCH v1 0/1] rpc: Re-read the data if EAGAIN or EINTR were captured

2025-04-07 Thread yong . huang
From: Hyman Huang v1: 1. Encapsulate the retry logic inside virNetTLSSession{Read,Write} 2. Use VIR_DEBUG instead of VIR_WARN to log the retry operation rfc: https://patchew.org/Libvirt/d716a59dc2c61916917c6d2e07d62055745606d5.1744044211.git.yong.hu...@smartx.com/ Please review, thanks. Yong

Re: [PATCH v1 2/3] qemu_driver: Implement qemuDomainSetVcpuTuneParameters

2025-03-11 Thread Yong Huang
On Thu, Mar 6, 2025 at 11:57 PM Peter Krempa wrote: > On Sat, Feb 15, 2025 at 16:35:52 +0800, yong.hu...@smartx.com wrote: > > From: Hyman Huang > > > > Support hotplug/hotunplug of virtual CPU by wrapping the > > existing interface qemuDomainSetVcpu. > > > > Signed-off-by: Hyman Huang > > ---

[PATCH v1 3/3] virsh: Use the new API to implement cmdSetvcpu

2025-02-15 Thread yong . huang
From: Hyman Huang Signed-off-by: Hyman Huang --- tools/virsh-domain.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index f3da2f903f..83db56460b 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -7345,6 +7

[PATCH v1 2/3] qemu_driver: Implement qemuDomainSetVcpuTuneParameters

2025-02-15 Thread yong . huang
From: Hyman Huang Support hotplug/hotunplug of virtual CPU by wrapping the existing interface qemuDomainSetVcpu. Signed-off-by: Hyman Huang --- include/libvirt/libvirt-domain.h | 12 src/qemu/qemu_driver.c | 29 + 2 files changed, 41 insertion

[PATCH v1 1/3] libvirt: Add virDomainSetVcpuTuneParameters API

2025-02-15 Thread yong . huang
From: Hyman Huang Introduce virDomainSetVcpuTuneParameters API to support tunables of virtual CPUs. Signed-off-by: Hyman Huang --- include/libvirt/libvirt-domain.h | 13 src/driver-hypervisor.h | 8 + src/libvirt-domain.c | 56

[PATCH v1 0/3] Introduce qemuDomainSetVcpuTuneParameters API

2025-02-15 Thread yong . huang
From: Hyman Huang This patchset is the prerequisite for the vCPU dirty-limit feature: https://patchew.org/Libvirt/cover.1703135535.git.yong.hu...@smartx.com/ As suggested by Daniel: We've generally tried to avoid adding single purpose APIs for tunable parameters, instead using APIs with virType

Re: [v3 0/4] Support for dirty-limit live migration

2024-01-14 Thread Yong Huang
Ping1 :) On Thu, Dec 21, 2023 at 1:19 PM Hyman Huang wrote: > v3: > - adjust the parameter check location for suggested by Michal > - mark the VIR_MIGRATE_DIRTY_LIMIT flag since 10.0.0 > - rebase on master > > Thanks Michal for the comments. > > Please review, > Yong. > > v1: > The dirty-limit