Re:  [PATCH v2] remote/stream-event: Fix a memory leak in?? remoteStreamCallbackFree()

2025-06-26 Thread liu . song13
> On Thu, Jun 26, 2025 at 03:53:35 -, liu.song13(a)zte.com.cn wrote: > > Having two references this way would look confusing, so if you decide > that it is necessary please add a comment explaining why it is > necessary. > > In this patch it looked extra confusing as you deleted an empty line

Re:  [PATCH v2] remote/stream-event: Fix a memory leak in?? remoteStreamCallbackFree()

2025-06-25 Thread liu . song13
> On Wed, Jun 25, 2025 at 09:27:33 +0800, liu.xuemei1(a)zte.com.cn wrote: > > The above looks weird. Now 'client' is referenced twice and you delete > an empty line? Since the patch fixes the virStreamEventAddCallback (not freeing its 'opaque'), 'client' should be referenced before every call of i