[PATCH] fix virLogCleanerParseFilename logic

We should return the full filename path when we don't have a match on the third group of the regex. Signed-off-by: David Negreira --- src/logging/log_cleaner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/logging/log_cleaner.c b/src/logging/log_cleaner.c index 4ee91843

Re: [PATCH] fix virLogCleanerParseFilename logic

On 5/19/24 17:40, David Negreira wrote: > We should return the full filename path when we don't have a match on > the third group of the regex. > > Signed-off-by: David Negreira > --- > src/logging/log_cleaner.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/loggin

Re: [PATCH] fix virLogCleanerParseFilename logic

On 5/21/24 11:11, David Negreira wrote: > Hi, > > For the reproducer I have enabled the garbage collection and debugging > on virtlogd.conf file: > - grep -v ^# /etc/libvirt/virtlogd.conf > log_filters="1:logging 4:object 4:json 1:event 1:util" > log_outputs="1:syslog:virtlogd" > max_age_day

Re: [PATCH] fix virLogCleanerParseFilename logic

Hi, For the reproducer I have enabled the garbage collection and debugging on virtlogd.conf file: - grep -v ^# /etc/libvirt/virtlogd.conf log_filters="1:logging 4:object 4:json 1:event 1:util" log_outputs="1:syslog:virtlogd" max_age_days = 1 log_root = "/var/log/libvirt" - I have also patc

Re: [PATCH] fix virLogCleanerParseFilename logic

Hi Michal, Thank you for your comments and improvements on the patch. > diff --git i/src/logging/log_cleaner.c w/src/logging/log_cleaner.c > index 4ee91843aa..9f987b02b5 100644 > --- i/src/logging/log_cleaner.c > +++ w/src/logging/log_cleaner.c > @@ -82,10 +82,8 @@ virLogCleanerParseFilename(cons

Re: [PATCH] fix virLogCleanerParseFilename logic

On 5/29/24 09:04, David Negreira wrote: > Gentle reminder > >>> >>> Can you please send v2? >>> >>> Michal Oh, I thought you were going to send v2. But okay, let me do that. Michal

Re: [PATCH] fix virLogCleanerParseFilename logic

On 5/29/24 09:21, Michal Prívozník wrote: > On 5/29/24 09:04, David Negreira wrote: >> Gentle reminder >> > > Can you please send v2? Michal > > Oh, I thought you were going to send v2. But okay, let me do that. Done: https://lists.libvirt.org/archives/list/devel@lists.libv

Re: [PATCH] fix virLogCleanerParseFilename logic

Gentle reminder On Thu, May 23, 2024 at 9:05 AM David Negreira wrote: > > Hi Michal, > > Thank you for your comments and improvements on the patch. > > > diff --git i/src/logging/log_cleaner.c w/src/logging/log_cleaner.c > > index 4ee91843aa..9f987b02b5 100644 > > --- i/src/logging/log_cleaner.c

Re: [PATCH] fix virLogCleanerParseFilename logic

Appreciated Michal, thank you for your valuable input and help. On Wed, May 29, 2024 at 9:52 AM Michal Prívozník wrote: > > On 5/29/24 09:21, Michal Prívozník wrote: > > On 5/29/24 09:04, David Negreira wrote: > >> Gentle reminder > >> > > > > > > Can you please send v2? > > M