Re: [PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix

2025-04-10 Thread Kirill Shchetiniuk via Devel
I've discussed this with Michal Privoznik and we decided it's better to mask the flag rather than adding it to the virCheckFlags, as virStorageVolDefParseXML do not validate anything and we did not want to have useless flag inside it, as it not really obvious why it would be there, when function do

Re: [PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix

2025-04-08 Thread Peter Krempa via Devel
On Tue, Apr 08, 2025 at 20:21:13 +0200, Kirill Shchetiniuk wrote: > On Mon, Apr 07, 2025 at 03:59:25PM +0200, Peter Krempa wrote: > > On Mon, Apr 07, 2025 at 15:45:24 +0200, Michal Prívozník wrote: > > > On 4/7/25 15:11, Peter Krempa via Devel wrote: > > > > On Mon, Apr 07, 2025 at 14:49:14 +0200,

Re: [PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix

2025-04-08 Thread Kirill Shchetiniuk via Devel
On Mon, Apr 07, 2025 at 03:59:25PM +0200, Peter Krempa wrote: > On Mon, Apr 07, 2025 at 15:45:24 +0200, Michal Prívozník wrote: > > On 4/7/25 15:11, Peter Krempa via Devel wrote: > > > On Mon, Apr 07, 2025 at 14:49:14 +0200, Peter Krempa via Devel wrote: > > >> On Mon, Apr 07, 2025 at 14:25:43 +020

Re: [PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix

2025-04-07 Thread Peter Krempa via Devel
On Mon, Apr 07, 2025 at 15:45:24 +0200, Michal Prívozník wrote: > On 4/7/25 15:11, Peter Krempa via Devel wrote: > > On Mon, Apr 07, 2025 at 14:49:14 +0200, Peter Krempa via Devel wrote: > >> On Mon, Apr 07, 2025 at 14:25:43 +0200, Kirill Shchetiniuk via Devel wrote: [...] > >> Either way this hu

Re: [PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix

2025-04-07 Thread Peter Krempa via Devel
On Mon, Apr 07, 2025 at 15:25:58 +0200, Kirill Shchetiniuk wrote: Please do not top-post on technical lists [1]. > I've discussed this with Michal Privoznik and we decided it's better to > mask the flag rather than adding it to the virCheckFlags, as > virStorageVolDefParseXML do not validate anyt

Re: [PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix

2025-04-07 Thread Michal Prívozník via Devel
On 4/7/25 15:11, Peter Krempa via Devel wrote: > On Mon, Apr 07, 2025 at 14:49:14 +0200, Peter Krempa via Devel wrote: >> On Mon, Apr 07, 2025 at 14:25:43 +0200, Kirill Shchetiniuk via Devel wrote: >>> When the new storage was created using virsh with --validate option >>> following errors occurred

Re: [PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix

2025-04-07 Thread Peter Krempa via Devel
On Mon, Apr 07, 2025 at 14:49:14 +0200, Peter Krempa via Devel wrote: > On Mon, Apr 07, 2025 at 14:25:43 +0200, Kirill Shchetiniuk via Devel wrote: > > When the new storage was created using virsh with --validate option > > following errors occurred: > > > > # virsh vol-create default --file vol-d

Re: [PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix

2025-04-07 Thread Peter Krempa via Devel
On Mon, Apr 07, 2025 at 14:25:43 +0200, Kirill Shchetiniuk via Devel wrote: > When the new storage was created using virsh with --validate option > following errors occurred: > > # virsh vol-create default --file vol-def.xml --validate > error: Failed to create vol from vol-def.xml > error: unsupp

[PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix

2025-04-07 Thread Kirill Shchetiniuk via Devel
When the new storage was created using virsh with --validate option following errors occurred: # virsh vol-create default --file vol-def.xml --validate error: Failed to create vol from vol-def.xml error: unsupported flags (0x4) in function virStorageVolDefParseXML and after virStorageVolDefParse