Re: [PATCH] virsh: Fix overflow error of freepages command

2024-03-05 Thread Michal Prívozník
On 3/5/24 11:43, Adam Julis wrote: > Trying to print pages of a size larger than the UINT_MAX of the > given platform (for example, around 4G on 64-bit intel), a system > error was printed, but this is a legitimate request, fixed. > > vshCommandOptScaledInt requiers set maximum returning size for

[PATCH] virsh: Fix overflow error of freepages command

2024-03-05 Thread Adam Julis
Trying to print pages of a size larger than the UINT_MAX of the given platform (for example, around 4G on 64-bit intel), a system error was printed, but this is a legitimate request, fixed. vshCommandOptScaledInt requiers set maximum returning size for the variable '&bytes'. It was set as UINT_MAX

Re: [PATCH] virsh: Fix overflow error of freepages command

2024-03-05 Thread Michal Prívozník
On 3/5/24 09:29, Adam Julis wrote: > Trying to print pages of a size larger than the UINT_MAX of the given > platform, a system error was printed, but this is a legitimate request, fixed I'd like to see explained here why UINT_MAX is not good enough and why we can't use larger type (unsigned lon

[PATCH] virsh: Fix overflow error of freepages command

2024-03-05 Thread Adam Julis
Trying to print pages of a size larger than the UINT_MAX of the given platform, a system error was printed, but this is a legitimate request, fixed Signed-off-by: Adam Julis --- tools/virsh-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-host.c b/tools/vir