Re: [PATCH] virt-admin: Fix segfault when libvirtd dies

2024-03-19 Thread Claudio Fontana
On 3/19/24 15:58, Jiri Denemark wrote: > On Tue, Mar 19, 2024 at 14:34:08 +0100, Claudio Fontana wrote: >> On 3/19/24 12:02, Adam Julis wrote: >>> vshAdmCatchDisconnect requires non-NULL structure vshControl for >>> getting connection name (stored at opaque), but >>> virAdmConnectRegisterCloseCal

Re: [PATCH] virt-admin: Fix segfault when libvirtd dies

2024-03-19 Thread Ján Tomko
On a Tuesday in 2024, Adam Julis wrote: vshAdmCatchDisconnect requires non-NULL structure vshControl for getting connection name (stored at opaque), but virAdmConnectRegisterCloseCallback at vshAdmConnect called it with NULL. Signed-off-by: Adam Julis --- tools/virt-admin.c | 2 +- 1 file change

Re: [PATCH] virt-admin: Fix segfault when libvirtd dies

2024-03-19 Thread Jiri Denemark
On Tue, Mar 19, 2024 at 14:34:08 +0100, Claudio Fontana wrote: > On 3/19/24 12:02, Adam Julis wrote: > > vshAdmCatchDisconnect requires non-NULL structure vshControl for > > getting connection name (stored at opaque), but > > virAdmConnectRegisterCloseCallback at vshAdmConnect called it > > with NU

Re: [PATCH] virt-admin: Fix segfault when libvirtd dies

2024-03-19 Thread Claudio Fontana
On 3/19/24 12:02, Adam Julis wrote: > vshAdmCatchDisconnect requires non-NULL structure vshControl for > getting connection name (stored at opaque), but > virAdmConnectRegisterCloseCallback at vshAdmConnect called it > with NULL. > > Signed-off-by: Adam Julis > --- > tools/virt-admin.c | 2 +- >

[PATCH] virt-admin: Fix segfault when libvirtd dies

2024-03-19 Thread Adam Julis
vshAdmCatchDisconnect requires non-NULL structure vshControl for getting connection name (stored at opaque), but virAdmConnectRegisterCloseCallback at vshAdmConnect called it with NULL. Signed-off-by: Adam Julis --- tools/virt-admin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -