Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-20 Thread Zhao Liu
On Mon, May 13, 2024 at 01:33:57PM +0100, Daniel P. Berrangé wrote: > Date: Mon, 13 May 2024 13:33:57 +0100 > From: "Daniel P. Berrangé" > Subject: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any > machine > > This effec

Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-20 Thread Zhao Liu
On Wed, May 15, 2024 at 06:06:56PM +0100, Daniel P. Berrangé wrote: > Date: Wed, 15 May 2024 18:06:56 +0100 > From: "Daniel P. Berrangé" > Subject: Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any > machine > > On Tue, May 14, 2024 at 11:4

Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-15 Thread Daniel P . Berrangé
On Tue, May 14, 2024 at 11:49:40AM +0800, Zhao Liu wrote: > > I'm failing to see what real world technical problems QEMU faces > > with a parameter being set to '1' by a mgmt app, when QEMU itself > > treats all omitted values as being '1' anyway. > > > > If we're trying to faithfully model the re

Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-14 Thread Zhao Liu
> I'm failing to see what real world technical problems QEMU faces > with a parameter being set to '1' by a mgmt app, when QEMU itself > treats all omitted values as being '1' anyway. > > If we're trying to faithfully model the real world, then restricting > the topology against machine types thou

Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-13 Thread Daniel P . Berrangé
t; > Subject: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any > > machine > > > > This effectively reverts > > > > commit 54c4ea8f3ae614054079395842128a856a73dbf9 > > Author: Zhao Liu > > Date: Sat Mar 9 00:01:37 2024 +0800 > >

Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-13 Thread Zhao Liu
Cc Paolo for x86 topology part Hi Daniel, On Mon, May 13, 2024 at 01:33:57PM +0100, Daniel P. Berrangé wrote: > Date: Mon, 13 May 2024 13:33:57 +0100 > From: "Daniel P. Berrangé" > Subject: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any > machine > &

[PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-13 Thread Daniel P . Berrangé
This effectively reverts commit 54c4ea8f3ae614054079395842128a856a73dbf9 Author: Zhao Liu Date: Sat Mar 9 00:01:37 2024 +0800 hw/core/machine-smp: Deprecate unsupported "parameter=1" SMP configurations but is not done as a 'git revert' since the part of the changes to the file hw/co