Re: [PATCH] Сheck snapshot disk is not NULL when searching it in the VM config

2024-05-17 Thread Denis V. Lunev via Devel
On 4/29/24 14:43, Fima Shevrin wrote: When creating a snapshot of a VM with multiple hard disks, the snapshot takes into account the presence of all disks in the system. If, over time, one of the disks is deleted, the snapshot will continue to store knowledge of the deleted disk. This results in

Re: [PATCH] Сheck snapshot disk is not NULL when searching it in the VM config

2024-05-20 Thread Michal Prívozník
On 4/29/24 14:43, Fima Shevrin via Devel wrote: > When creating a snapshot of a VM with multiple hard disks, > the snapshot takes into account the presence of all disks > in the system. If, over time, one of the disks is deleted, > the snapshot will continue to store knowledge of the deleted disk.

Re: [PATCH] Сheck snapshot disk is not NULL when searching it in the VM config

2024-05-20 Thread Efim Shevrin via Devel
chal Prívozník Sent: Monday, May 20, 2024 15:52 To: Efim Shevrin ; devel@lists.libvirt.org Cc: d...@openvz.org Subject: Re: [PATCH] Сheck snapshot disk is not NULL when searching it in the VM config [You don't often get email from mpriv...@redhat.com. Learn why this is important at https://ak

Re: [PATCH] Сheck snapshot disk is not NULL when searching it in the VM config

2024-05-20 Thread Peter Krempa
On Mon, May 20, 2024 at 14:48:47 +, Efim Shevrin via Devel wrote: > Hello, > > > If vmdisk is NULL, shouldn't this function (qemuSnapshotDeleteValidate()) > > return an error? > > I think this qemuSnapshotDeleteValidate should not return an error. > > It seems to me that when vmdisk is NULL