Entering freeze for libvirt-10.3.0

2024-04-26 Thread Jiri Denemark
I have just tagged v10.3.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the

Re: [PATCH] vmx: Check serialX.vspc before serialX.fileName

2024-04-26 Thread Richard W.M. Jones
On Thu, Apr 25, 2024 at 02:12:54PM +0200, Martin Kletzander wrote: > When using vSPC (Virtual Serial Port Concentrator) in vSphere the actual > address for it is saved in serialX.vspc in which case the > serialX.fileName is most probably something we can't get any useful > information from and we

Re: [PATCH-for-9.1 v2 2/3] target/nios2: Remove the deprecated Nios II target

2024-04-26 Thread Marek Vasut
On 4/24/24 10:50 AM, Philippe Mathieu-Daudé wrote: Hi Marek, On 18/4/24 14:04, Marek Vasut wrote: On 4/18/24 1:10 PM, Philippe Mathieu-Daudé wrote: On 27/3/24 15:48, Philippe Mathieu-Daudé wrote: The Nios II target is deprecated since v8.2 in commit 9997771bc1 ("target/nios2: Deprecate the

[PATCH] fix detach disk device failed with device not found

2024-04-26 Thread long.yunjian
From: Long YunJian We detach windows disk with libvirt-python api dom.detachDeviceFlags(xmlstr,3), but files in windows disk is opened and busy, and libvirt return success. We found disk not detached actually. so, we close files those opened in windows, and want to detach again. However, we

Re: Revisiting parallel save/restore

2024-04-26 Thread Daniel P . Berrangé
On Thu, Apr 25, 2024 at 04:41:02PM -0600, Jim Fehlig via Devel wrote: > On 4/17/24 5:12 PM, Jim Fehlig wrote: > > Hi All, > > > > While Fabiano has been working on improving save/restore performance in > > qemu, I've been tinkering with the same in libvirt. The end goal is to > > introduce a new

Re: [PATCH v3 00/27] [PATCH v3 00/27] native support for nftables in virtual network driver

2024-04-26 Thread Daniel P . Berrangé
On Thu, Apr 25, 2024 at 06:22:33PM +0100, Daniel P. Berrangé wrote: > On Thu, Apr 25, 2024 at 01:38:06AM -0400, Laine Stump wrote: > > V2: > > https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/5RTZ6PC3N3CO6X353QUHLVOL43SWQ4JD/ > > > > This patch series enables libvirt to use

Re: [PATCH] vmx: Check serialX.vspc before serialX.fileName

2024-04-26 Thread Martin Kletzander
On Thu, Apr 25, 2024 at 05:30:24PM +0200, Peter Krempa wrote: On Thu, Apr 25, 2024 at 14:12:54 +0200, Martin Kletzander wrote: When using vSPC (Virtual Serial Port Concentrator) in vSphere the actual address for it is saved in serialX.vspc in which case the serialX.fileName is most probably

Re: Revisiting parallel save/restore

2024-04-26 Thread Daniel P . Berrangé
On Wed, Apr 17, 2024 at 05:12:27PM -0600, Jim Fehlig via Devel wrote: > A good starting point on this journey is supporting the new mapped-ram > capability in qemu 9.0 [2]. Since mapped-ram is a new on-disk format, I > assume we'll need a new QEMU_SAVE_VERSION 3 when using it? Otherwise I'm not >

Re: [PATCH] fix detach disk device failed with device not found

2024-04-26 Thread Peter Krempa
On Fri, Apr 26, 2024 at 12:29:05 +0800, long.yunj...@zte.com.cn wrote: > From: Long YunJian > > We detach windows disk with libvirt-python api > dom.detachDeviceFlags(xmlstr,3), > but files in windows disk is opened and busy, and libvirt return success. > We found disk not detached actually.

Re: [PATCH-for-9.1 v2 2/3] target/nios2: Remove the deprecated Nios II target

2024-04-26 Thread Marek Vasut
On 4/18/24 1:10 PM, Philippe Mathieu-Daudé wrote: On 27/3/24 15:48, Philippe Mathieu-Daudé wrote: The Nios II target is deprecated since v8.2 in commit 9997771bc1 ("target/nios2: Deprecate the Nios II architecture"). Remove: - Buildsys / CI infra - User emulation - System emulation (10m50-ghrd

Re: [PATCH 0/6] migration removals & deprecations

2024-04-26 Thread Markus Armbruster
Doesn't apply for me. What's your base? ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

Re: [PATCH v1 16/20] node_device_udev: Use a worker pool for processing events and emitting nodedev event

2024-04-26 Thread Marc Hartmayer
On Fri, Apr 19, 2024 at 04:49 PM +0200, Marc Hartmayer wrote: > Use a worker pool for processing the events (e.g. udev, mdevctl config > changes) > and the initialization instead of a separate initThread and a mdevctl-thread. > This has the large advantage that we can leverage the job API and

[PATCH] qemu_saveimage: add zstd to supported compression formats

2024-04-26 Thread Adam Julis
Extend the list of supported formats, update and clarify comment in qemu.conf.in (removed misleading sentence about the order of compression format types). Signed-off-by: Adam Julis --- libvirt.spec.in | 1 + src/qemu/qemu.conf.in | 7 +++ src/qemu/qemu_saveimage.c | 2 ++ 3

[PATCH v2 0/6] migration removals & deprecations

2024-04-26 Thread Fabiano Rosas
[respinning because master moved and there were conflicts] Hi everyone, Here's some cleaning up of deprecated code. It removes the old block migration and compression code. Both have suitable replacements in the form of the blockdev-mirror driver and multifd compression, respectively. There's

[PATCH v2 6/6] migration: Deprecate fd: for file migration

2024-04-26 Thread Fabiano Rosas
The fd: URI can currently trigger two different types of migration, a TCP migration using sockets and a file migration using a plain file. This is in conflict with the recently introduced (8.2) QMP migrate API that takes structured data as JSON-like format. We cannot keep the same backend for both

[PATCH v2 5/6] migration: Remove non-multifd compression

2024-04-26 Thread Fabiano Rosas
The 'compress' migration capability enables the old compression code which has shown issues over the years and is thought to be less stable and tested than the more recent multifd-based compression. The old compression code has been deprecated in 8.2 and now is time to remove it. Deprecation

Re: Revisiting parallel save/restore

2024-04-26 Thread Daniel P . Berrangé
On Fri, Apr 26, 2024 at 10:03:29AM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Wed, Apr 17, 2024 at 05:12:27PM -0600, Jim Fehlig via Devel wrote: > >> A good starting point on this journey is supporting the new mapped-ram > >> capability in qemu 9.0 [2]. Since mapped-ram is

Re: [PATCH 3/6] migration: Remove 'blk/-b' option from migrate commands

2024-04-26 Thread Fabiano Rosas
Markus Armbruster writes: > Markus Armbruster writes: > >> Fabiano Rosas writes: >> >>> The block migration is considered obsolete and has been deprecated in >>> 8.2. Remove the migrate command option that enables it. This only >>> affects the QMP and HMP commands, the feature can still be

Re: Revisiting parallel save/restore

2024-04-26 Thread Jim Fehlig via Devel
On 4/26/24 4:04 AM, Daniel P. Berrangé wrote: On Wed, Apr 17, 2024 at 05:12:27PM -0600, Jim Fehlig via Devel wrote: A good starting point on this journey is supporting the new mapped-ram capability in qemu 9.0 [2]. Since mapped-ram is a new on-disk format, I assume we'll need a new

Re: Revisiting parallel save/restore

2024-04-26 Thread Jim Fehlig via Devel
On 4/26/24 4:07 AM, Daniel P. Berrangé wrote: On Thu, Apr 25, 2024 at 04:41:02PM -0600, Jim Fehlig via Devel wrote: On 4/17/24 5:12 PM, Jim Fehlig wrote: Hi All, While Fabiano has been working on improving save/restore performance in qemu, I've been tinkering with the same in libvirt. The end

[PATCH v2 4/6] migration: Remove block migration

2024-04-26 Thread Fabiano Rosas
The block migration has been considered obsolete since QEMU 8.2 in favor of the more flexible storage migration provided by the blockdev-mirror driver. Two releases have passed so now it's time to remove it. Deprecation commit 66db46ca83 ("migration: Deprecate block migration"). Signed-off-by:

Re: [PATCH 3/6] migration: Remove 'blk/-b' option from migrate commands

2024-04-26 Thread Markus Armbruster
Markus Armbruster writes: > Fabiano Rosas writes: > >> The block migration is considered obsolete and has been deprecated in >> 8.2. Remove the migrate command option that enables it. This only >> affects the QMP and HMP commands, the feature can still be accessed by >> setting the migration

Re: Revisiting parallel save/restore

2024-04-26 Thread Daniel P . Berrangé
On Fri, Apr 26, 2024 at 11:44:38AM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Fri, Apr 26, 2024 at 10:03:29AM -0300, Fabiano Rosas wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Wed, Apr 17, 2024 at 05:12:27PM -0600, Jim Fehlig via Devel wrote: > >> >> A good

Re: [PATCH] vmx: Check serialX.vspc before serialX.fileName

2024-04-26 Thread Martin Kletzander
On Fri, Apr 26, 2024 at 10:34:46AM +0200, Martin Kletzander wrote: On Thu, Apr 25, 2024 at 05:30:24PM +0200, Peter Krempa wrote: On Thu, Apr 25, 2024 at 14:12:54 +0200, Martin Kletzander wrote: When using vSPC (Virtual Serial Port Concentrator) in vSphere the actual address for it is saved in

Re: [PATCH 0/6] migration removals & deprecations

2024-04-26 Thread Markus Armbruster
Fabiano Rosas writes: > Markus Armbruster writes: > >> Doesn't apply for me. What's your base? > > 88daa112d4 ("Merge tag 'migration-20240423-pull-request' of > https://gitlab.com/peterx/qemu into staging") > > Probably clashed with the other removals from Philippe. Thanks!

[PATCH v2 1/6] migration: Remove 'skipped' field from MigrationStats

2024-04-26 Thread Fabiano Rosas
The 'skipped' field of the MigrationStats struct has been deprecated in 8.1. Time to remove it. Deprecation commit 7b24d32634 ("migration: skipped field is really obsolete."). Reviewed-by: Markus Armbruster Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 6 --

Re: [PATCH 0/6] migration removals & deprecations

2024-04-26 Thread Fabiano Rosas
Markus Armbruster writes: > Doesn't apply for me. What's your base? 88daa112d4 ("Merge tag 'migration-20240423-pull-request' of https://gitlab.com/peterx/qemu into staging") Probably clashed with the other removals from Philippe. ___ Devel mailing

Re: Revisiting parallel save/restore

2024-04-26 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Wed, Apr 17, 2024 at 05:12:27PM -0600, Jim Fehlig via Devel wrote: >> A good starting point on this journey is supporting the new mapped-ram >> capability in qemu 9.0 [2]. Since mapped-ram is a new on-disk format, I >> assume we'll need a new QEMU_SAVE_VERSION 3

Re: Revisiting parallel save/restore

2024-04-26 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Fri, Apr 26, 2024 at 10:03:29AM -0300, Fabiano Rosas wrote: >> Daniel P. Berrangé writes: >> >> > On Wed, Apr 17, 2024 at 05:12:27PM -0600, Jim Fehlig via Devel wrote: >> >> A good starting point on this journey is supporting the new mapped-ram >> >> capability

Re: [PATCH v3 00/27] [PATCH v3 00/27] native support for nftables in virtual network driver

2024-04-26 Thread Laine Stump
On 4/25/24 1:22 PM, Daniel P. Berrangé wrote: On Thu, Apr 25, 2024 at 01:38:06AM -0400, Laine Stump wrote: V2: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/5RTZ6PC3N3CO6X353QUHLVOL43SWQ4JD/ This patch series enables libvirt to use nftables rules rather than iptables

Re: [PATCH] vmx: Check serialX.vspc before serialX.fileName

2024-04-26 Thread Martin Kletzander
On Fri, Apr 26, 2024 at 11:47:36AM +0100, Richard W.M. Jones wrote: On Thu, Apr 25, 2024 at 02:12:54PM +0200, Martin Kletzander wrote: When using vSPC (Virtual Serial Port Concentrator) in vSphere the actual address for it is saved in serialX.vspc in which case the serialX.fileName is most

Re: [PATCH 0/6] migration removals & deprecations

2024-04-26 Thread Fabiano Rosas
Markus Armbruster writes: > Fabiano Rosas writes: > >> Markus Armbruster writes: >> >>> Doesn't apply for me. What's your base? >> >> 88daa112d4 ("Merge tag 'migration-20240423-pull-request' of >> https://gitlab.com/peterx/qemu into staging") >> >> Probably clashed with the other removals

Re: [PATCH 2/6] migration: Remove 'inc' option from migrate command

2024-04-26 Thread Markus Armbruster
Fabiano Rosas writes: > The block incremental option for block migration has been deprecated > in 8.2 in favor of using the block-mirror feature. Remove it now. > > Deprecation commit 40101f320d ("migration: migrate 'inc' command > option is deprecated."). > > Signed-off-by: Fabiano Rosas > ---

Re: [PATCH 3/6] migration: Remove 'blk/-b' option from migrate commands

2024-04-26 Thread Markus Armbruster
Fabiano Rosas writes: > The block migration is considered obsolete and has been deprecated in > 8.2. Remove the migrate command option that enables it. This only > affects the QMP and HMP commands, the feature can still be accessed by > setting the migration 'block' capability. The whole feature

Re: [PATCH v3 00/27] [PATCH v3 00/27] native support for nftables in virtual network driver

2024-04-26 Thread Laine Stump
On 4/26/24 6:24 AM, Daniel P. Berrangé wrote: On Thu, Apr 25, 2024 at 06:22:33PM +0100, Daniel P. Berrangé wrote: On Thu, Apr 25, 2024 at 01:38:06AM -0400, Laine Stump wrote: V2: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/5RTZ6PC3N3CO6X353QUHLVOL43SWQ4JD/ This

[PATCH v2 2/6] migration: Remove 'inc' option from migrate command

2024-04-26 Thread Fabiano Rosas
The block incremental option for block migration has been deprecated in 8.2 in favor of using the block-mirror feature. Remove it now. Deprecation commit 40101f320d ("migration: migrate 'inc' command option is deprecated."). Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 9

Re: [PATCH 2/6] migration: Remove 'inc' option from migrate command

2024-04-26 Thread Markus Armbruster
Markus Armbruster writes: > Fabiano Rosas writes: > >> The block incremental option for block migration has been deprecated >> in 8.2 in favor of using the block-mirror feature. Remove it now. >> >> Deprecation commit 40101f320d ("migration: migrate 'inc' command >> option is deprecated."). >>

Re: [PATCH 4/6] migration: Remove block migration

2024-04-26 Thread Markus Armbruster
Fabiano Rosas writes: > The block migration has been considered obsolete since QEMU 8.2 in > favor of the more flexible storage migration provided by the > blockdev-mirror driver. Two releases have passed so now it's time to > remove it. > > Deprecation commit 66db46ca83 ("migration: Deprecate

[PATCH v2 3/6] migration: Remove 'blk/-b' option from migrate commands

2024-04-26 Thread Fabiano Rosas
The block migration is considered obsolete and has been deprecated in 8.2. Remove the migrate command option that enables it. This only affects the QMP and HMP commands, the feature can still be accessed by setting the migration 'block' capability. The whole feature will be removed in a future

Re: [PATCH 5/6] migration: Remove non-multifd compression

2024-04-26 Thread Markus Armbruster
Fabiano Rosas writes: > The 'compress' migration capability enables the old compression code > which has shown issues over the years and is thought to be less stable > and tested than the more recent multifd-based compression. The old > compression code has been deprecated in 8.2 and now is time

[RFC 1/6] introduce virDomainJobWait

2024-04-26 Thread Thanos Makatos
This patch introduces virDomainJobWait, which waits for the specified domain job to finish. The caller specifies the desired job type to wait for. For now, only dump jobs are supported. This functionality is needed so that the process that started the dump job can pick it up and continue waiting

[RFC 2/6] add wait option to virsh dump

2024-04-26 Thread Thanos Makatos
This patch introduces the --wait option to virsh dump, which allows waiting for an already ongoing dump operation. --- tools/virsh-domain.c | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index

[RFC 4/6] test_driver: introduce testDomainJobWait

2024-04-26 Thread Thanos Makatos
This patch adds function testDomainJobWait. Since the test_driver exists in the application's address space, it is impossible to test the scenario where an application starts a core dump job, restarts, and then joins it. To get around this problem, we simulate a dump job by having

[RFC 6/6] test_driver: dump: store dump flags as payload

2024-04-26 Thread Thanos Makatos
This way we can inspect the dump file and confirm that the test_driver really used the dump format we specified. Signed-off-by: Thanos Makatos --- src/test/test_driver.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/test/test_driver.c

[RFC 5/6] test_driver: allow and ignore more flags in testDomainCoreDumpWithFormat

2024-04-26 Thread Thanos Makatos
It doesn't make sense to honor them, so we may just allow them. --- src/test/test_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index a9c7dbaee1..2a31511e3e 100644 --- a/src/test/test_driver.c +++

introduce virDomainJobWait for dump plus testing

2024-04-26 Thread Thanos Makatos
This patch series introduces funcionality for waiting for a job from a different context, for now only for dump jobs, plus testing. This can be useful in situations where the original requester of the job crashes/restarts and then needs to continue waiting for that potentially ongoing job. To

[RFC 3/6] test_driver: allow win-dmp format

2024-04-26 Thread Thanos Makatos
Signed-off-by: Thanos Makatos --- src/test/test_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ed0cdc0dab..c892ecefaa 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -2621,7 +2621,8 @@