Re: [PATCH 4/5] wireshark: drop gmodule.h include to avoid glib warnings

2024-10-15 Thread Peter Krempa
On Tue, Oct 15, 2024 at 12:19:23 +0100, Daniel P. Berrangé wrote: > The wireshark address.h header uses 'g_memdup2' but this triggers > warnings under clang due to the max version cap: > > In file included from ../tools/wireshark/src/plugin.c:27: > In file included from /usr/include/wiresh

Re: [PATCH 3/5] tests: stop stubbing libselinux APIs for purpose of data overrides

2024-10-15 Thread Peter Krempa
On Tue, Oct 15, 2024 at 12:19:22 +0100, Daniel P. Berrangé wrote: > We currently create stub 'setcon', 'setcon_raw' and 'security_disable' > APIs in the securityselinuxhelper.c mock, which set env variables to > control how other mock'd libselinux APIs respond. These stubs merely > set some env va

Re: [PATCH 1/5] meson: unconditionally enable polkit on non-Windows

2024-10-15 Thread Daniel P . Berrangé
On Tue, Oct 15, 2024 at 01:38:12PM +0200, Peter Krempa wrote: > On Tue, Oct 15, 2024 at 12:19:20 +0100, Daniel P. Berrangé wrote: > > The polkit code does not have a build time dependancy on any system > > headers or libraries. It can be safely enabled on any non-Windows > > platform. > > > > Sign

Re: [PATCH 5/5] ci: update macOS versions under test

2024-10-15 Thread Peter Krempa
On Tue, Oct 15, 2024 at 12:19:24 +0100, Daniel P. Berrangé wrote: > Cirrus CI has stoppped offering multiple versions of macOS images. > > There is now only 1 single image, but with multiple XCode versions > pre-installed, selectable using the 'xcodes' app: > > $ xcodes list | grep Installed

Re: [PATCH 17/20] include: Define constants for parallel save/restore

2024-10-15 Thread Claudio Fontana
On 10/14/24 21:41, Jim Fehlig via Devel wrote: > On 10/14/24 11:42, Daniel P. Berrangé wrote: >> On Mon, Oct 14, 2024 at 06:00:53PM +0200, Claudio Fontana wrote: >>> On 10/10/24 15:29, Daniel P. Berrangé wrote: On Thu, Aug 08, 2024 at 05:38:10PM -0600, Jim Fehlig via Devel wrote: > From: C

Re: [PATCH 5/5] ci: update macOS versions under test

2024-10-15 Thread Daniel P . Berrangé
On Tue, Oct 15, 2024 at 01:58:00PM +0200, Peter Krempa wrote: > On Tue, Oct 15, 2024 at 12:19:24 +0100, Daniel P. Berrangé wrote: > > Cirrus CI has stoppped offering multiple versions of macOS images. > > > > There is now only 1 single image, but with multiple XCode versions > > pre-installed, sel

[PATCH 0/5] ci: various CI fixes

2024-10-15 Thread Daniel P . Berrangé
This fixes various issues with CI across multiple platforms, debian, Fedora and macOS. Daniel P. Berrangé (5): meson: unconditionally enable polkit on non-Windows ci: drop polkit from build deps tests: stop stubbing libselinux APIs for purpose of data overrides wireshark: drop gmodule.h in

[PATCH 1/5] meson: unconditionally enable polkit on non-Windows

2024-10-15 Thread Daniel P . Berrangé
The polkit code does not have a build time dependancy on any system headers or libraries. It can be safely enabled on any non-Windows platform. Signed-off-by: Daniel P. Berrangé --- meson.build | 5 - 1 file changed, 5 deletions(-) diff --git a/meson.build b/meson.build index 5eb3f24181..2c

[PATCH 2/5] ci: drop polkit from build deps

2024-10-15 Thread Daniel P . Berrangé
Now that we unconditionally enable polkit, we don't need a dummy install of 'pkcheck' to trigger detection in meson. Signed-off-by: Daniel P. Berrangé --- ci/buildenv/almalinux-9.sh| 1 - ci/buildenv/alpine-319.sh | 1 - ci/buildenv/alpine-

[PATCH v2] lxc: fix variable storage order before call

2024-10-15 Thread Adam Julis
virDomainConfNWFilterInstantiate() was called without updated net->ifname, it caused in some cases throwing error message. If function failed, change is reverted. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/658 Signed-off-by: Adam Julis --- src/lxc/lxc_process.c | 16 ++--

[PATCH] apparmor: Allow running i686 VMs on Debian 12

2024-10-15 Thread Andrea Bolognani
In Debian 12, the qemu-system-i386 binary in /usr/bin is a wrapper script, with the actual executable living in /usr/libexec instead. This makes it impossible to run i686 VMs when AppArmor is enabled. Allow running the actual binary. https://bugs.debian.org/1030926 Signed-off-by: Andrea Bolognan

Re: [PATCH 5/5] ci: update macOS versions under test

2024-10-15 Thread Daniel P . Berrangé
On Tue, Oct 15, 2024 at 12:19:24PM +0100, Daniel P. Berrangé wrote: > Cirrus CI has stoppped offering multiple versions of macOS images. > > There is now only 1 single image, but with multiple XCode versions > pre-installed, selectable using the 'xcodes' app: > > $ xcodes list | grep Installe

[PATCH 4/5] wireshark: drop gmodule.h include to avoid glib warnings

2024-10-15 Thread Daniel P . Berrangé
The wireshark address.h header uses 'g_memdup2' but this triggers warnings under clang due to the max version cap: In file included from ../tools/wireshark/src/plugin.c:27: In file included from /usr/include/wireshark/epan/proto.h:30: In file included from /usr/include/wireshark/epan/p

[PATCH 5/5] ci: update macOS versions under test

2024-10-15 Thread Daniel P . Berrangé
Cirrus CI has stoppped offering multiple versions of macOS images. There is now only 1 single image, but with multiple XCode versions pre-installed, selectable using the 'xcodes' app: $ xcodes list | grep Installed 15.2 (15C500b) (Installed) 15.3 (15E204a) (Installed) 15.4 (15F31d

[PATCH 3/5] tests: stop stubbing libselinux APIs for purpose of data overrides

2024-10-15 Thread Daniel P . Berrangé
We currently create stub 'setcon', 'setcon_raw' and 'security_disable' APIs in the securityselinuxhelper.c mock, which set env variables to control how other mock'd libselinux APIs respond. These stubs merely set some env variables, and we have no need to call these stubs from the library code, on

Re: [PATCH 1/5] meson: unconditionally enable polkit on non-Windows

2024-10-15 Thread Peter Krempa
On Tue, Oct 15, 2024 at 12:19:20 +0100, Daniel P. Berrangé wrote: > The polkit code does not have a build time dependancy on any system > headers or libraries. It can be safely enabled on any non-Windows > platform. > > Signed-off-by: Daniel P. Berrangé > --- > meson.build | 5 - > 1 file ch

Re: [PATCH 2/5] ci: drop polkit from build deps

2024-10-15 Thread Peter Krempa
On Tue, Oct 15, 2024 at 12:19:21 +0100, Daniel P. Berrangé wrote: > Now that we unconditionally enable polkit, we don't need a dummy install > of 'pkcheck' to trigger detection in meson. > > Signed-off-by: Daniel P. Berrangé > --- If the consequences of the change in previous patch were intentio

Re: [PATCH 5/5] ci: update macOS versions under test

2024-10-15 Thread Daniel P . Berrangé
On Tue, Oct 15, 2024 at 04:47:59PM +0200, Peter Krempa wrote: > On Tue, Oct 15, 2024 at 13:09:57 +0100, Daniel P. Berrangé wrote: > > On Tue, Oct 15, 2024 at 01:58:00PM +0200, Peter Krempa wrote: > > > On Tue, Oct 15, 2024 at 12:19:24 +0100, Daniel P. Berrangé wrote: > > [...] > > > > > > > > >

Re: [PATCH 5/5] ci: update macOS versions under test

2024-10-15 Thread Peter Krempa
On Tue, Oct 15, 2024 at 13:09:57 +0100, Daniel P. Berrangé wrote: > On Tue, Oct 15, 2024 at 01:58:00PM +0200, Peter Krempa wrote: > > On Tue, Oct 15, 2024 at 12:19:24 +0100, Daniel P. Berrangé wrote: [...] > > > > > > "Only ghcr.io/cirruslabs/macos-runner:sonoma is allowed. > > >Automatica

Re: [PATCH] apparmor: Allow running i686 VMs on Debian 12

2024-10-15 Thread Jim Fehlig via Devel
On 10/15/24 03:57, Andrea Bolognani wrote: In Debian 12, the qemu-system-i386 binary in /usr/bin is a wrapper script, with the actual executable living in /usr/libexec instead. This makes it impossible to run i686 VMs when AppArmor is enabled. Allow running the actual binary. https://bugs.debia