Re: [Milkymist-devel] [PATCH 0/6] fpvm.c cleanup and compaction

2011-12-04 Thread Werner Almesberger
For easier review, I put the final version of fpvm.c here: http://downloads.qi-hardware.com/people/werner/tmp/fpvm.c - Werner ___ http://lists.milkymist.org/listinfo.cgi/devel-milkymist.org IRC: #milkymist@Freenode

[Milkymist-devel] [PATCH 6/6] fpvm.c: replace code patterns involving "compile" with macros

2011-12-04 Thread Werner Almesberger
--- software/libfpvm/fpvm.c | 21 +++-- 1 files changed, 11 insertions(+), 10 deletions(-) diff --git a/software/libfpvm/fpvm.c b/software/libfpvm/fpvm.c index 0b1c112..4707ff6 100644 --- a/software/libfpvm/fpvm.c +++ b/software/libfpvm/fpvm.c @@ -286,6 +286,11 @@ static int ope

[Milkymist-devel] [PATCH 5/6] fpvm.c: replace code patterns involving add_inv_sqrt and add_int with macros

2011-12-04 Thread Werner Almesberger
--- software/libfpvm/fpvm.c | 24 ++-- 1 files changed, 18 insertions(+), 6 deletions(-) diff --git a/software/libfpvm/fpvm.c b/software/libfpvm/fpvm.c index 4ad48c2..0b1c112 100644 --- a/software/libfpvm/fpvm.c +++ b/software/libfpvm/fpvm.c @@ -274,6 +274,18 @@ static int o

[Milkymist-devel] [PATCH 4/6] fpvm.c: replace code patterns with constant register with macro

2011-12-04 Thread Werner Almesberger
--- software/libfpvm/fpvm.c | 31 --- 1 files changed, 16 insertions(+), 15 deletions(-) diff --git a/software/libfpvm/fpvm.c b/software/libfpvm/fpvm.c index cd06046..4ad48c2 100644 --- a/software/libfpvm/fpvm.c +++ b/software/libfpvm/fpvm.c @@ -277,21 +277,27 @@ sta

[Milkymist-devel] [PATCH 3/6] fpvm.c: replace code patterns of register allocation with macro

2011-12-04 Thread Werner Almesberger
--- software/libfpvm/fpvm.c | 64 +-- 1 files changed, 23 insertions(+), 41 deletions(-) diff --git a/software/libfpvm/fpvm.c b/software/libfpvm/fpvm.c index 2de105c..cd06046 100644 --- a/software/libfpvm/fpvm.c +++ b/software/libfpvm/fpvm.c @@ -274,2

[Milkymist-devel] [PATCH 2/6] fpvm.c: replace code patterns involving add_isn with macros

2011-12-04 Thread Werner Almesberger
--- software/libfpvm/fpvm.c | 90 +-- 1 files changed, 48 insertions(+), 42 deletions(-) diff --git a/software/libfpvm/fpvm.c b/software/libfpvm/fpvm.c index ff924fc..2de105c 100644 --- a/software/libfpvm/fpvm.c +++ b/software/libfpvm/fpvm.c @@ -265,6

[Milkymist-devel] [PATCH 1/6] libfpvm: wrap some overlong lines in fpvm.c

2011-12-04 Thread Werner Almesberger
fpvm.c contains many lines longer than 80 characters, which makes the code hard to read. This patch wraps most of them. Some are left long, because they will be rewritten in a later patch. --- software/libfpvm/fpvm.c | 80 +++--- 1 files changed, 54 insert

[Milkymist-devel] [PATCH 0/6] fpvm.c cleanup and compaction

2011-12-04 Thread Werner Almesberger
[ Copied to the list. ] Hi Sebastien, this is a tentative set of patches that aims to improve the code clarity of fpvm.c, with the goal of making it easier to make more sweeping changes later. The more sweeping changes I have in mind are getting rid of all the string compares and making the compi