Re: [OMPI devel] ORTE registry patch

2007-05-29 Thread George Bosilca
Commit r14791 apply this patch to the trunk. Let me know if you encounter any kind of troubles. Thanks, george. On May 29, 2007, at 2:28 PM, Ralph Castain wrote: After some work off-list with Tim, it appears that something has been broken again on the OMPI trunk with respect to comm_s

Re: [OMPI devel] ORTE registry patch

2007-05-29 Thread Ralph Castain
After some work off-list with Tim, it appears that something has been broken again on the OMPI trunk with respect to comm_spawn. It was working two weeks ago, but...sigh. Anyway, it doesn't appear to have any bearing either way on George's patch(es), so whomever wants to commit them is welcome to

Re: [OMPI devel] [OMPI svn] svn:open-mpi r14789

2007-05-29 Thread Anya Tatashina
good :) thank you, Anya Ralph Castain wrote: My apologies - I reviewed the opal code and see that it wasn't what I remembered. The objection here is that strncmp returns an int, not a pointer, and hence the NULL is bothering the compiler. I'll submit the fix Thanks Ralph On 5/29/07 11:56

Re: [OMPI devel] undefined environ symbol on Darwin

2007-05-29 Thread Brian Barrett
On May 29, 2007, at 7:35 AM, Jack Howarth wrote: and if you see environ undefined, identify which library it is in and which object file it came from. I would also note that my patch reveals that several instances of the environ variable being declared that are missing the Windows wrappers. So i

Re: [OMPI devel] [OMPI svn] svn:open-mpi r14789

2007-05-29 Thread Ralph Castain
My apologies - I reviewed the opal code and see that it wasn't what I remembered. The objection here is that strncmp returns an int, not a pointer, and hence the NULL is bothering the compiler. I'll submit the fix Thanks Ralph On 5/29/07 11:56 AM, "Ralph Castain" wrote: > Hmmm...well, this o

Re: [OMPI devel] [OMPI svn] svn:open-mpi r14789

2007-05-29 Thread Ralph Castain
Hmmm...well, this operation if ( NULL == strncmp(appctx->app, OPAL_PATH_SEP, 1 )) { is not a legal one since OPAL_PATH_SEP is a character and not a NULL-terminated string and thus generates the following warning: totalview.c: In function 'orte_totalview_init_after_spawn': totalview.c:412: war

Re: [OMPI devel] ORTE registry patch

2007-05-29 Thread Ralph Castain
On 5/29/07 11:02 AM, "Tim Prins" wrote: > Well, after fixing many of the tests... Interesting - they worked fine for me. Perhaps a difference in environment. > It passes all the tests > except the spawn tests. However, the spawn tests are seriously broken > without this patch as well, and th

Re: [OMPI devel] ORTE registry patch

2007-05-29 Thread Tim Prins
Well, after fixing many of the tests... It passes all the tests except the spawn tests. However, the spawn tests are seriously broken without this patch as well, and the ibm mpi spawn tests seem to work fine. As far as I'm concerned, this should assuage any fear of problems with these cha

Re: [OMPI devel] ORTE registry patch

2007-05-29 Thread Ralph Castain
Well, I'll be the voice of caution again... Tim: did you run all of the orte tests in the orte/test/system directory? If so, and they all run correctly, then I have no issue with doing the commit. If not, then I would ask that we not do the commit until that has been done. In running those tests,

Re: [OMPI devel] ORTE registry patch

2007-05-29 Thread George Bosilca
I'd be happy to commit the patch into the trunk. But after what happened last time, I'm more than cautious. If the community think the patch is worth having it, let me know and I'll push it in the trunk asap. Thanks, george. On May 29, 2007, at 10:56 AM, Tim Prins wrote: I think bo

Re: [OMPI devel] ORTE registry patch

2007-05-29 Thread Tim Prins
I think both patches should be put in immediately. I have done some simple testing, and with 128 nodes of odin, with 1024 processes running mpi hello, these decrease our running time from about 14.2 seconds to 10.9 seconds. This is a significant decrease, and as the scale increases there sh

Re: [OMPI devel] undefined environ symbol on Darwin

2007-05-29 Thread Jack Howarth
Ralph, I don't know why such patches should be harder to maintain in Windows than on Darwin. All you do is the equivalent to... cd /sw/lib/openmpi/lib nm * | grep environ and if you see environ undefined, identify which library it is in and which object file it came from. I would also note th

Re: [OMPI devel] undefined environ symbol on Darwin

2007-05-29 Thread Jack Howarth
Brian, Below is the response I got from the fink developer who was trying to package paraview and ran into this problem with the undefined environ symbol in openmpi. I have also emailed on darwin-dev to get a clarification on this issue. However your argument against target specific chances is

[OMPI devel] Fix for deadlock in OB1 RDMA protocol

2007-05-29 Thread Gleb Natapov
Hi, Attached are two patches. First one implements new function mca_pml_ob1_send_requst_copy_in_out(req, offset, len) that sends given range of the request by copying data in/out internal buffers. It also changes the behaviour of the pipeline protocol to send data from an end of a user buffer. Th

Re: [OMPI devel] undefined environ symbol on Darwin

2007-05-29 Thread Ralph Castain
I am no expert on this issue. However, having watched those attempting to maintain the Windows port using the same approach you are advocating, I can say that requiring APPLE-specific "if...include" logic almost certainly will be an exercise in frustration, if not futility. Many of us actually deve