Hi Leif, thanks for the comments.
> - The v5 code doesn't actually make use of the kuser helper barriers
> in its versions of opal_atomic_cmpset_acq/rel.
Quote the documentation, __kuser_cmpxchg "already includes memory
barriers as needed," so the code using it shouldn't need anything
extra.
> -
And I think Jeff made me look at the code when you sent the RFC. Shame on
Jeff for making me review the same code twice ;).
Brian
On 4/24/12 2:47 PM, "Nathan Hjelm" wrote:
>This was RFC'd last month. No one objected :)
>
>-Nathan
>
>On Tue, 24 Apr 2012, Jeffrey Squyres wrote:
>
>> There's some
Ok. :-)
On Apr 24, 2012, at 4:47 PM, Nathan Hjelm wrote:
> This was RFC'd last month. No one objected :)
>
> -Nathan
>
> On Tue, 24 Apr 2012, Jeffrey Squyres wrote:
>
>> There's some pretty extensive ob1 changes in here.
>>
>> Can we get these reviewed? Brian / George?
>>
>>
>> On Apr 24,
This was RFC'd last month. No one objected :)
-Nathan
On Tue, 24 Apr 2012, Jeffrey Squyres wrote:
There's some pretty extensive ob1 changes in here.
Can we get these reviewed? Brian / George?
On Apr 24, 2012, at 4:18 PM, hje...@osl.iu.edu wrote:
Author: hjelmn
Date: 2012-04-24 16:18:56 E
There's some pretty extensive ob1 changes in here.
Can we get these reviewed? Brian / George?
On Apr 24, 2012, at 4:18 PM, hje...@osl.iu.edu wrote:
> Author: hjelmn
> Date: 2012-04-24 16:18:56 EDT (Tue, 24 Apr 2012)
> New Revision: 26329
> URL: https://svn.open-mpi.org/trac/ompi/changeset/2632
Hi Evan,
And just to add to the delay, I've been off sick...
First of all - thanks for the patch!
The patch adds support for currently unsupported platforms, without actually
changing any code paths for currently supported platforms. So from that
perspective, I would not object strongly to it be
