Re: [OMPI devel] [bug] One-sided communication with a duplicated datatype

2013-07-14 Thread George Bosilca
Takahiro, Please find below another patch, this time hopefully fixing all issues. The problem with my original patch and with yours was that they try to address the packing of the data representation without fixing the computation of the required length. As a result the length on the packer and

Re: [OMPI devel] 'make re-install' : remove 'ortecc' symlink also

2013-07-14 Thread Vasiliy
also 'opalcc', and others: make[4]: Entering directory '/usr/src/64bit/release/openmpi/openmpi-1.9.0-a1/build/opal/tools/wrappers' (cd /usr/bin; rm -f opalcc.exe; ln -s opal_wrapper opalcc) ln: failed to create symbolic link `opalcc': File exists Makefile:1972: recipe for target 'install-exec-hook

[OMPI devel] 'make re-install' : remove 'ortecc' symlink also

2013-07-14 Thread Vasiliy
Makefile: please, remove/check for 'ortecc' symlink before proceeding with install make[4]: Entering directory '/usr/src/64bit/release/openmpi/openmpi-1.9.0-a1/build/orte/tools/wrappers' test -z "/usr/bin" || /usr/bin/mkdir -p "/usr/bin" make install-data-hook (cd /usr/bin; rm -f ortecc.exe; ln -

Re: [OMPI devel] RFC: remove opal_trace macro

2013-07-14 Thread Ralph Castain
I went ahead and committed this after finding only *one* reference to OPAL_TRACE anywhere in the ompi code base. On Jul 11, 2013, at 9:05 AM, Ralph Castain wrote: > WHAT: remove the old and stale "OPAL_TRACE" macro > > WHY: it is old, stale, no longer needed, and largely unused > > WHEN: sinc

Re: [OMPI devel] [bug] One-sided communication with a duplicated datatype

2013-07-14 Thread KAWASHIMA Takahiro
George, A improved patch is attached. Latter half is same as your patch. But again, I'm not sure this is a correct solution. It works correctly for my attached put_dup_type_3.c. Run as "mpiexec -n 1 ./put_dup_type_3". It will print seven OKs if succeeded. Regards, KAWASHIMA Takahiro > No. My pa

Re: [OMPI devel] [bug] One-sided communication with a duplicated datatype

2013-07-14 Thread KAWASHIMA Takahiro
No. My patch doesn't work for a more simple case, just a duplicate of MPI_INT. Datatype is too complex for me ... Regards, KAWASHIMA Takahiro > George, > > Thanks. But no, your patch does not work correctly. > > The assertion failure disappeared by your patch but the value of the > target buff

Re: [OMPI devel] [bug] One-sided communication with a duplicated datatype

2013-07-14 Thread KAWASHIMA Takahiro
George, Thanks. But no, your patch does not work correctly. The assertion failure disappeared by your patch but the value of the target buffer of MPI_Put is not a correct one. In rdma OSC (and pt2pt OSC), the following data are packed into the send buffer in ompi_osc_rdma_sendreq_send function o

Re: [OMPI devel] [bug] One-sided communication with a duplicated datatype

2013-07-14 Thread George Bosilca
Takahiro, Nice catch. That particular code was an over-optimizations … that failed. Please try with the patch below. Let me know if it's working as expected, I will push it in the trunk once confirmed. George. Index: ompi/datatype/ompi_datatype_args.c ==

[OMPI devel] [bug] One-sided communication with a duplicated datatype

2013-07-14 Thread KAWASHIMA Takahiro
Hi, I encountered an assertion failure in Open MPI trunk and found a bug. See the attached program. This program can be run with mpiexec -n 1. This program calls MPI_Put and writes one int value to the target side. The target side datatype is equivalent to MPI_INT, but is a derived datatype creat

Re: [OMPI devel] basename: a faulty warning 'extra operand --test-name' in tests causes test-driver to fail

2013-07-14 Thread Vasiliy
I'm happy to provide you with an update on 'extra operand --test-name' occasionally being fed to 'basename' by Open MPI's testsuite, which was fixed by Automake maintainers: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14840 You may still want to look at 'test/asm/run_tests' why it was passed thro