Re: [OMPI devel] RFC: optimize probe in ob1

2014-02-19 Thread Paul Hargrove
On Wed, Feb 19, 2014 at 8:37 AM, Dave Goodell (dgoodell) wrote: > On Feb 19, 2014, at 6:36 AM, George Bosilca wrote: > > > There is one minor thing I would suggest to change. In your patch > in_unexpected_list is defined as a bool, which translates to an int on most > platforms. > > This stateme

Re: [OMPI devel] RFC: optimize probe in ob1

2014-02-19 Thread Nathan Hjelm
On Wed, Feb 19, 2014 at 04:37:41PM +, Dave Goodell (dgoodell) wrote: > On Feb 19, 2014, at 6:36 AM, George Bosilca wrote: > > > There is one minor thing I would suggest to change. In your patch > > in_unexpected_list is defined as a bool, which translates to an int on most > > platforms. >

Re: [OMPI devel] RFC: optimize probe in ob1

2014-02-19 Thread Dave Goodell (dgoodell)
On Feb 19, 2014, at 6:36 AM, George Bosilca wrote: > There is one minor thing I would suggest to change. In your patch > in_unexpected_list is defined as a bool, which translates to an int on most > platforms. This statement isn't true. sizeof(bool)==1 on my Mac and on our x86_64 Linux clust

Re: [OMPI devel] RFC: optimize probe in ob1

2014-02-19 Thread George Bosilca
Nathan, Sorry, I’m moving and will not have the time to thoughtfully review your patch before March. I quickly glanced over and things look OK, but I had no time to validate/test it. There is one minor thing I would suggest to change. In your patch in_unexpected_list is defined as a bool, whic