Re: [OMPI devel] Bad parameter in file oob_tcp.c

2014-03-05 Thread Ralph Castain
Yes - but Marco said he was going to look into it. I meant that I would fix the problem George identified, although it doesn't fix the problem Marco hit. Sorry for the confusion On Wed, Mar 5, 2014 at 2:48 PM, Paul Hargrove wrote: > Wait a second... > > Unless I am missing something Marco's e

Re: [OMPI devel] Bad parameter in file oob_tcp.c

2014-03-05 Thread Paul Hargrove
Wait a second... Unless I am missing something Marco's error means that Cygwin *did* return INADDR_ANY. According to George's research that shouldn't happen (unless on XP or older and host is an empty string). So, changing the code to check for INADDR_NONE just ignores what should be an impossibl

Re: [OMPI devel] Bad parameter in file oob_tcp.c

2014-03-05 Thread Ralph Castain
Cool - I'll make the correction. Thx! On Wed, Mar 5, 2014 at 2:08 PM, George Bosilca wrote: > I'm afraid the snippet pointed by Ralph is incorrect, as INADDR_ANY should > not be a valid return for inet_addr. Here is a quick check on different > OSes. > > On Linux, the man Page states: > > If t

Re: [OMPI devel] Bad parameter in file oob_tcp.c

2014-03-05 Thread George Bosilca
I’m afraid the snippet pointed by Ralph is incorrect, as INADDR_ANY should not be a valid return for inet_addr. Here is a quick check on different OSes. On Linux, the man Page states: > If the input is invalid, INADDR_NONE (usually -1) is returned. On Mac OS X: > The constant INADDR_NONE is re

Re: [OMPI devel] Fix compiler warnings in FT code

2014-03-05 Thread Josh Hursey
That looks great. Thanks! On Wed, Mar 5, 2014 at 12:24 PM, Ralph Castain wrote: > Nicely done - thanks! > > > > On Wed, Mar 5, 2014 at 10:14 AM, Adrian Reber wrote: > >> Josh, please have a look at: >> >> >> https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=5d5edafa36605ca7650eafa7f99fa19856

Re: [OMPI devel] Fix compiler warnings in FT code

2014-03-05 Thread Ralph Castain
Nicely done - thanks! On Wed, Mar 5, 2014 at 10:14 AM, Adrian Reber wrote: > Josh, please have a look at: > > > https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=5d5edafa36605ca7650eafa7f99fa1985641e488 > > I moved the parameter initialization to sstore_stage_register() and can > now see tha

Re: [OMPI devel] Fix compiler warnings in FT code

2014-03-05 Thread Adrian Reber
Josh, please have a look at: https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=5d5edafa36605ca7650eafa7f99fa1985641e488 I moved the parameter initialization to sstore_stage_register() and can now see that the variables are correctly used: $ orterun --mca sstore_stage_verbose 30 [...] [dcbz:028

Re: [OMPI devel] autoconf warnings: openib BTL

2014-03-05 Thread Jeff Squyres (jsquyres)
On Mar 3, 2014, at 10:59 PM, Vasily Filipov wrote: > Yes, it is possible, but there is some different if I will do it this way - > With the current implementation (today into a trunk) if AC_RUN_IFELSE fails > => old code of RDMACM will rise, > And by way you suggest, if we postpone the decisio

Re: [OMPI devel] mercurial mirror stuck to 02-19-2014

2014-03-05 Thread Jeff Squyres (jsquyres)
Fixed -- thanks for the heads up. On Mar 5, 2014, at 2:11 AM, Guillaume Papauré wrote: > Hi, > according to https://bitbucket.org/ompiteam/ompi-svn-mirror/commits/all the > bitbucket update process seems dead. > Maybe it just has to be restarted ? > > Regards, > Guillaume > _

Re: [OMPI devel] Bad parameter in file oob_tcp.c

2014-03-05 Thread Marco Atzeri
On 05/03/2014 04:06, Ralph Castain wrote: The code generating the error is here: in->sin_addr.s_addr = inet_addr(host); if (in->sin_addr.s_addr == INADDR_ANY) { return ORTE_ERR_BAD_PARAM; } The address is resolving to INADDR_ANY instead of a regular ad

[OMPI devel] mercurial mirror stuck to 02-19-2014

2014-03-05 Thread Guillaume Papauré
Hi, according to https://bitbucket.org/ompiteam/ompi-svn-mirror/commits/all the bitbucket update process seems dead. Maybe it just has to be restarted ? Regards, Guillaume