Re: [OMPI devel] coll/tuned MPI_Bcast can crash or silently fail when using distinct datatypes across tasks

2014-04-21 Thread George Bosilca
Indeed there are many potential solutions, but all require too much intervention on the code to be generic enough. As we discussed privately mid last year, the "flatten datatype" approach seems to me to be the most profitable.It is simple to implement and it is also generic, a simple change will ma

Re: [OMPI devel] Different behaviour with MPI_IN_PLACE in MPI_Reduce_scatter() and MPI_Ireduce_scatter()

2014-04-21 Thread George Bosilca
Btw, the proposed validator was incorrect the first printf instead of printf(ā€œ[%d] rbuf[%d]=%2d expected:%2d\nā€, rank, 0, recvbuf[i], size); should be printf(ā€œ[%d] rbuf[%d]=%2d expected:%2d\nā€, rank, 0, recvbuf[0], size); George. On Apr 21, 2014, at 19:32 , George Bosilca wrote: > r3

Re: [OMPI devel] Different behaviour with MPI_IN_PLACE in MPI_Reduce_scatter() and MPI_Ireduce_scatter()

2014-04-21 Thread George Bosilca
r31473 should fix this issue. George. On Apr 21, 2014, at 10:05 , Lisandro Dalcin wrote: > I'm not sure this is actually a bug, but the difference may surprise > users. It seems that the implementation of > MPI_Ireduce_scatter(MPI_IN_PLACE,...) (ab?)uses the recvbuf to compute > the intermed

Re: [OMPI devel] querying Op commutativity for predefined reduction operations.

2014-04-21 Thread George Bosilca
Thanks for the bug report (r31467). George. On Apr 21, 2014, at 06:05 , Lisandro Dalcin wrote: > IMHO, MPI_Op_commutative() should not fail for predefined reduced operations. > > [dalcinl@kw2060 openmpi]$ ompi_info --version > Open MPI v1.8 > > http://www.open-mpi.org/community/help/ > [da

Re: [OMPI devel] MPI_Type_create_hindexed_block() segfaults

2014-04-21 Thread George Bosilca
Good catch. Commit r31466. Thanks, George. On Apr 21, 2014, at 07:56 , Lisandro Dalcin wrote: > I believe the problem is in the following source code line > (file:ompi_datatype_args.c, line:221): > > https://bitbucket.org/ompiteam/ompi-svn-mirror/src/v1.8/ompi/datatype/ompi_datatype_arg

[OMPI devel] MPI_Comm_create_group()

2014-04-21 Thread Lisandro Dalcin
A very basic test for MPI_Comm_create_group() is failing for me. I'm pasting the code, the failure, and output from valgrind. [dalcinl@kw2060 openmpi]$ cat comm_create_group.c #include int main(int argc, char *argv[]) { MPI_Group group; MPI_Comm comm; MPI_Init(&argc, &argv); MPI_Comm_grou

[OMPI devel] Different behaviour with MPI_IN_PLACE in MPI_Reduce_scatter() and MPI_Ireduce_scatter()

2014-04-21 Thread Lisandro Dalcin
I'm not sure this is actually a bug, but the difference may surprise users. It seems that the implementation of MPI_Ireduce_scatter(MPI_IN_PLACE,...) (ab?)uses the recvbuf to compute the intermediate reduction, while MPI_Reduce_scatter(MPI_IN_PLACE,...) does not. Look at the following code (setup

[OMPI devel] Issues with MPI_Add_error_class()

2014-04-21 Thread Lisandro Dalcin
It seems the implementation of MPI_Add_error_class() is out of sync with the definition of MPI_ERR_LASTCODE. Please review the list of error classes in mpi.h and the code in this file: https://bitbucket.org/ompiteam/ompi-svn-mirror/src/v1.8/ompi/errhandler/errcode.c BTW, in that file, all the MP

[OMPI devel] MPI_Type_create_hindexed_block() segfaults

2014-04-21 Thread Lisandro Dalcin
I believe the problem is in the following source code line (file:ompi_datatype_args.c, line:221): https://bitbucket.org/ompiteam/ompi-svn-mirror/src/v1.8/ompi/datatype/ompi_datatype_args.c?at=v1.8#cl-221 I think you should just remove that bogus line, and that's all. [dalcinl@kw2060 openmpi]$ c

[OMPI devel] Win_fence() with assertion=MPI_MODE_NOPRECEDE|MPI_MODE_NOSUCCEED

2014-04-21 Thread Lisandro Dalcin
Open MPI errors in Win_fence() when the assertion contains both MPI_MODE_NOPRECEDE and MPI_MODE_NOSUCCEED Could you explain me why the following code is wrong? Please note that the fence call with assertion !=0 is issued before and after fence calls with assertion=0, and I'm not making any modific

[OMPI devel] querying Op commutativity for predefined reduction operations.

2014-04-21 Thread Lisandro Dalcin
IMHO, MPI_Op_commutative() should not fail for predefined reduced operations. [dalcinl@kw2060 openmpi]$ ompi_info --version Open MPI v1.8 http://www.open-mpi.org/community/help/ [dalcinl@kw2060 openmpi]$ cat op_commutative.c #include int main(int argc, char *argv[]) { int flag; MPI_Init(&arg