Re: [OMPI devel] heads up about OMPI/master

Enough folks - we all have different methods of working, and despite all the angst, it all seems to work. Gilles: there is nothing wrong with the master. It works fine. Let’s get back to doing something useful > On Dec 1, 2016, at 5:15 PM, Gilles Gouaillardet wrote: > > Paul, > > > that is

Re: [OMPI devel] heads up about OMPI/master

Paul, that is a fair point, and i do not mind *always* using the github merge button if this is what is best for most of us. by the way, what was the issue in the first place ? - broken master ? - a bunch of commits that did not break anything but that could have been pushed accidentally ?

Re: [OMPI devel] heads up about OMPI/master

With regard to timezone - we have developers in close timezones, so I don't think this is a reasonable argument. 2016-12-01 16:49 GMT-08:00 Artem Polyakov : > +1 to Paul. > > I had to go git-bisect OMPI only several times but it always was a > non-trivial task. PR's are grouping commit's logicall

Re: [OMPI devel] heads up about OMPI/master

+1 to Paul. I had to go git-bisect OMPI only several times but it always was a non-trivial task. PR's are grouping commit's logically and are good for the bookkeeping. Also you never know what will a "trivial fix" turn into and in what circumstances/configurations. IMO all changes needs to go thro

Re: [OMPI devel] heads up about OMPI/master

On Thu, Dec 1, 2016 at 4:25 PM, Gilles Gouaillardet wrote: [...] > git checkout master > > git merge --ff-only topic/misc_fixes > > git push origin master > [...] Gilles, You characterized the merge commit has having "close to zero added value" to you - but in this instance it would have saved

Re: [OMPI devel] heads up about OMPI/master

Let it go, guys - enough already. The PR shows as having been merged, the master is running fine, so let’s move on. > On Dec 1, 2016, at 4:24 PM, Artem Polyakov wrote: > > Exactly this commit > https://github.com/open-mpi/ompi/commit/15098161a331168c66b29a696522fe52c8b2d8f5 > >

Re: [OMPI devel] heads up about OMPI/master

Hi Howard and all, i did push this intentionally, and i will run some more tests from now. fwiw, these commits ran through the CI via PR https://github.com/open-mpi/ompi/pull/2488 most of the time, and because of "my" time zone, the code base is not modified between the time i submit my

Re: [OMPI devel] heads up about OMPI/master

Exactly this commit https://github.com/open-mpi/ompi/commit/15098161a331168c66b29a696522fe52c8b2d8f5 wan't part of that PR 2016-12-01 16:21 GMT-08:00 Howard Pritchard : > Ralph, > > I don't know how it happened but if you do > > git log --oneline --topo-order > > you don't see a Merge pull reques

Re: [OMPI devel] heads up about OMPI/master

No idea - but it clearly came via the PR > On Dec 1, 2016, at 4:21 PM, Howard Pritchard wrote: > > Ralph, > > I don't know how it happened but if you do > > git log --oneline --topo-order > > you don't see a Merge pull request #2488 in the history for master. > > Howard > > > 2016-12-01 1

Re: [OMPI devel] heads up about OMPI/master

Ralph, I don't know how it happened but if you do git log --oneline --topo-order you don't see a Merge pull request #2488 in the history for master. Howard 2016-12-01 16:59 GMT-07:00 r...@open-mpi.org : > Ummm...guys, it was done via PR. I saw it go by, and it was all done to > procedure: >

Re: [OMPI devel] heads up about OMPI/master

Ummm...guys, it was done via PR. I saw it go by, and it was all done to procedure: https://github.com/open-mpi/ompi/pull/2488 So please don’t jump to conclusions > On Dec 1, 2016, at 3:49 PM, Artem Polyakov wrote: > > But I guess that we can verif

Re: [OMPI devel] heads up about OMPI/master

But I guess that we can verify that things are not broken using other PR's. Looks that all is good: https://github.com/open-mpi/ompi/pull/2493 2016-12-01 15:38 GMT-08:00 Artem Polyakov : > All systems are different and it is hard to compete in coverage with our > set of Jenkins' :). > > 2016-12-0

Re: [OMPI devel] heads up about OMPI/master

All systems are different and it is hard to compete in coverage with our set of Jenkins' :). 2016-12-01 14:51 GMT-08:00 r...@open-mpi.org : > FWIW: I verified it myself, and it was fine on my systems > > On Dec 1, 2016, at 2:46 PM, Gilles Gouaillardet < > gilles.gouaillar...@gmail.com> wrote: > >

Re: [OMPI devel] heads up about OMPI/master

Howard, can you link to commits you are referring? Do you mean this one for example: https://github.com/open-mpi/ompi/commit/15098161a331168c66b29a696522fe52c8b2d8f5 ? 2016-12-01 15:28 GMT-08:00 Howard Pritchard : > Hi Gilles > > I didn't see a merge commit for all these commits, > hence my conc

Re: [OMPI devel] heads up about OMPI/master

Hi Gilles I didn't see a merge commit for all these commits, hence my concern that it was a mistake. In general it's better to pull in commits via PR process. Howard Am Donnerstag, 1. Dezember 2016 schrieb Gilles Gouaillardet : > fwiw, the major change is in https://github.com/open-mpi/ompi/co

Re: [OMPI devel] heads up about OMPI/master

FWIW: I verified it myself, and it was fine on my systems > On Dec 1, 2016, at 2:46 PM, Gilles Gouaillardet > wrote: > > fwiw, the major change is in > https://github.com/open-mpi/ompi/commit/c9aeccb84e4626c350af4daa974d37775db5b25e > >

Re: [OMPI devel] heads up about OMPI/master

fwiw, the major change is in https://github.com/open-mpi/ompi/commit/c9aeccb84e4626c350af4daa974d37775db5b25e and i did spend quite some time testing it. if you are facing some unexpected issues with the latest master, you might try to revert this locally and see if it helps Cheers, Gilles On F

Re: [OMPI devel] heads up about OMPI/master

Howard, i pushed a bunch of commits yesterday, and that was not an accident. you might be referring https://github.com/open-mpi/ompi/commit/cb55c88a8b7817d5891ff06a447ea190b0e77479 but it has already been reverted 9 days ago with https://github.com/open-mpi/ompi/commit/1e2019ce2a903be24361b3424d8e

Re: [OMPI devel] heads up about OMPI/master

I should add, FWIW: I’m working with the HEAD of master right now, and not seeing any problems. > On Dec 1, 2016, at 2:10 PM, r...@open-mpi.org wrote: > > ?? I see a bunch of commits that were all collected in a single PR from > Gilles yesterday - is that what you are referring to? > >> On Dec

Re: [OMPI devel] heads up about OMPI/master

?? I see a bunch of commits that were all collected in a single PR from Gilles yesterday - is that what you are referring to? > On Dec 1, 2016, at 1:58 PM, Howard Pritchard wrote: > > Hi Folks, > > Just an FYI it looks like a bunch of commits may have been accidentally > pushed to > master s

[OMPI devel] heads up about OMPI/master

Hi Folks, Just an FYI it looks like a bunch of commits may have been accidentally pushed to master sometime in the past day. You may not want to merge origin/master (if origin is how you reference https://github.com/open-mpi/omp) into your master or rebase off of it until we get some clarity on w

[OMPI devel] Reminder: sign up for OMPI Jan meeting

Hey folks So far, I’m the only one who has signed up for the Jan 24-26 meeting in the Bay area. I’m going to be a very lonely person! The meeting page is: https://github.com/open-mpi/ompi/wiki/Meeting-2017-01 If you cannot sign up yoursel