Re: [OMPI devel] mpi/java question

2013-02-20 Thread Dmitri Gribenko
On Wed, Feb 20, 2013 at 10:05 PM, Ralph Castain wrote: > > On Feb 20, 2013, at 11:39 AM, Dmitri Gribenko wrote: > >> On Wed, Feb 20, 2013 at 9:34 PM, Jeff Squyres (jsquyres) >> wrote: >>> If someone could write some generic java code to figure out the size of a &g

Re: [OMPI devel] mpi/java question

2013-02-20 Thread Dmitri Gribenko
On Wed, Feb 20, 2013 at 9:34 PM, Jeff Squyres (jsquyres) wrote: > If someone could write some generic java code to figure out the size of a > java type (and either printf it out, or write it to a file, or otherwise be > able to give that value to a shell script), that would be a good start. No

Re: [OMPI devel] [EXTERNAL] Re: Compile-time MPI_Datatype checking

2012-11-19 Thread Dmitri Gribenko
On Mon, Nov 19, 2012 at 6:51 PM, Jeff Squyres wrote: > On Nov 19, 2012, at 11:47 AM, Dmitri Gribenko wrote: > >>> 3. the warnings are disabled for buffer types of (char*) or (void*) >> >> I think that disabling warnings for char* might make sense. But >> du

Re: [OMPI devel] [EXTERNAL] Re: Compile-time MPI_Datatype checking

2012-11-19 Thread Dmitri Gribenko
On Mon, Nov 19, 2012 at 6:35 PM, Jeff Squyres wrote: > (SC is now over, and, aside from the US holiday later this week, I'm picking > up the items that I've let fall on the floor for the past 1-2 months...) > > On Oct 31, 2012, at 3:51 PM, Barrett, Brian W wrote: > >> That said, if we didn't thro

Re: [OMPI devel] [EXTERNAL] Re: Compile-time MPI_Datatype checking

2012-10-31 Thread Dmitri Gribenko
On Wed, Oct 31, 2012 at 9:51 PM, Barrett, Brian W wrote: > On 10/31/12 1:39 PM, "Paul Hargrove" wrote: > >>No, I don't have specific usage cases that concern me. >> >> >>As I said a minute or two ago in a reply to Ralph, my concern is that the >>Sandia codes provide an "existence proof" that "rea

Re: [OMPI devel] Compile-time MPI_Datatype checking

2012-10-31 Thread Dmitri Gribenko
On Wed, Oct 31, 2012 at 9:11 PM, Paul Hargrove wrote: > Ralph, > > I work at a National Lab, and like many of my peers I develop/prototype > codes on my desktop and/or laptop. So, I think the default behavior of > mpicc on a Clang-based Mac is entirely relevant. > > FWIW: > I agree w/ Jeff that t

Re: [OMPI devel] Compile-time MPI_Datatype checking

2012-10-31 Thread Dmitri Gribenko
On Wed, Oct 31, 2012 at 9:04 PM, Ralph Castain wrote: > Understood, but also remember that the national labs don't have Mac clusters > - and so they couldn't care less about Clang. Clang is also the new system compiler for FreeBSD. But there are not many FreeBSD clusters either. Dmitri -- mai

Re: [OMPI devel] Compile-time MPI_Datatype checking

2012-10-31 Thread Dmitri Gribenko
On Wed, Oct 31, 2012 at 5:04 PM, Jeff Squyres wrote: > On Oct 31, 2012, at 9:38 AM, Dmitri Gribenko wrote: > >>> The rationale here is that correct MPI applications should not need to add >>> any extra compiler files to compile without warnings. >> >> I

Re: [OMPI devel] Compile-time MPI_Datatype checking

2012-10-31 Thread Dmitri Gribenko
On Wed, Oct 31, 2012 at 2:36 PM, Jeff Squyres wrote: > On Oct 31, 2012, at 3:45 AM, Dmitri Gribenko wrote: > >>> With this patch, they'd get warnings about these uses, even though they are >>> completely valid according to MPI. >>> >>> A suggestio

Re: [OMPI devel] Compile-time MPI_Datatype checking

2012-10-31 Thread Dmitri Gribenko
On Wed, Oct 31, 2012 at 4:25 AM, Jeff Squyres wrote: > On Oct 28, 2012, at 10:28 AM, Dmitri Gribenko wrote: > >> Thank you for the feedback! Hopefully the attached patch fixes both of >> these. >> >> 1. There are two helper structs with complex numbers. I predica

Re: [OMPI devel] Compile-time MPI_Datatype checking

2012-10-28 Thread Dmitri Gribenko
On Sun, Oct 28, 2012 at 3:51 PM, Jeff Squyres wrote: > On Oct 26, 2012, at 12:48 PM, Dmitri Gribenko wrote: > >> Thank you for reviewing and helping me to get this up to the project's >> standards! > > Thank *you*. > > My prior reviews were from reading the cod

Re: [OMPI devel] Compile-time MPI_Datatype checking

2012-10-26 Thread Dmitri Gribenko
On Fri, Oct 26, 2012 at 6:37 PM, Jeff Squyres wrote: > This all now looks good to me Thank you for reviewing and helping me to get this up to the project's standards! > For me to commit this, can you do two things: > > 1. I hate to do this, but this is more than a "trivial" patch that we could

Re: [OMPI devel] Compile-time MPI_Datatype checking

2012-10-19 Thread Dmitri Gribenko
On Thu, Oct 18, 2012 at 7:32 PM, Jeff Squyres wrote: > On Oct 7, 2012, at 2:25 PM, Dmitri Gribenko wrote: >> I tried to follow your advice about Fortran datatypes and updated the >> patch accordingly (attached). This patch is against OpenMPI 1.9. >> Please review. > &g

Re: [OMPI devel] Compile-time MPI_Datatype checking

2012-10-18 Thread Dmitri Gribenko
On Thu, Oct 18, 2012 at 7:32 PM, Jeff Squyres wrote: > On Oct 7, 2012, at 2:25 PM, Dmitri Gribenko wrote: > Hmm. I'm not sure how to do that -- I don't know of any C compiler that has > built-in #defines for what Fortran types exist. > > I'm open to suggestions

Re: [OMPI devel] Compile-time MPI_Datatype checking

2012-10-18 Thread Dmitri Gribenko
Dear OpenMPI developers, Could someone please review the attached patch? Dmitri On Sun, Oct 7, 2012 at 9:25 PM, Dmitri Gribenko wrote: > On Thu, May 31, 2012 at 2:38 PM, Jeff Squyres wrote: >> On May 31, 2012, at 7:29 AM, Jeff Squyres wrote: >> >>>>> We should h

Re: [OMPI devel] Compile-time MPI_Datatype checking

2012-10-07 Thread Dmitri Gribenko
On Thu, May 31, 2012 at 2:38 PM, Jeff Squyres wrote: > On May 31, 2012, at 7:29 AM, Jeff Squyres wrote: > We should have AC macros for all of these already. >>> >>> OK, I'll try find them to support (1) usecase described below. >> >> No, I'll find them -- sorry, I meant to look them up before

Re: [OMPI devel] 1.6.1rc3 - 3 of 5 tests failed on OSX 10.8

2012-08-20 Thread Dmitri Gribenko
On Mon, Aug 20, 2012 at 12:30 PM, Jeff Squyres wrote: > I see a clang 3.1 on http://llvm.org/releases/, but I don't see a 4.0. Is > that a released version? Apple Clang has a different and unrelated version numbering compared to open source clang. Dmitri -- main(i,j){for(i=2;;i++){for(j=2;j*

Re: [OMPI devel] Compile-time MPI_Datatype checking

2012-05-31 Thread Dmitri Gribenko
On Thu, May 31, 2012 at 2:29 PM, Jeff Squyres wrote: > Ah, good point.  But in those cases, MPI specifically defines that those > arguments are wholly ignored on non-root processes.  So you could still even > pass <&foo, MPI_DATATYPE_NULL>, or , and it would be ok. I see. If this warning is im

Re: [OMPI devel] Compile-time MPI_Datatype checking

2012-05-31 Thread Dmitri Gribenko
On Thu, May 31, 2012 at 2:07 PM, Jeff Squyres wrote: > On May 30, 2012, at 7:04 PM, Dmitri Gribenko wrote: >> +must_be_null specifies that the expression should be a null >> +pointer constant, for example: >> + >> + >> + >> +/* In mpi.h */ >>

Re: [OMPI devel] Compile-time MPI_Datatype checking

2012-05-30 Thread Dmitri Gribenko
Hi Jeff, On Thu, May 31, 2012 at 12:57 AM, Jeff Squyres wrote: > I've reviewed the patch.  Good stuff! Thank you very much for the review. Answers to comments below. Updated patch attached. *** JMS What do the 3-argument forms of type_tag_for_datatype() do? They aren't described in ht

[OMPI devel] Compile-time MPI_Datatype checking

2012-05-29 Thread Dmitri Gribenko
Hello, I've implemented a patch for clang that enables compile-time checking of arguments to functions. When applied to MPI, this enables the compiler to check that buffer type and MPI_Datatype match. Latest version of clang patch can be found here. [1] Please note that clang patch was not yet

Re: [OMPI devel] Building otfcompress with binutils-gold fails

2012-02-18 Thread Dmitri Gribenko
On Sat, Feb 18, 2012 at 11:59 AM, Matthias Jurenz wrote: > Does that mean that the workaround I suggested (extra linkage of -lz) is not > needed anymore? It is needed for SVN checkout until it is migrated to the same libtool as 1.7 tarball. Dmitri -- main(i,j){for(i=2;;i++){for(j=2;j*/

Re: [OMPI devel] Building otfcompress with binutils-gold fails

2012-02-17 Thread Dmitri Gribenko
Hi Jeff, On Fri, Feb 17, 2012 at 1:14 PM, Jeff Squyres wrote: > Are you compiling a nightly 1.7/trunk tarball, or an SVN checkout where you > ran autogen.pl? I was compiling an SVN checkout. > The 1.7 nightly tarballs are built with the latest Libtool (2.4.2).  If that > isn't doing the Right

Re: [OMPI devel] Building otfcompress with binutils-gold fails

2012-02-15 Thread Dmitri Gribenko
On Wed, Feb 15, 2012 at 8:08 PM, Jeff Squyres wrote: > What is "gold"?  Can you send all the information listed here (e.g., I don't > know what version of Open MPI you're reporting about): gold is the new binutils linker. OS: Debian sid amd64 with g++-4.6, binutils-gold packages installed OpenM

[OMPI devel] Building otfcompress with binutils-gold fails

2012-02-15 Thread Dmitri Gribenko
Hi, I've found that otfcompress doesn't build with gold: make[3]: Entering directory `/home/storage_3/grib/ompi-build/ompi/contrib/vt/vt/extlib/otf/tools/otfcompress' /bin/sh ../../libtool --tag=CC --mode=link clang -O3 -DNDEBUG -finline-functions -fno-strict-aliasing -pthread -I/home/storage

Re: [OMPI devel] VT build failure with Clang++

2012-02-15 Thread Dmitri Gribenko
On Wed, Feb 15, 2012 at 10:56 AM, Paul Hargrove wrote: > I strongly suspect that this is a Clang++ bug. I don't know if it is a Clang bug, but here's my understanding of the problem. TokenFactoryScopeC::create() boils down to this: template uint32_t TokenFactoryScopeC::create( const void * loc

Re: [OMPI devel] Compile-time MPI_Datatype checking

2012-02-02 Thread Dmitri Gribenko
On Thu, Feb 2, 2012 at 7:31 AM, Christopher Samuel wrote: > On 29/01/12 10:07, Dmitri Gribenko wrote: >> My colleague and I want to implement a compile-time check (warning) >> for clang compiler that specified buffer type matches passed >> MPI_Datatype. > > Interestin

Re: [OMPI devel] Compile-time MPI_Datatype checking

2012-02-01 Thread Dmitri Gribenko
On Wed, Feb 1, 2012 at 10:01 PM, Jeff Squyres wrote: > On Jan 28, 2012, at 6:07 PM, Dmitri Gribenko wrote: >> Here's what is required on the OpenMPI part: all MPI functions that >> accept a buffer and MPI_Datatype should be annotated with >> mpi_typed_arg(buffer

[OMPI devel] Compile-time MPI_Datatype checking

2012-01-28 Thread Dmitri Gribenko
compile-time checks. I would like to hear if there is any issue with this idea or implementation design that could prevent the corresponding patch for mpi.h to be accepted. Dmitri Gribenko -- main(i,j){for(i=2;;i++){for(j=2;j*/ ../../../llvm/tools/clang/test/Sema/warn-mpi-type-mismatch.