Re: [O-MPI devel] Registration Cache changes

2005-10-19 Thread Galen Mark Shipman
> On Wed, Oct 19, 2005 at 09:05:41AM -0600, Galen Mark Shipman wrote: >> We changed things a bit in the mpool, the deregister will remove the >> registration from the cache and then call release, if the reference >> count >> is <=0, the memory is then deregistered, otherwise it will be >> deregiste

Re: [O-MPI devel] Registration Cache changes

2005-10-19 Thread Gleb Natapov
On Wed, Oct 19, 2005 at 09:05:41AM -0600, Galen Mark Shipman wrote: > We changed things a bit in the mpool, the deregister will remove the > registration from the cache and then call release, if the reference count > is <=0, the memory is then deregistered, otherwise it will be deregistered > later

Re: [O-MPI devel] Registration Cache changes

2005-10-19 Thread Galen Mark Shipman
We changed things a bit in the mpool, the deregister will remove the registration from the cache and then call release, if the reference count is <=0, the memory is then deregistered, otherwise it will be deregistered later via another release call. The BTL module increments the reference count on

Re: [O-MPI devel] Registration Cache changes

2005-10-19 Thread Gleb Natapov
Hello Galen, It seams this issue is still present and can be easily triggered. (see attached program). Do you have plans to fix it? On Wed, Sep 21, 2005 at 12:06:18PM -0600, Galen M. Shipman wrote: > Gleb, > > > > > Gleb Natapov wrote: > > > >> Hello Galen, > >> > >> Finally I've got some time t

Re: [O-MPI devel] Registration Cache changes

2005-09-21 Thread Galen M. Shipman
Gleb, Gleb Natapov wrote: Hello Galen, Finally I've got some time to look through the new code. I have couple of notes. In pml_ob1_rdma.c you try to merge registrations in the number of places. The code looks like this: btl_mpool->mpool_deregister(btl_mpool, reg); btl_mpool->mpool_regis

Re: [O-MPI devel] Registration Cache changes

2005-09-21 Thread Tim S. Woodall
Gleb Natapov wrote: Hello Galen, Finally I've got some time to look through the new code. I have couple of notes. In pml_ob1_rdma.c you try to merge registrations in the number of places. The code looks like this: btl_mpool->mpool_deregister(btl_mpool, reg); btl_mpool->mpool_register(bt

Re: [O-MPI devel] Registration Cache changes

2005-09-21 Thread Gleb Natapov
Hello Galen, Finally I've got some time to look through the new code. I have couple of notes. In pml_ob1_rdma.c you try to merge registrations in the number of places. The code looks like this: btl_mpool->mpool_deregister(btl_mpool, reg); btl_mpool->mpool_register(btl_mpool,

Re: [O-MPI devel] Registration Cache changes

2005-09-14 Thread Gleb Natapov
On Wed, Sep 14, 2005 at 08:40:49AM -0600, Galen M. Shipman wrote: > Hi Gleb, Hello Galen, I checked out the new code and am looking at it now. Thanks! > > Tim and I have incorporated some of the changes you mentioned into a > new rcache framework. Currently there is a single component in this

[O-MPI devel] Registration Cache changes

2005-09-14 Thread Galen M. Shipman
Hi Gleb, Tim and I have incorporated some of the changes you mentioned into a new rcache framework. Currently there is a single component in this framework, rcache_rb which is a registration cache based on a red- black tree and uses an MRU list if the registration is not persistent. Note