Re: [OMPI devel] Bug in opal sos changes

2010-05-18 Thread Ralph Castain
Hmmm...well, the way that function -used- to work was it returned an error code, and had the index as a *int param in the function call. Tim P changed it awhile back (don't remember exactly why, but it was when he moved the pointer_array code from orte to opal), and I'm not sure the fixes it requir

Re: [OMPI devel] Bug in opal sos changes

2010-05-18 Thread Abhishek Kulkarni
On Tue, 18 May 2010, Rolf vandeVaart wrote: I think we are almost saying the same thing. But to be sure, I will restate. The call to opal_pointer_array_add() can return either an index (which I assume is a positive integer, maybe also 0?) or OPAL_ERR_OUT_OF_RESOURCE (which is a -2) if it can

Re: [OMPI devel] Bug in opal sos changes

2010-05-18 Thread Rolf vandeVaart
I think we are almost saying the same thing. But to be sure, I will restate. The call to opal_pointer_array_add() can return either an index (which I assume is a positive integer, maybe also 0?) or OPAL_ERR_OUT_OF_RESOURCE (which is a -2) if it cannot malloc anymore space in the table. So, I g

Re: [OMPI devel] Bug in opal sos changes

2010-05-18 Thread Jeff Squyres
Looks like the comparison to OMPI_ERROR worked by accident -- just because it happened to have a value of -1. The *_f_to_c_index values are the return value from a call to opal_point_array_add(). This value will either be non-negative or -1. -1 indicates a failure. It's not an *_ERR_* code

[OMPI devel] Bug in opal sos changes

2010-05-18 Thread Rolf vandeVaart
I am getting SEGVs while running the IMB-MPI1 tests. I believe the problem has to do with changes made to the group_init.c file last night. The error occurs in the call to MPI_Comm_split. There were 4 changes in the file that look like this: OLD: if (OMPI_ERROR == new_group->grp_f_to_c_index