Re: [OMPI devel] Minor typo in opal/class/opal_list.h

2017-02-23 Thread Clement FOYER
Thank you Gilles for your answer. Pull request #3023 added. Cheers, Clément FOYER On 02/23/2017 03:35 PM, gil...@rist.or.jp wrote: Thanks Clement, the best way is to make a pull request. your commit must contain a Signed-off-by: ... line in order to be considered for inclusion. and that can

Re: [OMPI devel] Minor typo in opal/class/opal_list.h

2017-02-23 Thread gilles
Thanks Clement, the best way is to make a pull request. your commit must contain a Signed-off-by: ... line in order to be considered for inclusion. and that can be achieved wirh git commit -s signing off a commit has some legal implications, so i encourage you to read the FAQ (and make sure you

[OMPI devel] Minor typo in opal/class/opal_list.h

2017-02-23 Thread Clement FOYER
Hi everyone, I found a typo in the comment for the opal_list_item_compare_fn_t typedef (opal/class/opal_list.h:877). It says the functions should return "11" instead of "-1" for a < b. Should I open a issue on the github, or is there already a thread where to add minor typo mistakes, or shoul