Re: [OMPI devel] Speedup for MPI_Dims_create()

2014-02-10 Thread Jeff Squyres (jsquyres)
Cool. See the other thread where I'm wondering if we shouldn't just pre-generate all the primes, hard-code them into a table, and be done with this issue. On Feb 10, 2014, at 5:19 PM, Andreas Schäfer wrote: > Jeff- > > I've seen that you've reverted the patch as it was faulty. Sorry about >

Re: [OMPI devel] Speedup for MPI_Dims_create()

2014-02-10 Thread Andreas Schäfer
Jeff- I've seen that you've reverted the patch as it was faulty. Sorry about that! I've attached a new patch, which applies against the current trunk. The problem with the last patch was that it didn't catch a special case: of all prime factors of n, there may be at most one larger than sqrt(n). T

Re: [OMPI devel] Speedup for MPI_Dims_create()

2014-02-03 Thread Jeff Squyres (jsquyres)
Andreas -- I added the sqrt() change, which is the most important change, and then did a 2nd commit with the whitespace cleanup. The sqrt change will likely be in 1.7.5. I credited you in the commit log; you'll likely also get credited in NEWS. Thank you for the patch! On Dec 19, 2013, at

Re: [OMPI devel] Speedup for MPI_Dims_create()

2013-12-19 Thread Jeff Squyres (jsquyres)
Andreas -- Thanks for the patch. Can I ask two things? 1. Can you separate the patch into two: one with the code change, and another with the whitespace update? It will help the readability of the logs to see the exact code change, rather than bury it in a syntax update. 2. You added a copyr

[OMPI devel] Speedup for MPI_Dims_create()

2013-12-19 Thread Andreas Schäfer
Dear all, please find attached a (trivial) patch to MPI_Dims_create(). When computing the prime factors of nnodes, it is sufficient to check for primes less or equal to sqrt(nnodes). This was not so much of a problem in the past, but now that Tier 0 systems are capable of running O(10^6) MPI proc