Re: [OMPI devel] Unsolicited code review of new distscript.sh

2015-04-27 Thread Jeff Squyres (jsquyres)
On Apr 27, 2015, at 11:44 AM, Dave Goodell (dgoodell) wrote: > >> Neat trick about perl -pie; I wasn't aware of that. > > Make sure to write it as "-pi -e" (as Paul had it) or "-p -i -e", or it > probably won't do what you expect. I did, but I'm curious -- why wouldn't "-pie" work? ...ah, af

Re: [OMPI devel] Unsolicited code review of new distscript.sh

2015-04-27 Thread Dave Goodell (dgoodell)
On Apr 27, 2015, at 8:54 AM, Jeff Squyres (jsquyres) wrote: > Neat trick about perl -pie; I wasn't aware of that. Make sure to write it as "-pi -e" (as Paul had it) or "-p -i -e", or it probably won't do what you expect. >> On Apr 23, 2015, at 10:42 PM, Paul Hargrove wrote: >> >> Since perl

Re: [OMPI devel] Unsolicited code review of new distscript.sh

2015-04-27 Thread Jeff Squyres (jsquyres)
Paul -- Thanks for the suggestions. I took them as a starting point; it looks like much of distscript is moot these days, so I trimmed most of it out (it really only has to set repo_rev in VERSION these days). Neat trick about perl -pie; I wasn't aware of that. FWIW: I like heredoc notation i

[OMPI devel] Unsolicited code review of new distscript.sh

2015-04-23 Thread Paul Hargrove
I gave "make dist" a try on NetBSD (with its own /bin/sh) and Ubuntu Trusty (w/ /bin/sh symlinked to dash). Both generated the tarballs, but dash spewed some warnings on the unalias commands. So here is my code review (roughly as long as the scipt itself). 1) #!/usr/bin/env sh The presence of