Re: [OMPI devel] cleanup of rr_byobj

2014-03-27 Thread tmishima
I added two improvements. Please replace the previous patch file by this attached one, and take a look this week end. 1. Add pre-check for ORTE_ERR_NOT_FOUND to make retry with byslot work afterward correctly. Otherwise, the retry could fail, because some fields such as node->procs, node->slots_

Re: [OMPI devel] cleanup of rr_byobj

2014-03-25 Thread tmishima
no problem - it's a minor cleanup. Tetsuya > Hi Tetsuya > > Let me take a look when I get home this weekend - I'm giving an ORTE tutorial to a group of new developers this week and my time is very limited. > > Thanks > Ralph > > > > On Tue, Mar 25, 2014 at 5:37 PM, wrote: > > Hi Ralph, I moved

Re: [OMPI devel] cleanup of rr_byobj

2014-03-25 Thread Ralph Castain
Hi Tetsuya Let me take a look when I get home this weekend - I'm giving an ORTE tutorial to a group of new developers this week and my time is very limited. Thanks Ralph On Tue, Mar 25, 2014 at 5:37 PM, wrote: > > Hi Ralph, I moved on to the development list. > > I'm not sure why add_one fla

[OMPI devel] cleanup of rr_byobj

2014-03-25 Thread tmishima
Hi Ralph, I moved on to the development list. I'm not sure why add_one flag is used in the rr_byobj. Here, if oversubscribed, proc is mapped to each object one by one. So, I think the add_one is not necesarry. Instead, when the user doesn't permit oversubscription, the second pass should be skip