Re: [OMPI devel] more oshmem issues

2013-09-21 Thread Jeff Squyres (jsquyres)
Don't forget to add this to the shmem CMR. Sent from my phone. No type good. On Sep 21, 2013, at 9:29 AM, "Jeff Squyres (jsquyres)" mailto:jsquy...@cisco.com>> wrote: Thank you! Sent from my phone. No type good. On Sep 21, 2013, at 3:27 AM, "Mike Dubman" mailto:mi...@dev.mellanox.co.il>> wro

Re: [OMPI devel] more oshmem issues

2013-09-21 Thread Jeff Squyres (jsquyres)
Thank you! Sent from my phone. No type good. On Sep 21, 2013, at 3:27 AM, "Mike Dubman" mailto:mi...@dev.mellanox.co.il>> wrote: Hi, Sorry about that. the fix is here: r29223 Regards M On Fri, Sep 20, 2013 at 7:32 PM, Jeff Squyres (jsquyres) mailto:jsquy...@cisco.com>> wrote: Mellanox -- P

Re: [OMPI devel] more oshmem issues

2013-09-21 Thread Mike Dubman
Hi, Sorry about that. the fix is here: r29223 Regards M On Fri, Sep 20, 2013 at 7:32 PM, Jeff Squyres (jsquyres) wrote: > Mellanox -- > > Please remove all uses of bzero. memset is the portable way to go here. > > > > On Sep 20, 2013, at 12:30 PM, "David Goodell (dgoodell)" < > dgood...@cisco

[OMPI devel] more oshmem issues

2013-09-20 Thread Jeff Squyres (jsquyres)
Mellanox -- Please remove all uses of bzero. memset is the portable way to go here. On Sep 20, 2013, at 12:30 PM, "David Goodell (dgoodell)" wrote: > "bzero" should be avoided for maximum portability. Just use "memset" > instead. Even older versions of GCC know how to spot the 0 constant