Re: [OMPI devel] openib btl code review

2008-05-18 Thread Gleb Natapov
On Thu, May 15, 2008 at 11:58:02PM -0400, Jeff Squyres wrote: > I updated the patch on https://svn.open-mpi.org/trac/ompi/ticket/1285 > per Gleb's suggestions (I made a few commits tonight with some of the > non-receive-queues-patch-related fixes) and with some fixes for issues > that Nysal f

Re: [OMPI devel] openib btl code review

2008-05-15 Thread Jeff Squyres
I updated the patch on https://svn.open-mpi.org/trac/ompi/ticket/1285 per Gleb's suggestions (I made a few commits tonight with some of the non-receive-queues-patch-related fixes) and with some fixes for issues that Nysal found. Please see the most recent patch on the ticket. On May 15,

Re: [OMPI devel] openib btl code review

2008-05-15 Thread Jeff Squyres
On May 15, 2008, at 8:46 AM, Gleb Natapov wrote: Any other reviewers would be welcome... :-) I'll look at it next week too. Thanks. - some random style cleanup - fix a few minor memory leaks These two are the only ones that are really separate from the rest. - adapt _ini.c to accept th

Re: [OMPI devel] openib btl code review

2008-05-15 Thread Gleb Natapov
On Thu, May 15, 2008 at 08:14:29AM -0400, Jeff Squyres wrote: > Pasha tells me he'll be able to review the patch next week, so I'll > wait to commit until then. I added the patch to the ticket, just so > that it doesn't get lost. > > Any other reviewers would be welcome... :-) I'll look at i

Re: [OMPI devel] openib btl code review

2008-05-15 Thread Jeff Squyres
Pasha tells me he'll be able to review the patch next week, so I'll wait to commit until then. I added the patch to the ticket, just so that it doesn't get lost. Any other reviewers would be welcome... :-) On May 14, 2008, at 5:39 PM, Jeff Squyres wrote: https://svn.open-mpi.org/trac/ompi

[OMPI devel] openib btl code review

2008-05-14 Thread Jeff Squyres
https://svn.open-mpi.org/trac/ompi/ticket/1285 turned out to be more complicated than expected (of course). The startup in the openib btl mixes resource discovery and initialization (vs. doing discovery, deciding which hcas/ports/lids to use, initializing them, and then assigning resources