Re: [OMPI devel] [OMPI svn] svn:open-mpi r14444

2007-04-25 Thread George Bosilca
In fact, if you find any internal Open MPI code which call directly the MPI functions you should raise the flag. It's a design choice, the MPI API is for the users, when you need to call any MPI like functions from inside ompi you need to take another path. In the collectives we're using th

Re: [OMPI devel] [OMPI svn] svn:open-mpi r14444

2007-04-24 Thread Josh Hursey
Actually, after doing a quick grep through the code base it seems that the tuned collectives use the PML start interface without going through the MPI level call (as far as I could tell). So since I don't know the full impact of such a change I'm going to not make this change and leave it f

Re: [OMPI devel] [OMPI svn] svn:open-mpi r14444

2007-04-20 Thread Josh Hursey
Yeah I was not actually sure what the standard said about passing an array of requests and having one of the elements be NULL. This just seemed like a subtle bug when I was looking through the code. Taking a quick look at the check in mpi/c/startall.c it seems that we do check for this case

Re: [OMPI devel] [OMPI svn] svn:open-mpi r14444

2007-04-20 Thread George Bosilca
I think the NULL test is a left over from long ago. At one point in the past we decided that all MPI related tests have to be done outside the PML functions (i.e. in the MPI layer). The test for request == NULL is present in the start.c and startall.c. Anywhere else (i.e. where we use internally