Re: [OMPI devel] [OMPI svn] svn:open-mpi r21285

2009-05-27 Thread Ralph Castain
First, this is in the code path where mpirun outputs to stdout/stderr. Hardly a "critical path". :-) Second, I know about the overwrite problem, but wanted to first see if this met Greg's needs. If you look, you will see that the overwrite problem has -always- been there in the code, but we didn't

Re: [OMPI devel] [OMPI svn] svn:open-mpi r21285

2009-05-27 Thread George Bosilca
Ralph, This patch is not correct. First it adds a significant overhead in terms of if in the critical path (3 more ifs per char in the output stream), and second it will generate random segfaults. The test for the orte_xml_output can be centralized in just one if, reducing the overhead to