Re: [OMPI devel] [OMPI svn] svn:open-mpi r23767

2010-09-20 Thread Jeff Squyres
On Sep 20, 2010, at 11:48 AM, Barrett, Brian W wrote: > Sorry, was out of town last week. The patch undoes the discussion we had -- > we always run component macros, even if the component couldn't build, to > solve the issue of AC_CONFIG_FILES needing to always be run. Ah RIGHT -- *that* was

Re: [OMPI devel] [OMPI svn] svn:open-mpi r23767

2010-09-20 Thread Barrett, Brian W
Jeff - Sorry, was out of town last week. The patch undoes the discussion we had -- we always run component macros, even if the component couldn't build, to solve the issue of AC_CONFIG_FILES needing to always be run. So the first part of the patch is incorrect and should not be committed. We

Re: [OMPI devel] [OMPI svn] svn:open-mpi r23767

2010-09-18 Thread Jeff Squyres
On Sep 18, 2010, at 4:54 PM, Ralph Castain wrote: > Good point - nothing secret about it! Yes, nothing secret, but it's kinda deep in our ompi_mca.m4 file. I'm not quite sure why Brian removed the AS_IF clause when we did the changes; I don't know if he had a deep reason for it or not. But it

Re: [OMPI devel] [OMPI svn] svn:open-mpi r23767

2010-09-18 Thread Ralph Castain
On Sep 18, 2010, at 8:46 AM, Ralf Wildenhues wrote: > Hi Jeff, > > * Jeff Squyres wrote on Sat, Sep 18, 2010 at 01:39:44PM CEST: >> On Sep 18, 2010, at 10:03 AM, Jeff Squyres wrote: >> >>> So it's still on my list to go back and figure out what changed >>> (i.e., it didn't complain about valgri

Re: [OMPI devel] [OMPI svn] svn:open-mpi r23767

2010-09-18 Thread Ralf Wildenhues
Hi Jeff, * Jeff Squyres wrote on Sat, Sep 18, 2010 at 01:39:44PM CEST: > On Sep 18, 2010, at 10:03 AM, Jeff Squyres wrote: > > > So it's still on my list to go back and figure out what changed > > (i.e., it didn't complain about valgrind's version before this -- so > > something must have changed

Re: [OMPI devel] [OMPI svn] svn:open-mpi r23767

2010-09-18 Thread Jeff Squyres
On Sep 18, 2010, at 10:03 AM, Jeff Squyres wrote: > So it's still on my list to go back and figure out what changed (i.e., it > didn't complain about valgrind's version before this -- so something must > have changed. We don't use --without-valgrind when configuring, so I'm not > sure why it s

Re: [OMPI devel] [OMPI svn] svn:open-mpi r23767

2010-09-18 Thread Jeff Squyres
On Sep 18, 2010, at 9:19 AM, Ralph Castain wrote: > Ha! I did that earlier too, but then realized that this error happens only > when someone specifies they want-valigrind. I believe the issue here has been > discussed before - if someone says "give me valgrind support", then we should > error

Re: [OMPI devel] [OMPI svn] svn:open-mpi r23767

2010-09-18 Thread Ralph Castain
Ha! I did that earlier too, but then realized that this error happens only when someone specifies they want-valigrind. I believe the issue here has been discussed before - if someone says "give me valgrind support", then we should error out if the required level isn't available. yes? You must