Re: [OMPI devel] [OMPI svn] svn:open-mpi r25303

2011-10-18 Thread Ralph Castain
On Oct 17, 2011, at 8:55 PM, George Bosilca wrote: > > On Oct 17, 2011, at 18:23 , Ralph Castain wrote: > >> >> On Oct 17, 2011, at 4:14 PM, George Bosilca wrote: >> >>> Ralph, >>> >>> I have a concern about the code below (snippet from the commit 25303). You >>> moved the setting of proc_f

Re: [OMPI devel] [OMPI svn] svn:open-mpi r25303

2011-10-17 Thread George Bosilca
On Oct 17, 2011, at 18:23 , Ralph Castain wrote: > > On Oct 17, 2011, at 4:14 PM, George Bosilca wrote: > >> Ralph, >> >> I have a concern about the code below (snippet from the commit 25303). You >> moved the setting of proc_flags and proc_name in a function named set_arch. >> As the name a

Re: [OMPI devel] [OMPI svn] svn:open-mpi r25303

2011-10-17 Thread Ralph Castain
On Oct 17, 2011, at 4:14 PM, George Bosilca wrote: > Ralph, > > I have a concern about the code below (snippet from the commit 25303). You > moved the setting of proc_flags and proc_name in a function named set_arch. > As the name and the lengthy comment above it indicate, the scope of this >

Re: [OMPI devel] [OMPI svn] svn:open-mpi r25303

2011-10-17 Thread George Bosilca
Ralph, I have a concern about the code below (snippet from the commit 25303). You moved the setting of proc_flags and proc_name in a function named set_arch. As the name and the lengthy comment above it indicate, the scope of this particular function is to set the architecture of the remote pro