riday, November 04, 2011 07:46 PM Eastern Standard Time
> To: Open MPI Developers
> Cc: Christopher Yeoh
> Subject: Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r25431
>
> Why not? I use asserts all the time in OMPI code. A quick grep in
> ompi/mca says I'm no
I agree with Brian
Sent with Good (www.good.com)
-Original Message-
From: Barrett, Brian W [mailto:bwba...@sandia.gov]
Sent: Friday, November 04, 2011 07:46 PM Eastern Standard Time
To: Open MPI Developers
Cc: Christopher Yeoh
Subject:Re: [OMPI devel] [OMPI svn
FWIW: assert is used throughout the codebase, including orte and opal. I see no
reason why it shouldn't be used here as well.
On Nov 4, 2011, at 5:45 PM, Barrett, Brian W wrote:
> Why not? I use asserts all the time in OMPI code. A quick grep in
> ompi/mca says I'm not alone. There are a who
Why not? I use asserts all the time in OMPI code. A quick grep in
ompi/mca says I'm not alone. There are a whole bunch of places where I
"know" a fact, such as a pointer never being NULL or consistency checks
between two values. These don't need to run in production; I've
theoretically tested t
+1 -- we shouldn't be using assert().
On Nov 4, 2011, at 2:15 PM, Tim Mattox wrote:
> I doubt you want to be using assert() here or anywhere in the
> OMPI library. If the rem_info.rem_qps pointer is NULL, I would
> think you want to do something other than just die.
> And, in a production build,
I doubt you want to be using assert() here or anywhere in the
OMPI library. If the rem_info.rem_qps pointer is NULL, I would
think you want to do something other than just die.
And, in a production build, if it was to ever be null, things would
eventually crash right? The ompi library should striv