Re: [OMPI devel] [bug/fix] correction of a small bug in conf file parsing

2013-06-21 Thread Piotr Lesnicki
Le 21/06/2013 15:03, Jeff Squyres (jsquyres) a écrit : Can you submit a combined patch when ready? Ok, i'll make a combined lex patch.

Re: [OMPI devel] [bug/fix] correction of a small bug in conf file parsing

2013-06-21 Thread Jeff Squyres (jsquyres)
On Jun 21, 2013, at 7:40 AM, Piotr Lesnicki wrote: > 1) you are right, an eof in the middle of a section must be > handled explicitly, otherwise it ends by an unrelated error later, > just as it currently does. By the way, here it ends with > [no-options-error] which has no corresponding m

Re: [OMPI devel] [bug/fix] correction of a small bug in conf file parsing

2013-06-21 Thread Piotr Lesnicki
Hi, 1) you are right, an eof in the middle of a section must be handled explicitly, otherwise it ends by an unrelated error later, just as it currently does. By the way, here it ends with [no-options-error] which has no corresponding message in 'help-opal-wrapper.txt'. I joined t

Re: [OMPI devel] [bug/fix] correction of a small bug in conf file parsing

2013-06-20 Thread Jeff Squyres (jsquyres)
Piotr -- Many thanks for the patch. Sorry, our lex is quite a bit rusty, and it took us quite a while to look at this. :-\ I have a few questions: 1. What happens if the file ends while in ? E.g., if a the last line of the file is "/* Hello". 2. Does this same kind of fixup need to be appl