Re: [OMPI devel] Master broken

2018-06-04 Thread Jeff Squyres (jsquyres) via devel
Fix should now be merged. > On Jun 4, 2018, at 1:20 PM, Peter Kjellström wrote: > > On Sun, 3 Jun 2018 08:41:42 -0700 > Thananon Patinyasakdikul wrote: > >> It is tested against 1.5. it should not work with lower version. I >> will fix it. > > FWIW, it also builds ok against up to date libfa

Re: [OMPI devel] Master broken

2018-06-04 Thread Peter Kjellström
On Sun, 3 Jun 2018 08:41:42 -0700 Thananon Patinyasakdikul wrote: > It is tested against 1.5. it should not work with lower version. I > will fix it. FWIW, it also builds ok against up to date libfabric (1.6.1). /Peter > Arm > > On Sun, Jun 3, 2018, 7:43 AM r...@open-mpi.org > wrote: > > >

Re: [OMPI devel] Master broken

2018-06-03 Thread Thananon Patinyasakdikul
It is tested against 1.5. it should not work with lower version. I will fix it. Arm On Sun, Jun 3, 2018, 7:43 AM r...@open-mpi.org wrote: > Here are more problems with a different version of libfabric: > > *btl_ofi_component.c:* In function ‘*validate_info*’: > *btl_ofi_component.c:64:23:* *err

Re: [OMPI devel] Master broken

2018-06-03 Thread r...@open-mpi.org
Here are more problems with a different version of libfabric: btl_ofi_component.c: In function ‘validate_info’: btl_ofi_component.c:64:23: error: ‘FI_MR_VIRT_ADDR’ undeclared (first use in this function) (mr_mode & ~(FI_MR_VIRT_ADDR | FI_MR_ALLOCATED | FI_MR_PROV_KEY)) == 0)) {

Re: [OMPI devel] master broken on (at least) OpenBSD-6

2016-09-22 Thread Gilles Gouaillardet
Thanks Paul, i fixed that (and 4 more errors that popped up) in the attached patch i opened https://github.com/open-mpi/ompi/pull/2110, but will likely merge the first 3 commits quite soon. /* the last two commits fix autogen.pl on OpenBSD 6.0 and need a review */ so you'd better use the a

Re: [OMPI devel] Master broken for ILP32

2016-05-09 Thread Paul Hargrove
default or is this just surprising? > > > > From: devel on behalf of Paul Hargrove > Sent: Monday, May 09, 2016 11:12:16 AM > To: Open MPI Developers > Subject: Re: [OMPI devel] Master broken for ILP32 > > Regarding "distro&q

Re: [OMPI devel] Master broken for ILP32

2016-05-09 Thread Hjelm, Nathan Thomas
11:12:16 AM To: Open MPI Developers Subject: Re: [OMPI devel] Master broken for ILP32 Regarding "distro": This was happening, for instance, on OpenBSD and NetBSD (32-bit kernels on 64-bit h/w) when testing your PR1643. However, it sounds like Nathan knows how/where to fix this. HOWEVE

Re: [OMPI devel] Master broken for ILP32

2016-05-09 Thread Paul Hargrove
Regarding "distro": This was happening, for instance, on OpenBSD and NetBSD (32-bit kernels on 64-bit h/w) when testing your PR1643. However, it sounds like Nathan knows how/where to fix this. HOWEVER, that is not the only issue here. Why is master is picking the BUILTIN (__sync) atomics (as shown

Re: [OMPI devel] Master broken for ILP32

2016-05-09 Thread Hjelm, Nathan Thomas
Nevermind. Looks like there are two different macros for 64-bit and one is wrong in this case. Fix incoming. From: devel on behalf of Gilles Gouaillardet Sent: Monday, May 09, 2016 2:22:24 AM To: Open MPI Developers Subject: Re: [OMPI devel] Master

Re: [OMPI devel] Master broken for ILP32

2016-05-09 Thread Hjelm, Nathan Thomas
problem in vader but it looks like there are more places that need to be fixed. From: devel on behalf of Gilles Gouaillardet Sent: Monday, May 09, 2016 2:22:24 AM To: Open MPI Developers Subject: Re: [OMPI devel] Master broken for ILP32 Paul, on which

Re: [OMPI devel] Master broken for ILP32

2016-05-09 Thread Gilles Gouaillardet
Paul, on which distro are you running ? are you compiling on a 64 bit distro to generate a 32 bit library ? it seems we are currently only testing a atomic on a long (32 bits on a 32 bits arch) and then incorrectly assume it works also on 64 bits (!) Cheers, Gilles On 5/9/2016 3:59 P