This patch finally make it's way back into the trunk. I had to modify
it to fit again into the source, but hopefully I manage to do it
right. I did some testing and it seems to not harm anything. I split
it up in several commits, in order to have a clean submission with
one commit related t
On 6/6/07 9:21 AM, "Tim Prins" wrote:
> Actually, the tests are quite painful to run, since there are things in
> there that aren't real tests (such as spin, no-op, loob-child, etc) and
> I really don't know what the expected output should be.
Actually, they are tests - you just have to know how
Actually, the tests are quite painful to run, since there are things in
there that aren't real tests (such as spin, no-op, loob-child, etc) and
I really don't know what the expected output should be.
Anyways, I have made my way through these things, and I could not see
any failures. This shoul
Sigh...is it really so much to ask that we at least run the tests in
orte/test/system and orte/test/mpi using both mpirun and singleton (where
appropriate) instead of just relying on "well I ran hello_world"?
That is all I have ever asked, yet it seems to be viewed as a huge
impediment. Is it real
I hate to go back to this, but...
The original commits also included changes to gpr_replica_dict_fn.c
(r14331 and r14336). This change shows some performance improvement for
me (about %8 on mpi hello, 123 nodes, 4ppn), and cleans up some ugliness
in the gpr. Again, this is a algorithmic change
Commit r14791 apply this patch to the trunk. Let me know if you
encounter any kind of troubles.
Thanks,
george.
On May 29, 2007, at 2:28 PM, Ralph Castain wrote:
After some work off-list with Tim, it appears that something has
been broken
again on the OMPI trunk with respect to comm_s
After some work off-list with Tim, it appears that something has been broken
again on the OMPI trunk with respect to comm_spawn. It was working two weeks
ago, but...sigh.
Anyway, it doesn't appear to have any bearing either way on George's
patch(es), so whomever wants to commit them is welcome to
On 5/29/07 11:02 AM, "Tim Prins" wrote:
> Well, after fixing many of the tests...
Interesting - they worked fine for me. Perhaps a difference in environment.
> It passes all the tests
> except the spawn tests. However, the spawn tests are seriously broken
> without this patch as well, and th
Well, after fixing many of the tests... It passes all the tests
except the spawn tests. However, the spawn tests are seriously broken
without this patch as well, and the ibm mpi spawn tests seem to work
fine.
As far as I'm concerned, this should assuage any fear of problems
with these cha
Well, I'll be the voice of caution again...
Tim: did you run all of the orte tests in the orte/test/system directory? If
so, and they all run correctly, then I have no issue with doing the commit.
If not, then I would ask that we not do the commit until that has been done.
In running those tests,
I'd be happy to commit the patch into the trunk. But after what
happened last time, I'm more than cautious. If the community think
the patch is worth having it, let me know and I'll push it in the
trunk asap.
Thanks,
george.
On May 29, 2007, at 10:56 AM, Tim Prins wrote:
I think bo
I think both patches should be put in immediately. I have done some
simple testing, and with 128 nodes of odin, with 1024 processes
running mpi hello, these decrease our running time from about 14.2
seconds to 10.9 seconds. This is a significant decrease, and as the
scale increases there sh
Thanks - I'll take a look at this (and the prior ones!) in the next couple
of weeks when time permits and get back to you.
Ralph
On 5/23/07 1:11 PM, "George Bosilca" wrote:
> Attached is another patch to the ORTE layer, more specifically the
> replica. The idea is to decrease the number of str
13 matches
Mail list logo
