Re: [OMPI devel] about r32685

2014-09-09 Thread Gilles Gouaillardet
Brice, the goal of the test is to check whether a function declaration is already present in one of the header. in order to achieve this, the test will redeclare the function with an absurd prototype : strncasecmp(int,long,int,long,int,long,int,long,int,long); /* by the way, there is no prototyp

Re: [OMPI devel] about r32685

2014-09-09 Thread Brice Goglin
Gilles, The strange configure check comes from this commit https://github.com/open-mpi/hwloc/commit/6a9299ce9d1cb1c13b3b346fe6fdfed2df75c672 Are you sure your patch won't break something else? I'll ask Pavan what he thinks about your patch. I agree that it's crazy we don't find strncasecmp on som

Re: [OMPI devel] about r32685

2014-09-08 Thread Gilles Gouaillardet
Ralph, ok, let me clarify my point : tolower() is invoked in : opal/mca/hwloc/hwloc191/hwloc/src/misc.c and ctype.h is already #include'd in this file tolower() is also invoked in : opal/mca/hwloc/hwloc191/hwloc/include/private/misc.h *only* if HWLOC_HAVE_DECL_STRNCASECMP is not #define'd : sta

Re: [OMPI devel] about r32685

2014-09-08 Thread Ralph Castain
I'll have to let Brice comment on the config change. All I can say is that "tolower" on my CentOS box is defined in , and that has to be included in the misc.h header. On Sep 8, 2014, at 5:49 PM, Gilles Gouaillardet wrote: > Ralph and Brice, > > i noted Ralph commited r32685 in order to fix